From 4aa1cf5e26d49ab1273d6affc58a5ac70b870ec4 Mon Sep 17 00:00:00 2001
From: Matthew Swift <matthew.swift@forgerock.com>
Date: Fri, 29 Mar 2013 14:55:14 +0000
Subject: [PATCH] Very minor code cleanup to requests and responses package:
---
opendj3/opendj-ldap-sdk/src/main/java/org/forgerock/opendj/ldap/responses/AbstractResultImpl.java | 80 ++++++++-------------------------------
1 files changed, 17 insertions(+), 63 deletions(-)
diff --git a/opendj3/opendj-ldap-sdk/src/main/java/org/forgerock/opendj/ldap/responses/AbstractResultImpl.java b/opendj3/opendj-ldap-sdk/src/main/java/org/forgerock/opendj/ldap/responses/AbstractResultImpl.java
index f17fcea..4d0f4a0 100644
--- a/opendj3/opendj-ldap-sdk/src/main/java/org/forgerock/opendj/ldap/responses/AbstractResultImpl.java
+++ b/opendj3/opendj-ldap-sdk/src/main/java/org/forgerock/opendj/ldap/responses/AbstractResultImpl.java
@@ -44,38 +44,12 @@
Result {
// For local errors caused by internal exceptions.
private Throwable cause = null;
-
private String diagnosticMessage = "";
-
private String matchedDN = "";
-
private final List<String> referralURIs = new LinkedList<String>();
-
private ResultCode resultCode;
- /**
- * Creates a new modifiable result implementation using the provided result
- * code.
- *
- * @param resultCode
- * The result code.
- * @throws NullPointerException
- * If {@code resultCode} was {@code null}.
- */
- AbstractResultImpl(final ResultCode resultCode) {
- this.resultCode = resultCode;
- }
-
- /**
- * Creates a new modifiable result that is an exact copy of the provided
- * result.
- *
- * @param result
- * The result to be copied.
- * @throws NullPointerException
- * If {@code result} was {@code null}.
- */
- AbstractResultImpl(Result result) {
+ AbstractResultImpl(final Result result) {
super(result);
this.cause = result.getCause();
this.diagnosticMessage = result.getDiagnosticMessage();
@@ -84,9 +58,11 @@
this.resultCode = result.getResultCode();
}
- /**
- * {@inheritDoc}
- */
+ AbstractResultImpl(final ResultCode resultCode) {
+ this.resultCode = resultCode;
+ }
+
+ @Override
public final S addReferralURI(final String uri) {
Validator.ensureNotNull(uri);
@@ -94,68 +70,50 @@
return getThis();
}
- /**
- * {@inheritDoc}
- */
+ @Override
public final Throwable getCause() {
return cause;
}
- /**
- * {@inheritDoc}
- */
+ @Override
public final String getDiagnosticMessage() {
return diagnosticMessage;
}
- /**
- * {@inheritDoc}
- */
+ @Override
public final String getMatchedDN() {
return matchedDN;
}
- /**
- * {@inheritDoc}
- */
+ @Override
public final List<String> getReferralURIs() {
return referralURIs;
}
- /**
- * {@inheritDoc}
- */
+ @Override
public final ResultCode getResultCode() {
return resultCode;
}
- /**
- * {@inheritDoc}
- */
+ @Override
public final boolean isReferral() {
final ResultCode code = getResultCode();
return code.equals(ResultCode.REFERRAL);
}
- /**
- * {@inheritDoc}
- */
+ @Override
public final boolean isSuccess() {
final ResultCode code = getResultCode();
return !code.isExceptional();
}
- /**
- * {@inheritDoc}
- */
+ @Override
public final S setCause(final Throwable cause) {
this.cause = cause;
return getThis();
}
- /**
- * {@inheritDoc}
- */
+ @Override
public final S setDiagnosticMessage(final String message) {
if (message == null) {
this.diagnosticMessage = "";
@@ -166,9 +124,7 @@
return getThis();
}
- /**
- * {@inheritDoc}
- */
+ @Override
public final S setMatchedDN(final String dn) {
if (dn == null) {
this.matchedDN = "";
@@ -179,9 +135,7 @@
return getThis();
}
- /**
- * {@inheritDoc}
- */
+ @Override
public final S setResultCode(final ResultCode resultCode) {
Validator.ensureNotNull(resultCode);
--
Gitblit v1.10.0