From e7b3515b687c082229fc3106ea7badbc2dc61d4a Mon Sep 17 00:00:00 2001
From: Matthew Swift <matthew.swift@forgerock.com>
Date: Fri, 20 Sep 2013 23:14:42 +0000
Subject: [PATCH] Fix various FindBugs warnings.

---
 opendj3/opendj-ldap-sdk/src/main/java/org/forgerock/opendj/ldif/AbstractLDIFWriter.java |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/opendj3/opendj-ldap-sdk/src/main/java/org/forgerock/opendj/ldif/AbstractLDIFWriter.java b/opendj3/opendj-ldap-sdk/src/main/java/org/forgerock/opendj/ldif/AbstractLDIFWriter.java
index f2469a8..c053ec6 100644
--- a/opendj3/opendj-ldap-sdk/src/main/java/org/forgerock/opendj/ldif/AbstractLDIFWriter.java
+++ b/opendj3/opendj-ldap-sdk/src/main/java/org/forgerock/opendj/ldif/AbstractLDIFWriter.java
@@ -353,10 +353,9 @@
          * If the value contains a null, newline, or return character, then it
          * needs to be base64 encoded.
          */
-        byte b;
         for (int i = 0; i < bytes.length(); i++) {
-            b = bytes.byteAt(i);
-            if (b > 127 || b < 0) {
+            final byte b = bytes.byteAt(i);
+            if (b < 0) {
                 return true;
             }
 

--
Gitblit v1.10.0