From 952f4c2a863432a75118ba5abf3c2377511dda1c Mon Sep 17 00:00:00 2001
From: Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Date: Fri, 27 Sep 2013 13:14:09 +0000
Subject: [PATCH] opendj-ldap-sdk org.forgerock.opendj.ldap.requests.*TestCase.java: Removed redundant code transforming Object arrays back and forth.
---
opendj3/opendj-ldap-sdk/src/test/java/org/forgerock/opendj/ldap/requests/AddRequestTestCase.java | 23 +++++++----------------
1 files changed, 7 insertions(+), 16 deletions(-)
diff --git a/opendj3/opendj-ldap-sdk/src/test/java/org/forgerock/opendj/ldap/requests/AddRequestTestCase.java b/opendj3/opendj-ldap-sdk/src/test/java/org/forgerock/opendj/ldap/requests/AddRequestTestCase.java
index 1603ff1..9af360d 100644
--- a/opendj3/opendj-ldap-sdk/src/test/java/org/forgerock/opendj/ldap/requests/AddRequestTestCase.java
+++ b/opendj3/opendj-ldap-sdk/src/test/java/org/forgerock/opendj/ldap/requests/AddRequestTestCase.java
@@ -22,6 +22,7 @@
*
*
* Copyright 2010 Sun Microsystems, Inc.
+ * Portions copyright 2013 ForgeRock AS
*/
package org.forgerock.opendj.ldap.requests;
@@ -36,26 +37,16 @@
public class AddRequestTestCase extends RequestTestCase {
@DataProvider(name = "addRequests")
public Object[][] getAddRequests() throws Exception {
- final AddRequest[] requests = {
+ return getTestRequests();
+ }
+
+ @Override
+ protected AddRequest[] createTestRequests() throws Exception {
+ return new AddRequest[] {
Requests.newAddRequest(DN.valueOf("uid=addrequest1")),
Requests.newAddRequest("cn=addrequesttestcase"),
Requests.newAddRequest("dn: ou=People,o=test", "objectClass: top",
"objectClass: organizationalUnit", "ou: People")
};
- final Object[][] objArray = new Object[requests.length][1];
- for (int i = 0; i < requests.length; i++) {
- objArray[i][0] = requests[i];
- }
- return objArray;
- }
-
- @Override
- protected AddRequest[] createTestRequests() throws Exception {
- final Object[][] objs = getAddRequests();
- final AddRequest[] ops = new AddRequest[objs.length];
- for (int i = 0; i < objs.length; i++) {
- ops[i] = (AddRequest) objs[i][0];
- }
- return ops;
}
}
--
Gitblit v1.10.0