From 952f4c2a863432a75118ba5abf3c2377511dda1c Mon Sep 17 00:00:00 2001
From: Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Date: Fri, 27 Sep 2013 13:14:09 +0000
Subject: [PATCH] opendj-ldap-sdk org.forgerock.opendj.ldap.requests.*TestCase.java: Removed redundant code transforming Object arrays back and forth.
---
opendj3/opendj-ldap-sdk/src/test/java/org/forgerock/opendj/ldap/requests/ModifyRequestTestCase.java | 23 +++++++----------------
1 files changed, 7 insertions(+), 16 deletions(-)
diff --git a/opendj3/opendj-ldap-sdk/src/test/java/org/forgerock/opendj/ldap/requests/ModifyRequestTestCase.java b/opendj3/opendj-ldap-sdk/src/test/java/org/forgerock/opendj/ldap/requests/ModifyRequestTestCase.java
index 8035509..b4aeda4 100644
--- a/opendj3/opendj-ldap-sdk/src/test/java/org/forgerock/opendj/ldap/requests/ModifyRequestTestCase.java
+++ b/opendj3/opendj-ldap-sdk/src/test/java/org/forgerock/opendj/ldap/requests/ModifyRequestTestCase.java
@@ -22,6 +22,7 @@
*
*
* Copyright 2010 Sun Microsystems, Inc.
+ * Portions copyright 2013 ForgeRock AS
*/
package org.forgerock.opendj.ldap.requests;
@@ -37,7 +38,12 @@
public class ModifyRequestTestCase extends RequestTestCase {
@DataProvider(name = "ModifyRequests")
public Object[][] getModifyRequests() throws Exception {
- final ModifyRequest[] requests = {
+ return getTestRequests();
+ }
+
+ @Override
+ protected ModifyRequest[] createTestRequests() throws Exception {
+ return new ModifyRequest[] {
Requests.newModifyRequest(DN.valueOf("uid=Modifyrequest1")).addModification(
ModificationType.ADD, "userpassword", "password"),
Requests.newModifyRequest("cn=Modifyrequesttestcase").addModification(
@@ -45,21 +51,6 @@
Requests.newModifyRequest("dn: ou=People,o=test", "changetype: modify",
"add: userpassword", "userpassword: password")
};
- final Object[][] objArray = new Object[requests.length][1];
- for (int i = 0; i < requests.length; i++) {
- objArray[i][0] = requests[i];
- }
- return objArray;
- }
-
- @Override
- protected ModifyRequest[] createTestRequests() throws Exception {
- final Object[][] objs = getModifyRequests();
- final ModifyRequest[] ops = new ModifyRequest[objs.length];
- for (int i = 0; i < objs.length; i++) {
- ops[i] = (ModifyRequest) objs[i][0];
- }
- return ops;
}
}
--
Gitblit v1.10.0