From 4a87d0ed96753944d40e2a7bc4fc64f342767649 Mon Sep 17 00:00:00 2001
From: Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Date: Tue, 04 Feb 2014 10:49:25 +0000
Subject: [PATCH] Factorized a lot of String joining code into Utils.joinAsString(). Removed unjustified uses of LocalizedMessageBuilder. Removed a few calls to String.valueOf() with arguments of LocalizableMessageBuilder.append().
---
opendj3-server-dev/src/server/org/opends/server/admin/PropertyDefinitionUsageBuilder.java | 19 +++----------------
1 files changed, 3 insertions(+), 16 deletions(-)
diff --git a/opendj3-server-dev/src/server/org/opends/server/admin/PropertyDefinitionUsageBuilder.java b/opendj3-server-dev/src/server/org/opends/server/admin/PropertyDefinitionUsageBuilder.java
index 9b80d01..915d0af 100644
--- a/opendj3-server-dev/src/server/org/opends/server/admin/PropertyDefinitionUsageBuilder.java
+++ b/opendj3-server-dev/src/server/org/opends/server/admin/PropertyDefinitionUsageBuilder.java
@@ -25,17 +25,16 @@
* Portions Copyright 2014 ForgeRock AS
*/
package org.opends.server.admin;
+
import org.forgerock.i18n.LocalizableMessage;
import org.forgerock.i18n.LocalizableMessageBuilder;
-
+import org.forgerock.util.Utils;
import java.text.NumberFormat;
import java.util.EnumSet;
import java.util.Set;
import java.util.TreeSet;
-
-
/**
* A property definition visitor which can be used to generate syntax
* usage information.
@@ -189,22 +188,10 @@
}
} else {
Set<String> values = new TreeSet<String>();
-
for (Object value : EnumSet.allOf(d.getEnumClass())) {
values.add(value.toString().trim().toLowerCase());
}
-
- boolean isFirst = true;
- LocalizableMessageBuilder builder = new LocalizableMessageBuilder();
- for (String s : values) {
- if (!isFirst) {
- builder.append(" | ");
- }
- builder.append(s);
- isFirst = false;
- }
-
- return builder.toMessage();
+ return LocalizableMessage.raw(Utils.joinAsString(" | ", values));
}
}
--
Gitblit v1.10.0