From eeff6e075405c2b9da6cff923ad4dd2b1f94b448 Mon Sep 17 00:00:00 2001
From: Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Date: Mon, 03 Feb 2014 13:50:34 +0000
Subject: [PATCH] Removed now useless calls to .toString() on arguments of Logger.*(...).
---
opendj3-server-dev/src/server/org/opends/server/api/AuthenticationPolicyState.java | 35 ++++++++++++++---------------------
1 files changed, 14 insertions(+), 21 deletions(-)
diff --git a/opendj3-server-dev/src/server/org/opends/server/api/AuthenticationPolicyState.java b/opendj3-server-dev/src/server/org/opends/server/api/AuthenticationPolicyState.java
index b1e274f..0d2458b 100644
--- a/opendj3-server-dev/src/server/org/opends/server/api/AuthenticationPolicyState.java
+++ b/opendj3-server-dev/src/server/org/opends/server/api/AuthenticationPolicyState.java
@@ -127,9 +127,8 @@
{
if (logger.isTraceEnabled())
{
- logger.trace("Attribute %s resolves to true for user entry "
- + "%s", attributeType.getNameOrOID(),
- entry.getName().toString());
+ logger.trace("Attribute %s resolves to true for user entry %s",
+ attributeType.getNameOrOID(), entry.getName());
}
return ConditionResult.TRUE;
@@ -140,9 +139,8 @@
{
if (logger.isTraceEnabled())
{
- logger.trace("Attribute %s resolves to false for user "
- + "entry %s", attributeType.getNameOrOID(), entry.getName()
- .toString());
+ logger.trace("Attribute %s resolves to false for user entry %s",
+ attributeType.getNameOrOID(), entry.getName());
}
return ConditionResult.FALSE;
@@ -152,7 +150,7 @@
{
logger.trace("Unable to resolve value %s for attribute %s "
+ "in user entry %s as a Boolean.", valueString,
- attributeType.getNameOrOID(), entry.getName().toString());
+ attributeType.getNameOrOID(), entry.getName());
}
final LocalizableMessage message = ERR_PWPSTATE_CANNOT_DECODE_BOOLEAN
@@ -165,8 +163,8 @@
if (logger.isTraceEnabled())
{
logger.trace("Returning %s because attribute %s does not exist "
- + "in user entry %s", ConditionResult.UNDEFINED.toString(),
- attributeType.getNameOrOID(), entry.getName().toString());
+ + "in user entry %s", ConditionResult.UNDEFINED,
+ attributeType.getNameOrOID(), entry.getName());
}
return ConditionResult.UNDEFINED;
@@ -215,10 +213,8 @@
if (logger.isTraceEnabled())
{
logger.traceException(e);
-
logger.trace("Unable to decode value %s for attribute %s "
- + "in user entry %s: %s", v.getValue().toString(),
- attributeType.getNameOrOID(), entry.getName().toString(),
+ + "in user entry %s: %s", v.getValue(), attributeType.getNameOrOID(), entry.getName(),
stackTraceToSingleLineString(e));
}
@@ -236,8 +232,7 @@
if (logger.isTraceEnabled())
{
logger.trace("Returning -1 because attribute %s does not "
- + "exist in user entry %s", attributeType.getNameOrOID(), entry
- .getName().toString());
+ + "exist in user entry %s", attributeType.getNameOrOID(), entry.getName());
}
}
// FIXME: else to be consistent...
@@ -324,8 +319,8 @@
{
logger.trace("User %s is considered administratively "
+ "disabled because an error occurred while "
- + "attempting to make the determination: %s.", userEntry.getName()
- .toString(), stackTraceToSingleLineString(e));
+ + "attempting to make the determination: %s.", userEntry.getName(),
+ stackTraceToSingleLineString(e));
}
return true;
@@ -337,17 +332,15 @@
if (logger.isTraceEnabled())
{
logger.trace("User %s is not administratively disabled since "
- + "the attribute \"%s\" is not present in the entry.", userEntry
- .getName().toString(), OP_ATTR_ACCOUNT_DISABLED);
+ + "the attribute \"%s\" is not present in the entry.", userEntry.getName(), OP_ATTR_ACCOUNT_DISABLED);
}
return false;
}
if (logger.isTraceEnabled())
{
- logger.trace("User %s %s administratively disabled.", userEntry
- .getName().toString(), ((isDisabled == ConditionResult.TRUE) ? " is"
- : " is not"));
+ logger.trace("User %s is%s administratively disabled.", userEntry.getName(),
+ (isDisabled == ConditionResult.TRUE ? "" : " not"));
}
return isDisabled == ConditionResult.TRUE;
--
Gitblit v1.10.0