From d2bbac5c73611fbf1d2c9a767e1b9ad910996747 Mon Sep 17 00:00:00 2001
From: Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Date: Fri, 31 Jan 2014 08:45:55 +0000
Subject: [PATCH] Removed calls to toString() when calling a logger method. Also removed funny things like this: LocalizableMessage msg = ...; logger.debug(LocalizableMessage.raw(msg.toString()));
---
opendj3-server-dev/src/server/org/opends/server/backends/jeb/RootContainer.java | 15 +++++++--------
1 files changed, 7 insertions(+), 8 deletions(-)
diff --git a/opendj3-server-dev/src/server/org/opends/server/backends/jeb/RootContainer.java b/opendj3-server-dev/src/server/org/opends/server/backends/jeb/RootContainer.java
index 17aa335..eed381d 100644
--- a/opendj3-server-dev/src/server/org/opends/server/backends/jeb/RootContainer.java
+++ b/opendj3-server-dev/src/server/org/opends/server/backends/jeb/RootContainer.java
@@ -193,13 +193,13 @@
{
if(!FilePermission.setPermissions(backendDirectory, backendPermission))
{
- logger.warn(WARN_JEB_UNABLE_SET_PERMISSIONS, backendPermission.toString(), backendDirectory.toString());
+ logger.warn(WARN_JEB_UNABLE_SET_PERMISSIONS, backendPermission, backendDirectory);
}
}
catch(Exception e)
{
// Log an warning that the permissions were not set.
- logger.warn(WARN_JEB_SET_PERMISSIONS_FAILED, backendDirectory.toString(), e.toString());
+ logger.warn(WARN_JEB_SET_PERMISSIONS_FAILED, backendDirectory, e);
}
}
@@ -668,6 +668,7 @@
/**
* {@inheritDoc}
*/
+ @Override
public boolean isConfigurationChangeAcceptable(
LocalDBBackendCfg cfg,
List<LocalizableMessage> unacceptableReasons)
@@ -744,6 +745,7 @@
/**
* {@inheritDoc}
*/
+ @Override
public ConfigChangeResult applyConfigurationChange(LocalDBBackendCfg cfg)
{
ConfigChangeResult ccr;
@@ -822,10 +824,7 @@
// properties that are mutable at runtime.
env.setMutableConfig(newEnvConfig);
- if (logger.isTraceEnabled())
- {
- logger.trace(env.getConfig().toString());
- }
+ logger.trace("JE database configuration: %s", env.getConfig());
}
// Create the directory if it doesn't exist.
@@ -912,13 +911,13 @@
if(!FilePermission.setPermissions(backendDirectory,
backendPermission))
{
- logger.warn(WARN_JEB_UNABLE_SET_PERMISSIONS, backendPermission.toString(), backendDirectory.toString());
+ logger.warn(WARN_JEB_UNABLE_SET_PERMISSIONS, backendPermission, backendDirectory);
}
}
catch(Exception e)
{
// Log an warning that the permissions were not set.
- logger.warn(WARN_JEB_SET_PERMISSIONS_FAILED, backendDirectory.toString(), e.toString());
+ logger.warn(WARN_JEB_SET_PERMISSIONS_FAILED, backendDirectory, e);
}
}
}
--
Gitblit v1.10.0