From 8b1a3529580def922b2188a998fdebb65c756de0 Mon Sep 17 00:00:00 2001
From: Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Date: Tue, 27 Jan 2015 09:27:30 +0000
Subject: [PATCH] OPENDJ-1716 Various PluggableBackend/Storage refactorings Code review: Nicolas Capponi

---
 opendj3-server-dev/src/server/org/opends/server/backends/pluggable/spi/WriteableStorage.java |   85 +++++++++++++++++++++++++++++++++++++++---
 1 files changed, 79 insertions(+), 6 deletions(-)

diff --git a/opendj3-server-dev/src/server/org/opends/server/backends/pluggable/spi/WriteableStorage.java b/opendj3-server-dev/src/server/org/opends/server/backends/pluggable/spi/WriteableStorage.java
index 1af739a..96c00ca 100644
--- a/opendj3-server-dev/src/server/org/opends/server/backends/pluggable/spi/WriteableStorage.java
+++ b/opendj3-server-dev/src/server/org/opends/server/backends/pluggable/spi/WriteableStorage.java
@@ -21,29 +21,102 @@
  * CDDL HEADER END
  *
  *
- *      Copyright 2014 ForgeRock AS
+ *      Copyright 2014-2015 ForgeRock AS
  */
 package org.opends.server.backends.pluggable.spi;
 
 import org.forgerock.opendj.ldap.ByteSequence;
 
+/**
+ * Represents a writeable transaction on a storage engine.
+ */
 public interface WriteableStorage extends ReadableStorage
 {
+  /**
+   * Opens the tree having the provided name. The tree is created if does not already exist.
+   *
+   * @param name
+   *          the tree name
+   */
   void openTree(TreeName name);
 
+  /**
+   * Truncates the tree having the provided name. It removes all the records in the tree. 
+   *
+   * @param name
+   *          the tree name
+   */
   void truncateTree(TreeName name);
 
+  /**
+   * Renames the tree from the old to the new name.
+   *
+   * @param oldName
+   *          the old tree name
+   * @param newName
+   *          the new tree name
+   */
   void renameTree(TreeName oldName, TreeName newName);
 
+  /**
+   * Deletes the tree having the provided name.
+   *
+   * @param name
+   *          the tree name
+   */
   void deleteTree(TreeName name);
 
-  void create(TreeName name, ByteSequence key, ByteSequence value);
+  /**
+   * Creates a new record with the provided key and value, in the tree whose name is provided.
+   * If a previous record is associated to the provided key, then it will be replaced by the new record.
+   *
+   * @param treeName
+   *          the tree name
+   * @param key
+   *          the key of the new record
+   * @param value
+   *          the value of the new record
+   */
+  void create(TreeName treeName, ByteSequence key, ByteSequence value);
 
+  /**
+   * Creates a new record with the provided key and value, in the tree whose name is provided, if
+   * the key was not previously associated to any record.
+   * 
+   * @param treeName
+   *          the tree name
+   * @param key
+   *          the key of the new record
+   * @param value
+   *          the value of the new record
+   * @return {@code true} if the new record could be created, {@code false} otherwise
+   * @deprecated use {@link #update(TreeName, ByteSequence, UpdateFunction)} instead
+   */
+  @Deprecated
   boolean putIfAbsent(TreeName treeName, ByteSequence key, ByteSequence value);
 
-  void update(TreeName treeName, ByteSequence key, UpdateFunction f);
+  /**
+   * Updates a record with the provided key according to the new value computed by the update function.
+   *
+   * @param treeName
+   *          the tree name
+   * @param key
+   *          the key of the new record
+   * @param f
+   *          the update function
+   * @return {@code true} if an update was performed, {@code false} otherwise
+   * @see UpdateFunction#computeNewValue(ByteSequence)
+   */
+  boolean update(TreeName treeName, ByteSequence key, UpdateFunction f);
 
-  boolean remove(TreeName name, ByteSequence key);
-
-  void delete(TreeName name, ByteSequence key);
+  /**
+   * Deletes the record with the provided key, in the tree whose name is provided.
+   *
+   * @param treeName
+   *          the tree name
+   * @param key
+   *          the key of the record to delete
+   * @return {@code true} if the record could be deleted, {@code false} otherwise
+   */
+  boolean delete(TreeName treeName, ByteSequence key);
 }
\ No newline at end of file

--
Gitblit v1.10.0