From 31216400c324b43c15b8a9eea6d89604247ebb14 Mon Sep 17 00:00:00 2001
From: Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Date: Mon, 03 Feb 2014 12:10:05 +0000
Subject: [PATCH] Removed now useless calls to String.valueOf() on arguments of ArgN.get(...).

---
 opendj3-server-dev/src/server/org/opends/server/backends/task/Task.java |   30 ++++++++----------------------
 1 files changed, 8 insertions(+), 22 deletions(-)

diff --git a/opendj3-server-dev/src/server/org/opends/server/backends/task/Task.java b/opendj3-server-dev/src/server/org/opends/server/backends/task/Task.java
index 6ed156e..9bf7a2d 100644
--- a/opendj3-server-dev/src/server/org/opends/server/backends/task/Task.java
+++ b/opendj3-server-dev/src/server/org/opends/server/backends/task/Task.java
@@ -192,9 +192,7 @@
     {
       if (recurringTaskID == null)
       {
-        LocalizableMessage message = ERR_TASK_MISSING_ATTR.get(
-            String.valueOf(taskEntry.getName()), ATTR_TASK_ID);
-        throw new InitializationException(message);
+        throw new InitializationException(ERR_TASK_MISSING_ATTR.get(taskEntry.getName(), ATTR_TASK_ID));
       }
       else
       {
@@ -375,9 +373,7 @@
     {
       if (isRequired)
       {
-        LocalizableMessage message = ERR_TASK_MISSING_ATTR.get(
-            String.valueOf(taskEntry.getName()), attributeName);
-        throw new InitializationException(message);
+        throw new InitializationException(ERR_TASK_MISSING_ATTR.get(taskEntry.getName(), attributeName));
       }
       else
       {
@@ -387,9 +383,7 @@
 
     if (attrList.size() > 1)
     {
-      LocalizableMessage message = ERR_TASK_MULTIPLE_ATTRS_FOR_TYPE.get(
-          attributeName, String.valueOf(taskEntry.getName()));
-      throw new InitializationException(message);
+      throw new InitializationException(ERR_TASK_MULTIPLE_ATTRS_FOR_TYPE.get(attributeName, taskEntry.getName()));
     }
 
     Iterator<AttributeValue> iterator = attrList.get(0).iterator();
@@ -397,9 +391,7 @@
     {
       if (isRequired)
       {
-        LocalizableMessage message = ERR_TASK_NO_VALUES_FOR_ATTR.get(
-            attributeName, String.valueOf(taskEntry.getName()));
-        throw new InitializationException(message);
+        throw new InitializationException(ERR_TASK_NO_VALUES_FOR_ATTR.get(attributeName, taskEntry.getName()));
       }
       else
       {
@@ -410,9 +402,7 @@
     AttributeValue value = iterator.next();
     if (iterator.hasNext())
     {
-      LocalizableMessage message = ERR_TASK_MULTIPLE_VALUES_FOR_ATTR.get(
-          attributeName, String.valueOf(taskEntry.getName()));
-      throw new InitializationException(message);
+      throw new InitializationException(ERR_TASK_MULTIPLE_VALUES_FOR_ATTR.get(attributeName, taskEntry.getName()));
     }
 
     return value.getValue().toString();
@@ -447,9 +437,7 @@
 
     if (attrList.size() > 1)
     {
-      LocalizableMessage message = ERR_TASK_MULTIPLE_ATTRS_FOR_TYPE.get(
-          attributeName, String.valueOf(taskEntry.getName()));
-      throw new InitializationException(message);
+      throw new InitializationException(ERR_TASK_MULTIPLE_ATTRS_FOR_TYPE.get(attributeName, taskEntry.getName()));
     }
 
     Iterator<AttributeValue> iterator = attrList.get(0).iterator();
@@ -1231,10 +1219,8 @@
         String actualStartDate = new Date(actualStartTime).toString();
         String completionDate  = new Date(completionTime).toString();
 
-        message.setBody(INFO_TASK_COMPLETION_BODY.get(taskID,
-                                   String.valueOf(taskState),
-                                   scheduledStartDate, actualStartDate,
-                                   completionDate));
+        message.setBody(INFO_TASK_COMPLETION_BODY.get(
+            taskID, taskState, scheduledStartDate, actualStartDate, completionDate));
 
         for (String logMessage : logMessages)
         {

--
Gitblit v1.10.0