From 31216400c324b43c15b8a9eea6d89604247ebb14 Mon Sep 17 00:00:00 2001
From: Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Date: Mon, 03 Feb 2014 12:10:05 +0000
Subject: [PATCH] Removed now useless calls to String.valueOf() on arguments of ArgN.get(...).

---
 opendj3-server-dev/src/server/org/opends/server/config/DNConfigAttribute.java |   26 ++++++++------------------
 1 files changed, 8 insertions(+), 18 deletions(-)

diff --git a/opendj3-server-dev/src/server/org/opends/server/config/DNConfigAttribute.java b/opendj3-server-dev/src/server/org/opends/server/config/DNConfigAttribute.java
index 971ab05..2e97d12 100644
--- a/opendj3-server-dev/src/server/org/opends/server/config/DNConfigAttribute.java
+++ b/opendj3-server-dev/src/server/org/opends/server/config/DNConfigAttribute.java
@@ -445,8 +445,7 @@
       if (valueSet.contains(attrValue))
       {
         LocalizableMessage message =
-            ERR_CONFIG_ATTR_ADD_VALUES_ALREADY_EXISTS.get(
-                    getName(), String.valueOf(value));
+            ERR_CONFIG_ATTR_ADD_VALUES_ALREADY_EXISTS.get(getName(), value);
         throw new ConfigException(message);
       }
 
@@ -660,10 +659,7 @@
       {
         logger.traceException(e);
 
-        LocalizableMessage message = ERR_CONFIG_ATTR_DN_CANNOT_PARSE.get(
-                valueString, getName(),
-                String.valueOf(e));
-
+        LocalizableMessage message = ERR_CONFIG_ATTR_DN_CANNOT_PARSE.get(valueString, getName(), e);
         if (allowFailures)
         {
           logger.error(message);
@@ -1186,8 +1182,7 @@
       {
         logger.traceException(e);
 
-        LocalizableMessage message = ERR_CONFIG_ATTR_DN_CANNOT_PARSE.get(
-            (String) value, getName(), String.valueOf(e));
+        LocalizableMessage message = ERR_CONFIG_ATTR_DN_CANNOT_PARSE.get(value, getName(), e);
         throw new ConfigException(message, e);
       }
 
@@ -1198,7 +1193,6 @@
       String componentType = value.getClass().getComponentType().getName();
       int length = Array.getLength(value);
 
-
       if (componentType.equals(DN.class.getName()))
       {
         ArrayList<DN> dnList = new ArrayList<DN>(length);
@@ -1227,8 +1221,7 @@
             {
               logger.traceException(e);
 
-              LocalizableMessage message = ERR_CONFIG_ATTR_DN_CANNOT_PARSE.get(
-                  valueStr, getName(), String.valueOf(e));
+              LocalizableMessage message = ERR_CONFIG_ATTR_DN_CANNOT_PARSE.get(valueStr, getName(), e);
               throw new ConfigException(message, e);
             }
 
@@ -1248,24 +1241,21 @@
           logger.traceException(e);
 
           LocalizableMessage message = ERR_CONFIG_ATTR_INVALID_DN_VALUE.get(
-              getName(), String.valueOf(value), String.valueOf(e));
+              getName(), value, e);
           throw new ConfigException(message, e);
         }
       }
       else
       {
         LocalizableMessage message =
-            ERR_CONFIG_ATTR_DN_INVALID_ARRAY_TYPE.get(
-                    String.valueOf(jmxAttribute),
-                    String.valueOf(componentType));
+            ERR_CONFIG_ATTR_DN_INVALID_ARRAY_TYPE.get(jmxAttribute, componentType);
         throw new ConfigException(message);
       }
     }
     else
     {
-      LocalizableMessage message = ERR_CONFIG_ATTR_DN_INVALID_TYPE.get(
-          String.valueOf(value), getName(), value.getClass().getName());
-      throw new ConfigException(message);
+      throw new ConfigException(ERR_CONFIG_ATTR_DN_INVALID_TYPE.get(
+          value, getName(), value.getClass().getName()));
     }
   }
 

--
Gitblit v1.10.0