From 10bac0ad21fca0c5ac8bf6d7dc712c5899c2d0e6 Mon Sep 17 00:00:00 2001
From: Nicolas Capponi <nicolas.capponi@forgerock.com>
Date: Thu, 06 Feb 2014 13:51:13 +0000
Subject: [PATCH] Fix OPENDJ-1289 Runtime debug configuration changes have no effect
---
opendj3-server-dev/src/server/org/opends/server/loggers/AbstractLogger.java | 41 +++++++++++++++++++++++++++++++----------
1 files changed, 31 insertions(+), 10 deletions(-)
diff --git a/opendj3-server-dev/src/server/org/opends/server/loggers/AbstractLogger.java b/opendj3-server-dev/src/server/org/opends/server/loggers/AbstractLogger.java
index 44d90b3..3a209d1 100644
--- a/opendj3-server-dev/src/server/org/opends/server/loggers/AbstractLogger.java
+++ b/opendj3-server-dev/src/server/org/opends/server/loggers/AbstractLogger.java
@@ -147,11 +147,33 @@
}
/**
- * Returns the logger storage for the current logger.
+ * Returns the log publishers.
*
- * @return the logger storage for the current logger
+ * @return the collection of {@link LogPublisher}s
*/
- protected abstract LoggerStorage<P, C> getStorage();
+ protected abstract Collection<P> getLogPublishers();
+
+ /**
+ * Add a log publisher to the logger.
+ *
+ * @param publisher
+ * The log publisher to add.
+ */
+ public abstract void addLogPublisher(P publisher);
+
+ /**
+ * Remove a log publisher from the logger.
+ *
+ * @param publisher
+ * The log publisher to remove.
+ * @return True if the log publisher is removed or false otherwise.
+ */
+ public abstract boolean removeLogPublisher(P publisher);
+
+ /**
+ * Removes all existing log publishers from the logger.
+ */
+ public abstract void removeAllLogPublishers();
/**
* Returns the java {@link ClassPropertyDefinition} for the current logger.
@@ -175,7 +197,7 @@
* @param invalidLoggerClassErrorMessage
* the error message to use if the logger class in invalid
*/
- public AbstractLogger(
+ AbstractLogger(
final Class<P> logPublisherClass,
final Arg3<Object, Object, Object>
invalidLoggerClassErrorMessage)
@@ -208,7 +230,7 @@
if(config.isEnabled())
{
- getStorage().addLogPublisher(getLogPublisher(config));
+ addLogPublisher(getLogPublisher(config));
}
}
}
@@ -252,7 +274,7 @@
{
try
{
- getStorage().addLogPublisher(getLogPublisher(config));
+ addLogPublisher(getLogPublisher(config));
}
catch(ConfigException e)
{
@@ -273,8 +295,7 @@
private P findLogPublisher(DN dn)
{
- Collection<P> logPublishers = getStorage().getLogPublishers();
- for (P publisher : logPublishers)
+ for (P publisher : getLogPublishers())
{
if (publisher.getDN().equals(dn))
{
@@ -322,7 +343,7 @@
else
{
// The publisher is being disabled so shut down and remove.
- getStorage().removeLogPublisher(logPublisher);
+ removeLogPublisher(logPublisher);
}
}
@@ -352,7 +373,7 @@
P logPublisher = findLogPublisher(config.dn());
if(logPublisher != null)
{
- getStorage().removeLogPublisher(logPublisher);
+ removeLogPublisher(logPublisher);
}
else
{
--
Gitblit v1.10.0