From 34b97b2d33a1196d3b22bd0ade1e758be613f7f3 Mon Sep 17 00:00:00 2001
From: Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Date: Fri, 06 Jun 2014 14:37:42 +0000
Subject: [PATCH] Ensured no accidental protocol break can happen by renaming all ByteArrayBuilder.append*() methods and getting rid of all method overloading.
---
opendj3-server-dev/src/server/org/opends/server/replication/protocol/ByteArrayScanner.java | 9 ++++++---
1 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/opendj3-server-dev/src/server/org/opends/server/replication/protocol/ByteArrayScanner.java b/opendj3-server-dev/src/server/org/opends/server/replication/protocol/ByteArrayScanner.java
index 6c23d22..94d889b 100644
--- a/opendj3-server-dev/src/server/org/opends/server/replication/protocol/ByteArrayScanner.java
+++ b/opendj3-server-dev/src/server/org/opends/server/replication/protocol/ByteArrayScanner.java
@@ -349,15 +349,18 @@
* Reads the next ServerState.
* <p>
* Caution: ServerState MUST be the last field (see
- * {@link ByteArrayBuilder#append(ServerState)} javadoc).
+ * {@link ByteArrayBuilder#appendServerStateMustComeLast(ServerState)} javadoc).
+ * <p>
+ * Note: the super long method name it is intentional:
+ * nobody will want to use it, which is good because nobody should.
*
* @return the next ServerState.
* @throws DataFormatException
* if ServerState was incorrectly encoded or no more data can be
* read from the input
- * @see ByteArrayBuilder#append(ServerState)
+ * @see ByteArrayBuilder#appendServerStateMustComeLast(ServerState)
*/
- public ServerState nextServerState() throws DataFormatException
+ public ServerState nextServerStateMustComeLast() throws DataFormatException
{
final ServerState result = new ServerState();
--
Gitblit v1.10.0