From 34b97b2d33a1196d3b22bd0ade1e758be613f7f3 Mon Sep 17 00:00:00 2001
From: Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Date: Fri, 06 Jun 2014 14:37:42 +0000
Subject: [PATCH] Ensured no accidental protocol break can happen by renaming all ByteArrayBuilder.append*() methods and getting rid of all method overloading.

---
 opendj3-server-dev/src/server/org/opends/server/replication/protocol/LDAPUpdateMsg.java |   26 +++++++++++++-------------
 1 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/opendj3-server-dev/src/server/org/opends/server/replication/protocol/LDAPUpdateMsg.java b/opendj3-server-dev/src/server/org/opends/server/replication/protocol/LDAPUpdateMsg.java
index 26efa40..6e5289a 100644
--- a/opendj3-server-dev/src/server/org/opends/server/replication/protocol/LDAPUpdateMsg.java
+++ b/opendj3-server-dev/src/server/org/opends/server/replication/protocol/LDAPUpdateMsg.java
@@ -220,14 +220,14 @@
      * <assured mode> <safe data level>
      */
     final ByteArrayBuilder builder = new ByteArrayBuilder();
-    builder.append(msgType);
-    builder.append((byte) protocolVersion);
-    builder.appendUTF8(csn);
-    builder.append(dn);
-    builder.append(entryUUID);
-    builder.append(assuredFlag);
-    builder.append(assuredMode.getValue());
-    builder.append(safeDataLevel);
+    builder.appendByte(msgType);
+    builder.appendByte((byte) protocolVersion);
+    builder.appendCSNUTF8(csn);
+    builder.appendDN(dn);
+    builder.appendString(entryUUID);
+    builder.appendBoolean(assuredFlag);
+    builder.appendByte(assuredMode.getValue());
+    builder.appendByte(safeDataLevel);
     return builder;
   }
 
@@ -244,11 +244,11 @@
      * <operation type><CSN><dn><assured><entryuuid><change>
      */
     final ByteArrayBuilder builder = new ByteArrayBuilder();
-    builder.append(msgType);
-    builder.appendUTF8(csn);
-    builder.append(assuredFlag);
-    builder.append(dn);
-    builder.append(entryUUID);
+    builder.appendByte(msgType);
+    builder.appendCSNUTF8(csn);
+    builder.appendBoolean(assuredFlag);
+    builder.appendDN(dn);
+    builder.appendString(entryUUID);
     return builder;
   }
 

--
Gitblit v1.10.0