From 34b97b2d33a1196d3b22bd0ade1e758be613f7f3 Mon Sep 17 00:00:00 2001
From: Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Date: Fri, 06 Jun 2014 14:37:42 +0000
Subject: [PATCH] Ensured no accidental protocol break can happen by renaming all ByteArrayBuilder.append*() methods and getting rid of all method overloading.

---
 opendj3-server-dev/src/server/org/opends/server/replication/protocol/ModifyMsg.java |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/opendj3-server-dev/src/server/org/opends/server/replication/protocol/ModifyMsg.java b/opendj3-server-dev/src/server/org/opends/server/replication/protocol/ModifyMsg.java
index 19431d3..0d1f2d4 100644
--- a/opendj3-server-dev/src/server/org/opends/server/replication/protocol/ModifyMsg.java
+++ b/opendj3-server-dev/src/server/org/opends/server/replication/protocol/ModifyMsg.java
@@ -177,7 +177,7 @@
   public byte[] getBytes_V1()
   {
     final ByteArrayBuilder builder = encodeHeader_V1(MSG_TYPE_MODIFY_V1);
-    builder.append(encodedMods);
+    builder.appendByteArray(encodedMods);
     return builder.toByteArray();
   }
 
@@ -187,7 +187,7 @@
   {
     final ByteArrayBuilder builder =
         encodeHeader(MSG_TYPE_MODIFY, ProtocolVersion.REPLICATION_PROTOCOL_V3);
-    builder.append(encodedMods);
+    builder.appendByteArray(encodedMods);
     return builder.toByteArray();
   }
 
@@ -197,10 +197,10 @@
   {
     final ByteArrayBuilder builder =
         encodeHeader(MSG_TYPE_MODIFY, protocolVersion);
-    builder.appendUTF8(encodedMods.length);
-    builder.append(encodedMods);
-    builder.appendUTF8(encodedEclIncludes.length);
-    builder.append(encodedEclIncludes);
+    builder.appendIntUTF8(encodedMods.length);
+    builder.appendByteArray(encodedMods);
+    builder.appendIntUTF8(encodedEclIncludes.length);
+    builder.appendByteArray(encodedEclIncludes);
     return builder.toByteArray();
   }
 

--
Gitblit v1.10.0