From a1f030edc5d19b575470f0d79033d9f7471ab172 Mon Sep 17 00:00:00 2001
From: Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Date: Fri, 31 Jan 2014 14:49:58 +0000
Subject: [PATCH] Removed now useless calls to .toString() on arguments of ArgN.get(...).

---
 opendj3-server-dev/src/server/org/opends/server/replication/server/ServerReader.java |   20 ++++++--------------
 1 files changed, 6 insertions(+), 14 deletions(-)

diff --git a/opendj3-server-dev/src/server/org/opends/server/replication/server/ServerReader.java b/opendj3-server-dev/src/server/org/opends/server/replication/server/ServerReader.java
index 042187b..9206a1b 100644
--- a/opendj3-server-dev/src/server/org/opends/server/replication/server/ServerReader.java
+++ b/opendj3-server-dev/src/server/org/opends/server/replication/server/ServerReader.java
@@ -130,15 +130,13 @@
                 long referenceGenerationId = handler.getReferenceGenId();
                 if (dsStatus == BAD_GEN_ID_STATUS)
                   logger.warn(WARN_IGNORING_UPDATE_FROM_DS_BADGENID.get(handler.getReplicationServerId(),
-                      updateMsg.getCSN().toString(),
-                      handler.getBaseDNString(), handler.getServerId(),
+                      updateMsg.getCSN(), handler.getBaseDN(), handler.getServerId(),
                       session.getReadableRemoteAddress(),
                       handler.getGenerationId(),
                       referenceGenerationId));
                 if (dsStatus == FULL_UPDATE_STATUS)
                   logger.warn(WARN_IGNORING_UPDATE_FROM_DS_FULLUP.get(handler.getReplicationServerId(),
-                      updateMsg.getCSN().toString(),
-                      handler.getBaseDNString(), handler.getServerId(),
+                      updateMsg.getCSN(), handler.getBaseDN(), handler.getServerId(),
                       session.getReadableRemoteAddress()));
                 filtered = true;
               }
@@ -155,9 +153,7 @@
                 logger.error(
                     WARN_IGNORING_UPDATE_FROM_RS.get(
                         handler.getReplicationServerId(),
-                        updateMsg.getCSN().toString(),
-                        handler.getBaseDNString(),
-                        handler.getServerId(),
+                        updateMsg.getCSN(), handler.getBaseDN(), handler.getServerId(),
                         session.getReadableRemoteAddress(),
                         handler.getGenerationId(),
                         referenceGenerationId));
@@ -195,11 +191,8 @@
             }
             catch(Exception e)
             {
-              errMessage =
-                ERR_RECEIVED_CHANGE_STATUS_NOT_FROM_DS.get(
-                    handler.getBaseDNString(),
-                    Integer.toString(handler.getServerId()),
-                    csMsg.toString());
+              errMessage = ERR_RECEIVED_CHANGE_STATUS_NOT_FROM_DS.get(
+                  handler.getBaseDN(), handler.getServerId(), csMsg);
               logger.error(errMessage);
             }
           } else if (msg instanceof ChangeTimeHeartbeatMsg)
@@ -255,8 +248,7 @@
        * The remote server has sent an unknown message,
        * close the connection.
        */
-      errMessage = NOTE_READER_EXCEPTION.get(
-          handler.toString(), stackTraceToSingleLineString(e));
+      errMessage = NOTE_READER_EXCEPTION.get(handler, stackTraceToSingleLineString(e));
       logger.error(errMessage);
     }
     finally

--
Gitblit v1.10.0