From 31216400c324b43c15b8a9eea6d89604247ebb14 Mon Sep 17 00:00:00 2001
From: Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Date: Mon, 03 Feb 2014 12:10:05 +0000
Subject: [PATCH] Removed now useless calls to String.valueOf() on arguments of ArgN.get(...).

---
 opendj3-server-dev/src/server/org/opends/server/schema/UTCTimeSyntax.java |   37 +++++++++++++------------------------
 1 files changed, 13 insertions(+), 24 deletions(-)

diff --git a/opendj3-server-dev/src/server/org/opends/server/schema/UTCTimeSyntax.java b/opendj3-server-dev/src/server/org/opends/server/schema/UTCTimeSyntax.java
index f232d9b..6dd14b2 100644
--- a/opendj3-server-dev/src/server/org/opends/server/schema/UTCTimeSyntax.java
+++ b/opendj3-server-dev/src/server/org/opends/server/schema/UTCTimeSyntax.java
@@ -310,8 +310,7 @@
           // These are all fine.
           break;
         default:
-          LocalizableMessage message = ERR_ATTR_SYNTAX_UTC_TIME_INVALID_YEAR.get(
-                  valueString, String.valueOf(valueString.charAt(i)));
+          LocalizableMessage message = ERR_ATTR_SYNTAX_UTC_TIME_INVALID_YEAR.get(valueString, valueString.charAt(i));
           invalidReason.append(message);
           return false;
       }
@@ -519,8 +518,7 @@
         // be a digit between 0 and 9.
         if (length < 11)
         {
-          LocalizableMessage message = ERR_ATTR_SYNTAX_UTC_TIME_INVALID_CHAR.get(
-                  valueString, String.valueOf(m1), 8);
+          LocalizableMessage message = ERR_ATTR_SYNTAX_UTC_TIME_INVALID_CHAR.get(valueString, m1, 8);
           invalidReason.append(message);
           return false;
         }
@@ -549,8 +547,7 @@
         break;
 
       default:
-        LocalizableMessage message = ERR_ATTR_SYNTAX_UTC_TIME_INVALID_CHAR.get(
-                valueString, String.valueOf(m1), 8);
+        LocalizableMessage message = ERR_ATTR_SYNTAX_UTC_TIME_INVALID_CHAR.get(valueString, m1, 8);
         invalidReason.append(message);
         return false;
     }
@@ -573,8 +570,7 @@
         // be a digit between 0 and 9.
         if (length < 13)
         {
-          LocalizableMessage message = ERR_ATTR_SYNTAX_UTC_TIME_INVALID_CHAR.get(
-                  valueString, String.valueOf(s1), 10);
+          LocalizableMessage message = ERR_ATTR_SYNTAX_UTC_TIME_INVALID_CHAR.get(valueString, s1, 10);
           invalidReason.append(message);
           return false;
         }
@@ -606,9 +602,7 @@
         // a 0.
         if (length < 13)
         {
-
-          LocalizableMessage message = ERR_ATTR_SYNTAX_UTC_TIME_INVALID_CHAR.get(
-                  valueString, String.valueOf(s1), 10);
+          LocalizableMessage message = ERR_ATTR_SYNTAX_UTC_TIME_INVALID_CHAR.get(valueString, s1, 10);
           invalidReason.append(message);
           return false;
         }
@@ -630,8 +624,7 @@
         }
         else
         {
-          LocalizableMessage message = ERR_ATTR_SYNTAX_UTC_TIME_INVALID_CHAR.get(
-                  valueString, String.valueOf(s1), 10);
+          LocalizableMessage message = ERR_ATTR_SYNTAX_UTC_TIME_INVALID_CHAR.get(valueString, s1, 10);
           invalidReason.append(message);
           return false;
         }
@@ -646,15 +639,13 @@
         }
         else
         {
-          LocalizableMessage message = ERR_ATTR_SYNTAX_UTC_TIME_INVALID_CHAR.get(
-                  valueString, String.valueOf(s1), 10);
+          LocalizableMessage message = ERR_ATTR_SYNTAX_UTC_TIME_INVALID_CHAR.get(valueString, s1, 10);
           invalidReason.append(message);
           return false;
         }
 
       default:
-        LocalizableMessage message = ERR_ATTR_SYNTAX_UTC_TIME_INVALID_CHAR.get(
-                valueString, String.valueOf(s1), 10);
+        LocalizableMessage message = ERR_ATTR_SYNTAX_UTC_TIME_INVALID_CHAR.get(valueString, s1, 10);
         invalidReason.append(message);
         return false;
     }
@@ -673,7 +664,7 @@
         else
         {
           LocalizableMessage message = ERR_ATTR_SYNTAX_UTC_TIME_INVALID_CHAR.get(
-                  valueString, String.valueOf(valueString.charAt(12)), 12);
+                  valueString, valueString.charAt(12), 12);
           invalidReason.append(message);
           return false;
         }
@@ -689,14 +680,14 @@
         else
         {
           LocalizableMessage message = ERR_ATTR_SYNTAX_UTC_TIME_INVALID_CHAR.get(
-                  valueString, String.valueOf(valueString.charAt(12)), 12);
+                  valueString, valueString.charAt(12), 12);
           invalidReason.append(message);
           return false;
         }
 
       default:
         LocalizableMessage message = ERR_ATTR_SYNTAX_UTC_TIME_INVALID_CHAR.get(
-                valueString, String.valueOf(valueString.charAt(12)), 12);
+                valueString, valueString.charAt(12), 12);
         invalidReason.append(message);
         return false;
     }
@@ -906,10 +897,8 @@
     {
       logger.traceException(e);
 
-      LocalizableMessage message = ERR_ATTR_SYNTAX_UTC_TIME_CANNOT_PARSE.get(
-          valueString, String.valueOf(e));
-      throw new DirectoryException(ResultCode.INVALID_ATTRIBUTE_SYNTAX,
-                                   message, e);
+      LocalizableMessage message = ERR_ATTR_SYNTAX_UTC_TIME_CANNOT_PARSE.get(valueString, e);
+      throw new DirectoryException(ResultCode.INVALID_ATTRIBUTE_SYNTAX, message, e);
     }
   }
 

--
Gitblit v1.10.0