From 8271ebead97bf11132eb1146c836212ae456e27c Mon Sep 17 00:00:00 2001
From: Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Date: Tue, 25 Feb 2014 13:48:08 +0000
Subject: [PATCH] Removed unnecessary use of reflection for invoking methods, aprticularly with all ConfigManagers. However, I could not do it for WorkflowElementConfigManager.
---
opendj3-server-dev/src/server/org/opends/server/tools/tasks/TaskEntry.java | 20 ++++++--------------
1 files changed, 6 insertions(+), 14 deletions(-)
diff --git a/opendj3-server-dev/src/server/org/opends/server/tools/tasks/TaskEntry.java b/opendj3-server-dev/src/server/org/opends/server/tools/tasks/TaskEntry.java
index 8e91897..a449bcb 100644
--- a/opendj3-server-dev/src/server/org/opends/server/tools/tasks/TaskEntry.java
+++ b/opendj3-server-dev/src/server/org/opends/server/tools/tasks/TaskEntry.java
@@ -24,20 +24,17 @@
* Copyright 2008-2009 Sun Microsystems, Inc.
* Portions Copyright 2014 ForgeRock AS
*/
-
package org.opends.server.tools.tasks;
import org.forgerock.i18n.LocalizableMessage;
-
+import org.opends.server.backends.task.FailedDependencyAction;
import org.opends.server.backends.task.Task;
import org.opends.server.backends.task.TaskState;
-import org.opends.server.backends.task.FailedDependencyAction;
import org.opends.server.types.Entry;
import org.opends.server.types.AttributeType;
import org.opends.server.types.Attribute;
import org.opends.server.types.AttributeValue;
import org.opends.server.types.DN;
-import static org.opends.server.util.ServerConstants.*;
import java.util.Map;
import java.util.HashMap;
@@ -53,6 +50,8 @@
import java.text.DateFormat;
import java.text.ParseException;
+import static org.opends.server.util.ServerConstants.*;
+
/**
* Processes information from a task entry from the directory and
* provides accessors for attribute information. In some cases the
@@ -369,16 +368,9 @@
if (type == null) {
Task task = getTask();
if (task != null) {
- try {
- Method m = Task.class.getMethod("getDisplayName");
- Object oName = m.invoke(task);
- if (oName instanceof LocalizableMessage) {
- mapClassToTypeName.put(className, (LocalizableMessage) oName);
- type = (LocalizableMessage) oName;
- }
- } catch (Exception e) {
- // ignore; this is best effort
- }
+ LocalizableMessage message = task.getDisplayName();
+ mapClassToTypeName.put(className, message);
+ type = message;
}
}
--
Gitblit v1.10.0