From d2bbac5c73611fbf1d2c9a767e1b9ad910996747 Mon Sep 17 00:00:00 2001
From: Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Date: Fri, 31 Jan 2014 08:45:55 +0000
Subject: [PATCH] Removed calls to toString() when calling a logger method. Also removed funny things like this: LocalizableMessage msg = ...; logger.debug(LocalizableMessage.raw(msg.toString()));
---
opendj3-server-dev/src/server/org/opends/server/tools/upgrade/FileManager.java | 16 ++++++----------
1 files changed, 6 insertions(+), 10 deletions(-)
diff --git a/opendj3-server-dev/src/server/org/opends/server/tools/upgrade/FileManager.java b/opendj3-server-dev/src/server/org/opends/server/tools/upgrade/FileManager.java
index ef1a702..9f20051 100644
--- a/opendj3-server-dev/src/server/org/opends/server/tools/upgrade/FileManager.java
+++ b/opendj3-server-dev/src/server/org/opends/server/tools/upgrade/FileManager.java
@@ -186,8 +186,7 @@
}
else
{
- logger.debug(LocalizableMessage.raw(new StringBuilder("File '").append(file.toString())
- .append("' does not exist").toString()));
+ logger.debug(LocalizableMessage.raw("File '" + file + "' does not exist"));
}
}
@@ -370,9 +369,8 @@
{
if (insureParentsExist(destination))
{
- final LocalizableMessage message = LocalizableMessage.raw("Copying file '%s' to '%s'",
- objectFile.getAbsolutePath(), destination.getAbsolutePath());
- logger.debug(LocalizableMessage.raw(message.toString()));
+ logger.debug(LocalizableMessage.raw("Copying file '%s' to '%s'",
+ objectFile.getAbsolutePath(), destination.getAbsolutePath()));
FileInputStream fis = null;
FileOutputStream fos = null;
try
@@ -416,17 +414,15 @@
{
final LocalizableMessage errMsg = INFO_ERROR_COPYING_FILE.get(
objectFile.getAbsolutePath(), destination.getAbsolutePath());
- logger.error(LocalizableMessage.raw(errMsg.toString()));
+ logger.error(LocalizableMessage.raw(errMsg));
throw new IOException(errMsg.toString());
}
}
else
{
- final LocalizableMessage message = LocalizableMessage.raw(
+ logger.debug(LocalizableMessage.raw(
"Ignoring file '%s' since '%s' already exists",
- objectFile.getAbsolutePath(), destination.getAbsolutePath());
-
- logger.debug(LocalizableMessage.raw(message.toString()));
+ objectFile.getAbsolutePath(), destination.getAbsolutePath()));
}
}
}
--
Gitblit v1.10.0