From 7aaa55796a7e94d6773535e4bddbedda5cc9ec05 Mon Sep 17 00:00:00 2001
From: Ludovic Poitou <ludovic.poitou@forgerock.com>
Date: Thu, 20 Jan 2011 16:02:14 +0000
Subject: [PATCH] Code cleanup removing potential issues detected by FindBugs

---
 opends/src/guitools/org/opends/guitools/controlpanel/ui/LoginPanel.java |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/opends/src/guitools/org/opends/guitools/controlpanel/ui/LoginPanel.java b/opends/src/guitools/org/opends/guitools/controlpanel/ui/LoginPanel.java
index 468f43c..75341f3 100644
--- a/opends/src/guitools/org/opends/guitools/controlpanel/ui/LoginPanel.java
+++ b/opends/src/guitools/org/opends/guitools/controlpanel/ui/LoginPanel.java
@@ -23,6 +23,7 @@
  *
  *
  *      Copyright 2008-2009 Sun Microsystems, Inc.
+ *      Portions Copyright 2011 ForgeRock AS
  */
 
 package org.opends.guitools.controlpanel.ui;
@@ -152,6 +153,7 @@
   /**
    * {@inheritDoc}
    */
+  @Override
   public void toBeDisplayed(boolean visible)
   {
     super.toBeDisplayed(visible);
@@ -184,7 +186,7 @@
       errors.add(INFO_NOT_A_DIRECTORY_MANAGER_DN.get());
     }
 
-    if ("".equals(pwd.getPassword().length == 0))
+    if (pwd.getPassword().length == 0)
     {
       pwdInvalid = true;
       errors.add(INFO_EMPTY_PWD.get());
@@ -412,6 +414,7 @@
   /**
    * {@inheritDoc}
    */
+  @Override
   public void cancelClicked()
   {
     setPrimaryValid(dnLabel);

--
Gitblit v1.10.0