From 7aaa55796a7e94d6773535e4bddbedda5cc9ec05 Mon Sep 17 00:00:00 2001
From: Ludovic Poitou <ludovic.poitou@forgerock.com>
Date: Thu, 20 Jan 2011 16:02:14 +0000
Subject: [PATCH] Code cleanup removing potential issues detected by FindBugs
---
opends/src/guitools/org/opends/guitools/controlpanel/ui/VLVIndexPanel.java | 10 +++++++---
1 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/opends/src/guitools/org/opends/guitools/controlpanel/ui/VLVIndexPanel.java b/opends/src/guitools/org/opends/guitools/controlpanel/ui/VLVIndexPanel.java
index 8a7069e..8cb2ea0 100644
--- a/opends/src/guitools/org/opends/guitools/controlpanel/ui/VLVIndexPanel.java
+++ b/opends/src/guitools/org/opends/guitools/controlpanel/ui/VLVIndexPanel.java
@@ -23,6 +23,7 @@
*
*
* Copyright 2008-2009 Sun Microsystems, Inc.
+ * Portions Copyright 2011 ForgeRock AS
*/
package org.opends.guitools.controlpanel.ui;
@@ -231,6 +232,7 @@
/**
* {@inheritDoc}
*/
+ @Override
public GenericDialog.ButtonType getButtonType()
{
return GenericDialog.ButtonType.NO_BUTTON;
@@ -811,7 +813,8 @@
getObfuscatedCommandLineArguments(getDSConfigCommandLineArguments());
for (String arg : args)
{
- sb.append(" "+CommandBuilder.escapeValue(arg));
+ sb.append(" ");
+ sb.append(CommandBuilder.escapeValue(arg));
}
ManagementContext mCtx = LDAPManagementContext.createFromContext(
@@ -833,7 +836,7 @@
{
index.setScope(scope);
}
- if (!indexToModify.getScope().equals(sortOrder))
+ if (!indexToModify.getSortOrder().equals(sortOrder))
{
index.setSortOrder(sortOrderStringValue);
}
@@ -895,6 +898,7 @@
/**
* {@inheritDoc}
*/
+ @Override
public void postOperation()
{
if ((lastException == null) && (state == State.FINISHED_SUCCESSFULLY))
@@ -938,7 +942,7 @@
args.add("filter:"+filterValue);
}
- if (!indexToModify.getScope().equals(sortOrder))
+ if (!indexToModify.getSortOrder().equals(sortOrder))
{
args.add("--set");
args.add("sort-order:"+sortOrderStringValue);
--
Gitblit v1.10.0