From 08884d2d80fa2ca281a71a6f4249da0a7fa280dc Mon Sep 17 00:00:00 2001
From: Ludovic Poitou <ludovic.poitou@forgerock.com>
Date: Fri, 23 Dec 2011 09:42:53 +0000
Subject: [PATCH] Fix minor optimization proposed by FindBugs.
---
opends/src/guitools/org/opends/guitools/uninstaller/ui/ConfirmUninstallPanel.java | 11 ++++++++---
1 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/opends/src/guitools/org/opends/guitools/uninstaller/ui/ConfirmUninstallPanel.java b/opends/src/guitools/org/opends/guitools/uninstaller/ui/ConfirmUninstallPanel.java
index 2506e5a..bafe015 100644
--- a/opends/src/guitools/org/opends/guitools/uninstaller/ui/ConfirmUninstallPanel.java
+++ b/opends/src/guitools/org/opends/guitools/uninstaller/ui/ConfirmUninstallPanel.java
@@ -23,6 +23,7 @@
*
*
* Copyright 2006-2010 Sun Microsystems, Inc.
+ * Portions Copyright 2011 ForgeRock AS
*/
package org.opends.guitools.uninstaller.ui;
@@ -83,9 +84,10 @@
/**
* {@inheritDoc}
*/
+ @Override
public Object getFieldValue(FieldName fieldName)
{
- Object value = null;
+ Object value;
switch (fieldName)
{
case EXTERNAL_DB_DIRECTORIES:
@@ -113,8 +115,8 @@
break;
default:
JCheckBox cb = getCheckBox(fieldName);
- value = new Boolean(cb.isSelected());
- break;
+ value = cb.isSelected();
+ break;
}
return value;
}
@@ -122,6 +124,7 @@
/**
* {@inheritDoc}
*/
+ @Override
protected Message getTitle()
{
return INFO_CONFIRM_UNINSTALL_PANEL_TITLE.get();
@@ -130,6 +133,7 @@
/**
* {@inheritDoc}
*/
+ @Override
protected Component createInputPanel()
{
FieldName[] fieldNames = {
@@ -254,6 +258,7 @@
/**
* {@inheritDoc}
*/
+ @Override
protected Message getInstructions()
{
return INFO_CONFIRM_UNINSTALL_PANEL_INSTRUCTIONS.get();
--
Gitblit v1.10.0