From de19fe2956d5a4b3817834191c51989664f8c47c Mon Sep 17 00:00:00 2001
From: matthew_swift <matthew_swift@localhost>
Date: Mon, 03 Sep 2007 20:36:20 +0000
Subject: [PATCH] Fix issue 1443: Admin framework: improve error logging in server

---
 opends/src/server/org/opends/server/admin/IllegalPropertyValueException.java |   30 +++++++++++++++---------------
 1 files changed, 15 insertions(+), 15 deletions(-)

diff --git a/opends/src/server/org/opends/server/admin/IllegalPropertyValueException.java b/opends/src/server/org/opends/server/admin/IllegalPropertyValueException.java
index 591252c..ef0cd5d 100644
--- a/opends/src/server/org/opends/server/admin/IllegalPropertyValueException.java
+++ b/opends/src/server/org/opends/server/admin/IllegalPropertyValueException.java
@@ -29,9 +29,15 @@
 
 
 
+import static org.opends.messages.AdminMessages.*;
+
+import org.opends.messages.Message;
+
+
+
 /**
- * Thrown to indicate that a property value was invalid according to its
- * associated property definition.
+ * Thrown to indicate that a property value was invalid according to
+ * its associated property definition.
  */
 public class IllegalPropertyValueException extends PropertyException {
 
@@ -48,13 +54,13 @@
   /**
    * Create a new illegal property value exception.
    *
-   * @param d
+   * @param pd
    *          The property definition.
    * @param value
    *          The illegal property value.
    */
-  public IllegalPropertyValueException(PropertyDefinition<?> d, Object value) {
-    super(d);
+  public IllegalPropertyValueException(PropertyDefinition<?> pd, Object value) {
+    super(pd, createMessage(pd, value));
     this.value = value;
   }
 
@@ -71,18 +77,12 @@
 
 
 
-  /**
-   * {@inheritDoc}
-   */
-  @Override
-  public String getMessage() {
-    String msg = "The value \"%s\" is not a valid value for the "
-        + "property \"%s\", which must have the following syntax: %s";
-    PropertyDefinition<?> pd = getPropertyDefinition();
+  // Create the message.
+  private static Message createMessage(PropertyDefinition<?> pd, Object value) {
     PropertyDefinitionUsageBuilder builder = new PropertyDefinitionUsageBuilder(
         true);
-    return String.format(msg, String.valueOf(value), pd.getName(), builder
-        .getUsage(pd));
+    return ERR_ILLEGAL_PROPERTY_VALUE_EXCEPTION.get(String.valueOf(value), pd
+        .getName(), builder.getUsage(pd));
   }
 
 }

--
Gitblit v1.10.0