From 22b5b14b9923faeb26742d215a9810c9769fe9e4 Mon Sep 17 00:00:00 2001
From: Ludovic Poitou <ludovic.poitou@forgerock.com>
Date: Thu, 20 Jan 2011 18:05:44 +0000
Subject: [PATCH] Code cleanup removing potential issues detected by FindBugs

---
 opends/src/server/org/opends/server/admin/client/cli/DsFrameworkCliGlobalAdmin.java |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/opends/src/server/org/opends/server/admin/client/cli/DsFrameworkCliGlobalAdmin.java b/opends/src/server/org/opends/server/admin/client/cli/DsFrameworkCliGlobalAdmin.java
index 9212cd1..886ec2c 100644
--- a/opends/src/server/org/opends/server/admin/client/cli/DsFrameworkCliGlobalAdmin.java
+++ b/opends/src/server/org/opends/server/admin/client/cli/DsFrameworkCliGlobalAdmin.java
@@ -23,6 +23,7 @@
  *
  *
  *      Copyright 2007-2009 Sun Microsystems, Inc.
+ *      Portions Copyright 2011 ForgeRock AS
  */
 package org.opends.server.admin.client.cli;
 
@@ -601,8 +602,7 @@
           }
           table.startRow();
           table.appendCell(adminUserProp.getAttributeName());
-          table.appendCell(getPropertyOptionSummary(userAdminProperties
-              .get(adminUserProp)));
+          table.appendCell(getPropertyOptionSummary(adminUserProp));
           table.appendCell(adminUserProp.getAttributeSyntax());
           if (userAdminProperties.get(adminUserProp).getDefaultValue() != null)
           {
@@ -823,12 +823,12 @@
   }
 
   //Compute the options field.
-  private String getPropertyOptionSummary(Argument arg)
+  private String getPropertyOptionSummary(AdministratorProperty adminUserProp)
   {
+    Argument arg = userAdminProperties.get(adminUserProp);
     StringBuilder b = new StringBuilder();
 
-    if (readonlyadminUserProperties.contains(
-        ADSContext.getServerPropFromName(arg.getName())))
+    if (readonlyadminUserProperties.contains(adminUserProp))
     {
       b.append("r-"); //$NON-NLS-1$
     }

--
Gitblit v1.10.0