From 959c9ded0c297d00500678a0c80d7d6d8a5265fe Mon Sep 17 00:00:00 2001
From: neil_a_wilson <neil_a_wilson@localhost>
Date: Tue, 10 Jul 2007 16:03:42 +0000
Subject: [PATCH] Fix a set of problems with the configuration interface in which there were a number of cases in which insufficient validation was performed. In particular, if a new configuration object was added over protocol or an existing configuration object was changed from disabled to enabled, then the server would only perform generic validation for that component and would not have any way to perform more detailed validation that could detect larger numbers of problems.
---
opends/src/server/org/opends/server/api/Backend.java | 36 ++++++++++++++++++++++++++++++++----
1 files changed, 32 insertions(+), 4 deletions(-)
diff --git a/opends/src/server/org/opends/server/api/Backend.java b/opends/src/server/org/opends/server/api/Backend.java
index a9842b6..202406e 100644
--- a/opends/src/server/org/opends/server/api/Backend.java
+++ b/opends/src/server/org/opends/server/api/Backend.java
@@ -34,6 +34,7 @@
import java.util.Set;
import java.util.concurrent.locks.Lock;
+import org.opends.server.admin.Configuration;
import org.opends.server.config.ConfigException;
import org.opends.server.core.AddOperation;
import org.opends.server.core.DeleteOperation;
@@ -58,7 +59,6 @@
import static org.opends.server.messages.BackendMessages.*;
import static org.opends.server.messages.MessageHandler.*;
-import org.opends.server.admin.Configuration;
/**
@@ -67,9 +67,6 @@
*/
public abstract class Backend
{
-
-
-
// The backend that holds a portion of the DIT that is
// hierarchically above the information in this backend.
private Backend parentBackend;
@@ -125,6 +122,37 @@
/**
+ * Indicates whether the provided configuration is acceptable for
+ * this backend. It should be possible to call this method on an
+ * uninitialized backend instance in order to determine whether the
+ * backend would be able to use the provided configuration.
+ * <BR><BR>
+ * Note that implementations which use a subclass of the provided
+ * configuration class will likely need to cast the configuration
+ * to the appropriate subclass type.
+ *
+ * @param configuration The backend configuration for which
+ * to make the determination.
+ * @param unacceptableReasons A list that may be used to hold the
+ * reasons that the provided
+ * configuration is not acceptable.
+ *
+ * @return {@code true} if the provided configuration is acceptable
+ * for this backend, or {@code false} if not.
+ */
+ public boolean isConfigurationAcceptable(
+ Configuration configuration,
+ List<String> unacceptableReasons)
+ {
+ // This default implementation does not perform any special
+ // validation. It should be overridden by backend implementations
+ // that wish to perform more detailed validation.
+ return true;
+ }
+
+
+
+ /**
* Initializes this backend based on the information provided
* when the backend was configured.
*
--
Gitblit v1.10.0