From 959c9ded0c297d00500678a0c80d7d6d8a5265fe Mon Sep 17 00:00:00 2001
From: neil_a_wilson <neil_a_wilson@localhost>
Date: Tue, 10 Jul 2007 16:03:42 +0000
Subject: [PATCH] Fix a set of problems with the configuration interface in which there were a number of cases in which insufficient validation was performed. In particular, if a new configuration object was added over protocol or an existing configuration object was changed from disabled to enabled, then the server would only perform generic validation for that component and would not have any way to perform more detailed validation that could detect larger numbers of problems.
---
opends/src/server/org/opends/server/api/Group.java | 36 ++++++++++++++++++++++++++++++++++--
1 files changed, 34 insertions(+), 2 deletions(-)
diff --git a/opends/src/server/org/opends/server/api/Group.java b/opends/src/server/org/opends/server/api/Group.java
index 99e4bfe..88728ec 100644
--- a/opends/src/server/org/opends/server/api/Group.java
+++ b/opends/src/server/org/opends/server/api/Group.java
@@ -63,8 +63,7 @@
* @param <T> The type of configuration handled by this group
* implementation.
*/
-public abstract class Group<T
- extends GroupImplementationCfg>
+public abstract class Group<T extends GroupImplementationCfg>
{
/**
* Initializes a "shell" instance of this group implementation that
@@ -89,6 +88,39 @@
/**
+ * Indicates whether the provided configuration is acceptable for
+ * this group implementation. It should be possible to call this
+ * method on an uninitialized group implementation instance in order
+ * to determine whether the group implementation would be able to
+ * use the provided configuration.
+ * <BR><BR>
+ * Note that implementations which use a subclass of the provided
+ * configuration class will likely need to cast the configuration
+ * to the appropriate subclass type.
+ *
+ * @param configuration The group implementation
+ * configuration for which to make the
+ * determination.
+ * @param unacceptableReasons A list that may be used to hold the
+ * reasons that the provided
+ * configuration is not acceptable.
+ *
+ * @return {@code true} if the provided configuration is acceptable
+ * for this group implementation, or {@code false} if not.
+ */
+ public boolean isConfigurationAcceptable(
+ GroupImplementationCfg configuration,
+ List<String> unacceptableReasons)
+ {
+ // This default implementation does not perform any special
+ // validation. It should be overridden by group implementations
+ // that wish to perform more detailed validation.
+ return true;
+ }
+
+
+
+ /**
* Performs any necessary finalization that may be needed whenever
* this group implementation is taken out of service within the
* Directory Server (e.g., if it is disabled or the server is
--
Gitblit v1.10.0