From 959c9ded0c297d00500678a0c80d7d6d8a5265fe Mon Sep 17 00:00:00 2001
From: neil_a_wilson <neil_a_wilson@localhost>
Date: Tue, 10 Jul 2007 16:03:42 +0000
Subject: [PATCH] Fix a set of problems with the configuration interface in which there were a number of cases in which insufficient validation was performed.  In particular, if a new configuration object was added over protocol or an existing configuration object was changed from disabled to enabled, then the server would only perform generic validation for that component and would not have any way to perform more detailed validation that could detect larger numbers of problems.

---
 opends/src/server/org/opends/server/api/SASLMechanismHandler.java |   37 ++++++++++++++++++++++++++++++++++++-
 1 files changed, 36 insertions(+), 1 deletions(-)

diff --git a/opends/src/server/org/opends/server/api/SASLMechanismHandler.java b/opends/src/server/org/opends/server/api/SASLMechanismHandler.java
index bac65ab..997470f 100644
--- a/opends/src/server/org/opends/server/api/SASLMechanismHandler.java
+++ b/opends/src/server/org/opends/server/api/SASLMechanismHandler.java
@@ -28,6 +28,8 @@
 
 
 
+import java.util.List;
+
 import org.opends.server.admin.std.server.SASLMechanismHandlerCfg;
 import org.opends.server.config.ConfigException;
 import org.opends.server.core.BindOperation;
@@ -35,7 +37,6 @@
 
 
 
-
 /**
  * This class defines the set of methods and structures that must be
  * implemented by a Directory Server module that implements the
@@ -71,6 +72,40 @@
 
 
   /**
+   * Indicates whether the provided configuration is acceptable for
+   * this SASL mechanism handler.  It should be possible to call this
+   * method on an uninitialized SASL mechanism handler instance in
+   * order to determine whether the SASL mechanism handler would be
+   * able to use the provided configuration.
+   * <BR><BR>
+   * Note that implementations which use a subclass of the provided
+   * configuration class will likely need to cast the configuration
+   * to the appropriate subclass type.
+   *
+   * @param  configuration        The SASL mechanism handler
+   *                              configuration for which to make the
+   *                              determination.
+   * @param  unacceptableReasons  A list that may be used to hold the
+   *                              reasons that the provided
+   *                              configuration is not acceptable.
+   *
+   * @return  {@code true} if the provided configuration is acceptable
+   *          for this SASL mechanism handler, or {@code false} if
+   *          not.
+   */
+  public boolean isConfigurationAcceptable(
+                      SASLMechanismHandlerCfg configuration,
+                      List<String> unacceptableReasons)
+  {
+    // This default implementation does not perform any special
+    // validation.  It should be overridden by SASL mechanism handler
+    // implementations that wish to perform more detailed validation.
+    return true;
+  }
+
+
+
+  /**
    * Performs any finalization that may be necessary for this SASL
    * mechanism handler.  By default, no finalization is performed.
    */

--
Gitblit v1.10.0