From 533380780bc3ba7c4ed7fcf138745e37698f60b1 Mon Sep 17 00:00:00 2001
From: Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Date: Fri, 26 Jul 2013 10:24:14 +0000
Subject: [PATCH] Comments to javadocs. Extracted method haveSimilarRights() from isApplicable(). Used interfaces instead of concrete classes.
---
opends/src/server/org/opends/server/authorization/dseecompat/ExtOp.java | 25 ++++++++++---------------
1 files changed, 10 insertions(+), 15 deletions(-)
diff --git a/opends/src/server/org/opends/server/authorization/dseecompat/ExtOp.java b/opends/src/server/org/opends/server/authorization/dseecompat/ExtOp.java
index 7b8302d..dc2ad13 100644
--- a/opends/src/server/org/opends/server/authorization/dseecompat/ExtOp.java
+++ b/opends/src/server/org/opends/server/authorization/dseecompat/ExtOp.java
@@ -23,31 +23,28 @@
*
*
* Copyright 2008 Sun Microsystems, Inc.
+ * Portions Copyright 2013 ForgeRock AS
*/
-
package org.opends.server.authorization.dseecompat;
import static org.opends.messages.AccessControlMessages.*;
import java.util.HashSet;
-
+import java.util.Set;
/**
* This class represents an ACI's extop keyword rule.
*/
-
public class ExtOp {
-
- /*
+ /**
* HashSet of OID strings parsed from the decode.
*/
- private HashSet<String> extOpOIDs = new HashSet<String>();
+ private Set<String> extOpOIDs = new HashSet<String>();
- /*
- * Enumeration representing the extop operator.
- */
-
+ /**
+ * Enumeration representing the extop operator.
+ */
private EnumTargetOperator op = EnumTargetOperator.EQUALITY;
/**
@@ -57,12 +54,12 @@
* @param extOpOIDs Set of extended operation OIDS to use in the evaluation
* (wild-card '*' allowed).
*/
- private ExtOp(EnumTargetOperator op, HashSet<String> extOpOIDs) {
+ private ExtOp(EnumTargetOperator op, Set<String> extOpOIDs)
+ {
this.extOpOIDs=extOpOIDs;
this.op=op;
}
-
/**
* Decode an extop expression string.
*
@@ -75,8 +72,7 @@
*/
public static ExtOp decode(EnumTargetOperator operator, String expr)
throws AciException {
- HashSet<String> extOpOIDs =
- Aci.decodeOID(expr,
+ Set<String> extOpOIDs = Aci.decodeOID(expr,
WARN_ACI_SYNTAX_INVALID_TARGEXTOP_EXPRESSION.get(expr));
return new ExtOp(operator, extOpOIDs);
}
@@ -101,5 +97,4 @@
ret = !ret;
return ret;
}
-
}
--
Gitblit v1.10.0