From 98a5df3565beaa1999020a16fcb5338d13d5b50f Mon Sep 17 00:00:00 2001
From: Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Date: Tue, 26 Aug 2014 08:11:29 +0000
Subject: [PATCH] Removed useless getChangeNumber() and setChangeNumber methods from *Operation interfaces. These methods are useless because setChangeNumber() is never set inside production code, so changeNumber is always equal to -1 for all the update operations. In addition it is very unlikely the ChangeNumberIndexer could have computed the changeNumber before a results are sent to a persistent search.
---
opends/src/server/org/opends/server/core/AddOperation.java | 50 ++++++++++++++++----------------------------------
1 files changed, 16 insertions(+), 34 deletions(-)
diff --git a/opends/src/server/org/opends/server/core/AddOperation.java b/opends/src/server/org/opends/server/core/AddOperation.java
index fd208ab..9b3fdfc 100644
--- a/opends/src/server/org/opends/server/core/AddOperation.java
+++ b/opends/src/server/org/opends/server/core/AddOperation.java
@@ -22,6 +22,7 @@
*
*
* Copyright 2006-2008 Sun Microsystems, Inc.
+ * Portions copyright 2014 ForgeRock AS
*/
package org.opends.server.core;
@@ -44,7 +45,7 @@
*
* @return The DN of the entry in a raw, unparsed form.
*/
- public abstract ByteString getRawEntryDN();
+ ByteString getRawEntryDN();
/**
* Specifies the raw entry DN for the entry to add. This should only be
@@ -55,7 +56,7 @@
*
* @param rawEntryDN The raw entry DN for the entry to add.
*/
- public abstract void setRawEntryDN(ByteString rawEntryDN);
+ void setRawEntryDN(ByteString rawEntryDN);
/**
* Retrieves the DN of the entry to add. This method should not be called
@@ -65,7 +66,7 @@
* @return The DN of the entry to add, or <CODE>null</CODE> if it has not yet
* been parsed from the raw DN.
*/
- public abstract DN getEntryDN();
+ DN getEntryDN();
/**
* Retrieves the set of attributes in their raw, unparsed form as read from
@@ -76,7 +77,7 @@
* @return The set of attributes in their raw, unparsed form as read from the
* client request.
*/
- public abstract List<RawAttribute> getRawAttributes();
+ List<RawAttribute> getRawAttributes();
/**
* Adds the provided attribute to the set of raw attributes for this add
@@ -85,7 +86,7 @@
* @param rawAttribute The attribute to add to the set of raw attributes for
* this add operation.
*/
- public abstract void addRawAttribute(RawAttribute rawAttribute);
+ void addRawAttribute(RawAttribute rawAttribute);
/**
* Replaces the set of raw attributes for this add operation. This should
@@ -93,7 +94,7 @@
*
* @param rawAttributes The set of raw attributes for this add operation.
*/
- public abstract void setRawAttributes(List<RawAttribute> rawAttributes);
+ void setRawAttributes(List<RawAttribute> rawAttributes);
/**
* Retrieves the set of processed user attributes for the entry to add. This
@@ -104,7 +105,7 @@
* @return The set of processed user attributes for the entry to add, or
* <CODE>null</CODE> if that information is not yet available.
*/
- public abstract Map<AttributeType, List<Attribute>> getUserAttributes();
+ Map<AttributeType, List<Attribute>> getUserAttributes();
/**
* Sets the specified attribute in the entry to add, overwriting any existing
@@ -117,8 +118,7 @@
* @param attributeType The attribute type for the attribute.
* @param attributeList The attribute list for the provided attribute type.
*/
- public abstract void setAttribute(AttributeType attributeType,
- List<Attribute> attributeList);
+ void setAttribute(AttributeType attributeType, List<Attribute> attributeList);
/**
* Removes the specified attribute from the entry to add. This should only be
@@ -129,25 +129,7 @@
*
* @param attributeType The attribute tyep for the attribute to remove.
*/
- public abstract void removeAttribute(AttributeType attributeType);
-
- /**
- * Retrieves the change number that has been assigned to this operation.
- *
- * @return The change number that has been assigned to this operation, or -1
- * if none has been assigned yet or if there is no applicable
- * synchronization mechanism in place that uses change numbers.
- */
- public abstract long getChangeNumber();
-
- /**
- * Specifies the change number that has been assigned to this operation by the
- * synchronization mechanism.
- *
- * @param changeNumber The change number that has been assigned to this
- * operation by the synchronization mechanism.
- */
- public abstract void setChangeNumber(long changeNumber);
+ void removeAttribute(AttributeType attributeType);
/**
* Retrieves the set of processed objectclasses for the entry to add. This
@@ -158,7 +140,7 @@
* @return The set of processed objectclasses for the entry to add, or
* <CODE>null</CODE> if that information is not yet available.
*/
- public abstract Map<ObjectClass,String> getObjectClasses();
+ Map<ObjectClass, String> getObjectClasses();
/**
* Adds the provided objectclass to the entry to add. This should only be
@@ -170,7 +152,7 @@
* @param objectClass The objectclass to add to the entry.
* @param name The name to use for the objectclass.
*/
- public abstract void addObjectClass(ObjectClass objectClass, String name);
+ void addObjectClass(ObjectClass objectClass, String name);
/**
* Removes the provided objectclass from the entry to add. This should only
@@ -181,7 +163,7 @@
*
* @param objectClass The objectclass to remove from the entry.
*/
- public abstract void removeObjectClass(ObjectClass objectClass);
+ void removeObjectClass(ObjectClass objectClass);
/**
* Retrieves the set of processed operational attributes for the entry to add.
@@ -192,7 +174,7 @@
* @return The set of processed operational attributes for the entry to add,
* or <CODE>null</CODE> if that information is not yet available.
*/
- public abstract Map<AttributeType,List<Attribute>> getOperationalAttributes();
+ Map<AttributeType, List<Attribute>> getOperationalAttributes();
/**
* Retrieves the proxied authorization DN for this operation if proxied
@@ -202,7 +184,7 @@
* authorization has been requested, or {@code null} if proxied
* authorization has not been requested.
*/
- public abstract DN getProxiedAuthorizationDN();
+ DN getProxiedAuthorizationDN();
/**
* Set the proxied authorization DN for this operation if proxied
@@ -213,6 +195,6 @@
* authorization has been requested, or {@code null} if proxied
* authorization has not been requested.
*/
- public abstract void setProxiedAuthorizationDN(DN proxiedAuthorizationDN);
+ void setProxiedAuthorizationDN(DN proxiedAuthorizationDN);
}
--
Gitblit v1.10.0