From 98a5df3565beaa1999020a16fcb5338d13d5b50f Mon Sep 17 00:00:00 2001
From: Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Date: Tue, 26 Aug 2014 08:11:29 +0000
Subject: [PATCH] Removed useless getChangeNumber() and setChangeNumber methods from *Operation interfaces. These methods are useless because setChangeNumber() is never set inside production code, so changeNumber is always equal to -1 for all the update operations. In addition it is very unlikely the ChangeNumberIndexer could have computed the changeNumber before a results are sent to a persistent search.
---
opends/src/server/org/opends/server/core/DeleteOperationWrapper.java | 46 +++++++---------------------------------------
1 files changed, 7 insertions(+), 39 deletions(-)
diff --git a/opends/src/server/org/opends/server/core/DeleteOperationWrapper.java b/opends/src/server/org/opends/server/core/DeleteOperationWrapper.java
index 9eaa17a..16c7cd4 100644
--- a/opends/src/server/org/opends/server/core/DeleteOperationWrapper.java
+++ b/opends/src/server/org/opends/server/core/DeleteOperationWrapper.java
@@ -22,15 +22,13 @@
*
*
* Copyright 2008 Sun Microsystems, Inc.
- * Portions Copyright 2013 ForgeRock AS
+ * Portions Copyright 2013-2014 ForgeRock AS
*/
package org.opends.server.core;
-
import org.opends.server.types.ByteString;
import org.opends.server.types.DN;
-
/**
* This abstract class wraps/decorates a given delete operation.
* This class will be extended by sub-classes to enhance the
@@ -50,72 +48,42 @@
super(delete);
}
- /**
- * {@inheritDoc}
- */
+ /** {@inheritDoc} */
@Override
public DN getEntryDN()
{
return getOperation().getEntryDN();
}
- /**
- * {@inheritDoc}
- */
+ /** {@inheritDoc} */
@Override
public ByteString getRawEntryDN()
{
return getOperation().getRawEntryDN();
}
- /**
- * {@inheritDoc}
- */
+ /** {@inheritDoc} */
@Override
public void setRawEntryDN(ByteString rawEntryDN)
{
getOperation().setRawEntryDN(rawEntryDN);
}
- /**
- * {@inheritDoc}
- */
- @Override
- public final long getChangeNumber()
- {
- return getOperation().getChangeNumber();
- }
-
- /**
- * {@inheritDoc}
- */
- @Override
- public final void setChangeNumber(long changeNumber)
- {
- getOperation().setChangeNumber(changeNumber);
- }
-
- /**
- * {@inheritDoc}
- */
+ /** {@inheritDoc} */
@Override
public String toString()
{
return getOperation().toString();
}
- /**
- * {@inheritDoc}
- */
+ /** {@inheritDoc} */
@Override
public DN getProxiedAuthorizationDN()
{
return getOperation().getProxiedAuthorizationDN();
}
- /**
- * {@inheritDoc}
- */
+ /** {@inheritDoc} */
@Override
public void setProxiedAuthorizationDN(DN proxiedAuthorizationDN)
{
--
Gitblit v1.10.0