From 445e7dacd8794fdaf8967748015a446668c261cc Mon Sep 17 00:00:00 2001
From: lutoff <lutoff@localhost>
Date: Fri, 06 Apr 2007 07:28:41 +0000
Subject: [PATCH] Issue 1484 fix (use new admin framework for password generation configuration)

---
 opends/src/server/org/opends/server/core/PasswordGeneratorConfigManager.java |  950 ++++++++++++----------------------------------------------
 1 files changed, 200 insertions(+), 750 deletions(-)

diff --git a/opends/src/server/org/opends/server/core/PasswordGeneratorConfigManager.java b/opends/src/server/org/opends/server/core/PasswordGeneratorConfigManager.java
index 3acb597..1091630 100644
--- a/opends/src/server/org/opends/server/core/PasswordGeneratorConfigManager.java
+++ b/opends/src/server/org/opends/server/core/PasswordGeneratorConfigManager.java
@@ -28,22 +28,21 @@
 
 
 
+import java.lang.reflect.Method;
 import java.util.ArrayList;
-import java.util.Iterator;
-import java.util.LinkedList;
 import java.util.List;
 import java.util.concurrent.ConcurrentHashMap;
 
-import org.opends.server.api.ConfigAddListener;
-import org.opends.server.api.ConfigChangeListener;
-import org.opends.server.api.ConfigDeleteListener;
-import org.opends.server.api.ConfigHandler;
-import org.opends.server.api.ConfigurableComponent;
+import org.opends.server.admin.ClassPropertyDefinition;
+import org.opends.server.admin.server.ConfigurationAddListener;
+import org.opends.server.admin.server.ConfigurationChangeListener;
+import org.opends.server.admin.server.ConfigurationDeleteListener;
+import org.opends.server.admin.server.ServerManagementContext;
+import org.opends.server.admin.std.meta.PasswordGeneratorCfgDefn;
+import org.opends.server.admin.std.server.PasswordGeneratorCfg;
+import org.opends.server.admin.std.server.RootCfg;
 import org.opends.server.api.PasswordGenerator;
-import org.opends.server.config.BooleanConfigAttribute;
-import org.opends.server.config.ConfigEntry;
 import org.opends.server.config.ConfigException;
-import org.opends.server.config.StringConfigAttribute;
 import org.opends.server.types.ConfigChangeResult;
 import org.opends.server.types.DN;
 import org.opends.server.types.ErrorLogCategory;
@@ -51,14 +50,10 @@
 import org.opends.server.types.InitializationException;
 import org.opends.server.types.ResultCode;
 
-import static org.opends.server.config.ConfigConstants.*;
-import static org.opends.server.loggers.debug.DebugLogger.debugCaught;
-import static org.opends.server.loggers.debug.DebugLogger.debugEnabled;
-import org.opends.server.types.DebugLogLevel;
 import static org.opends.server.loggers.Error.*;
 import static org.opends.server.messages.ConfigMessages.*;
 import static org.opends.server.messages.MessageHandler.*;
-import static org.opends.server.util.ServerConstants.*;
+import static org.opends.server.util.StaticUtils.stackTraceToSingleLineString;
 
 
 
@@ -70,26 +65,21 @@
  * running.
  */
 public class PasswordGeneratorConfigManager
-       implements ConfigChangeListener, ConfigAddListener, ConfigDeleteListener
+       implements ConfigurationAddListener<PasswordGeneratorCfg>,
+       ConfigurationDeleteListener<PasswordGeneratorCfg>,
+       ConfigurationChangeListener<PasswordGeneratorCfg>
 {
 
-
-
   // A mapping between the DNs of the config entries and the associated password
   // generators.
   private ConcurrentHashMap<DN,PasswordGenerator> passwordGenerators;
 
-  // The configuration handler for the Directory Server.
-  private ConfigHandler configHandler;
-
-
 
   /**
    * Creates a new instance of this password generator config manager.
    */
   public PasswordGeneratorConfigManager()
   {
-    configHandler      = DirectoryServer.getConfigHandler();
     passwordGenerators = new ConcurrentHashMap<DN,PasswordGenerator>();
   }
 
@@ -110,846 +100,254 @@
   public void initializePasswordGenerators()
          throws ConfigException, InitializationException
   {
-    // First, get the configuration base entry.
-    ConfigEntry baseEntry;
-    try
+    // Get the root configuration object.
+    ServerManagementContext managementContext =
+         ServerManagementContext.getInstance();
+    RootCfg rootConfiguration =
+         managementContext.getRootConfiguration();
+
+    // Register as an add and delete listener with the root configuration so we
+    // can be notified if any password generator entries are added or removed.
+    rootConfiguration.addPasswordGeneratorAddListener(this);
+    rootConfiguration.addPasswordGeneratorDeleteListener(this);
+
+
+    //Initialize the existing password generators.
+    for (String generatorName : rootConfiguration.listPasswordGenerators())
     {
-      DN generatorBase = DN.decode(DN_PWGENERATOR_CONFIG_BASE);
-      baseEntry = configHandler.getConfigEntry(generatorBase);
-    }
-    catch (Exception e)
-    {
-      if (debugEnabled())
+      PasswordGeneratorCfg generatorConfiguration =
+           rootConfiguration.getPasswordGenerator(generatorName);
+      generatorConfiguration.addChangeListener(this);
+
+      if (generatorConfiguration.isEnabled())
       {
-        debugCaught(DebugLogLevel.ERROR, e);
-      }
-
-      int    msgID   = MSGID_CONFIG_PWGENERATOR_CANNOT_GET_BASE;
-      String message = getMessage(msgID, String.valueOf(e));
-      throw new ConfigException(msgID, message, e);
-    }
-
-    if (baseEntry == null)
-    {
-      // The password generator base entry does not exist.  This is not
-      // acceptable, so throw an exception.
-      int    msgID   = MSGID_CONFIG_PWGENERATOR_BASE_DOES_NOT_EXIST;
-      String message = getMessage(msgID);
-      throw new ConfigException(msgID, message);
-    }
-
-
-    // Register add and delete listeners with the generator base entry.  We
-    // don't care about modifications to it.
-    baseEntry.registerAddListener(this);
-    baseEntry.registerDeleteListener(this);
-
-
-    // See if the base entry has any children.  If not, then we don't need to do
-    // anything else.
-    if (! baseEntry.hasChildren())
-    {
-      return;
-    }
-
-
-    // Iterate through the child entries and process them as password generator
-    // configuration entries.
-    for (ConfigEntry childEntry : baseEntry.getChildren().values())
-    {
-      childEntry.registerChangeListener(this);
-
-      StringBuilder unacceptableReason = new StringBuilder();
-      if (! configAddIsAcceptable(childEntry, unacceptableReason))
-      {
-        logError(ErrorLogCategory.CONFIGURATION, ErrorLogSeverity.SEVERE_ERROR,
-                 MSGID_CONFIG_PWGENERATOR_ENTRY_UNACCEPTABLE,
-                 childEntry.getDN().toString(), unacceptableReason.toString());
-        continue;
-      }
-
-      try
-      {
-        ConfigChangeResult result = applyConfigurationAdd(childEntry);
-        if (result.getResultCode() != ResultCode.SUCCESS)
+        String className = generatorConfiguration.getGeneratorClass();
+        try
         {
-          StringBuilder buffer = new StringBuilder();
-
-          List<String> resultMessages = result.getMessages();
-          if ((resultMessages == null) || (resultMessages.isEmpty()))
-          {
-            buffer.append(getMessage(MSGID_CONFIG_UNKNOWN_UNACCEPTABLE_REASON));
-          }
-          else
-          {
-            Iterator<String> iterator = resultMessages.iterator();
-
-            buffer.append(iterator.next());
-            while (iterator.hasNext())
-            {
-              buffer.append(EOL);
-              buffer.append(iterator.next());
-            }
-          }
-
+          PasswordGenerator<? extends PasswordGeneratorCfg>
+               generator = loadGenerator(className, generatorConfiguration);
+          passwordGenerators.put(generatorConfiguration.dn(), generator);
+          DirectoryServer.registerPasswordGenerator(generatorConfiguration.dn(),
+              generator);
+        }
+        catch (InitializationException ie)
+        {
           logError(ErrorLogCategory.CONFIGURATION,
                    ErrorLogSeverity.SEVERE_ERROR,
-                   MSGID_CONFIG_PWGENERATOR_CANNOT_CREATE_GENERATOR,
-                   childEntry.getDN().toString(), buffer.toString());
+                   ie.getMessage(), ie.getMessageID());
+          continue;
         }
       }
-      catch (Exception e)
-      {
-        logError(ErrorLogCategory.CONFIGURATION, ErrorLogSeverity.SEVERE_ERROR,
-                 MSGID_CONFIG_PWGENERATOR_CANNOT_CREATE_GENERATOR,
-                 childEntry.getDN().toString(), String.valueOf(e));
-      }
     }
   }
 
-
-
   /**
-   * Indicates whether the configuration entry that will result from a proposed
-   * modification is acceptable to this change listener.
-   *
-   * @param  configEntry         The configuration entry that will result from
-   *                             the requested update.
-   * @param  unacceptableReason  A buffer to which this method can append a
-   *                             human-readable message explaining why the
-   *                             proposed change is not acceptable.
-   *
-   * @return  <CODE>true</CODE> if the proposed entry contains an acceptable
-   *          configuration, or <CODE>false</CODE> if it does not.
+   * {@inheritDoc}
    */
-  public boolean configChangeIsAcceptable(ConfigEntry configEntry,
-                                          StringBuilder unacceptableReason)
+  public boolean isConfigurationChangeAcceptable(
+                      PasswordGeneratorCfg configuration,
+                      List<String> unacceptableReasons)
   {
-    // Make sure that the entry has an appropriate objectclass for a password
-    // generator.
-    if (! configEntry.hasObjectClass(OC_PASSWORD_GENERATOR))
+    if (configuration.isEnabled())
     {
-      int    msgID   = MSGID_CONFIG_PWGENERATOR_INVALID_OBJECTCLASS;
-      String message = getMessage(msgID, configEntry.getDN().toString());
-      unacceptableReason.append(message);
-      return false;
-    }
-
-
-    // Make sure that the entry specifies the generator class name.
-    StringConfigAttribute classNameAttr;
-    try
-    {
-      StringConfigAttribute classStub =
-           new StringConfigAttribute(ATTR_PWGENERATOR_CLASS,
-                    getMessage(MSGID_CONFIG_PWGENERATOR_DESCRIPTION_CLASS_NAME),
-                    true, false, true);
-      classNameAttr = (StringConfigAttribute)
-                      configEntry.getConfigAttribute(classStub);
-
-      if (classNameAttr == null)
+      // Get the name of the class and make sure we can instantiate it as a
+      // password generator.
+      String className = configuration.getGeneratorClass();
+      try
       {
-        int msgID = MSGID_CONFIG_PWGENERATOR_NO_CLASS_NAME;
-        String message = getMessage(msgID, configEntry.getDN().toString());
-        unacceptableReason.append(message);
+        loadGenerator(className, null);
+      }
+      catch (InitializationException ie)
+      {
+        unacceptableReasons.add(ie.getMessage());
         return false;
       }
     }
-    catch (Exception e)
-    {
-      if (debugEnabled())
-      {
-        debugCaught(DebugLogLevel.ERROR, e);
-      }
 
-      int msgID = MSGID_CONFIG_PWGENERATOR_INVALID_CLASS_NAME;
-      String message = getMessage(msgID, configEntry.getDN().toString(),
-                                  String.valueOf(e));
-      unacceptableReason.append(message);
-      return false;
-    }
-
-    Class generatorClass;
-    try
-    {
-      generatorClass = DirectoryServer.loadClass(classNameAttr.pendingValue());
-    }
-    catch (Exception e)
-    {
-      if (debugEnabled())
-      {
-        debugCaught(DebugLogLevel.ERROR, e);
-      }
-
-      int msgID = MSGID_CONFIG_PWGENERATOR_INVALID_CLASS_NAME;
-      String message = getMessage(msgID, configEntry.getDN().toString(),
-                                  String.valueOf(e));
-      unacceptableReason.append(message);
-      return false;
-    }
-
-    try
-    {
-      PasswordGenerator generator =
-           (PasswordGenerator) generatorClass.newInstance();
-    }
-    catch(Exception e)
-    {
-      if (debugEnabled())
-      {
-        debugCaught(DebugLogLevel.ERROR, e);
-      }
-
-      int msgID = MSGID_CONFIG_PWGENERATOR_INVALID_CLASS;
-      String message = getMessage(msgID, generatorClass.getName(),
-                                  String.valueOf(configEntry.getDN()),
-                                  String.valueOf(e));
-      unacceptableReason.append(message);
-      return false;
-    }
-
-
-    // See if this password generator should be enabled.
-    BooleanConfigAttribute enabledAttr;
-    try
-    {
-      BooleanConfigAttribute enabledStub =
-           new BooleanConfigAttribute(ATTR_PWGENERATOR_ENABLED,
-                    getMessage(MSGID_CONFIG_PWGENERATOR_DESCRIPTION_ENABLED),
-                               false);
-      enabledAttr = (BooleanConfigAttribute)
-                    configEntry.getConfigAttribute(enabledStub);
-
-      if (enabledAttr == null)
-      {
-        int msgID = MSGID_CONFIG_PWGENERATOR_NO_ENABLED_ATTR;
-        String message = getMessage(msgID, configEntry.getDN().toString());
-        unacceptableReason.append(message);
-        return false;
-      }
-    }
-    catch (Exception e)
-    {
-      if (debugEnabled())
-      {
-        debugCaught(DebugLogLevel.ERROR, e);
-      }
-
-      int msgID = MSGID_CONFIG_PWGENERATOR_INVALID_ENABLED_VALUE;
-      String message = getMessage(msgID, configEntry.getDN().toString(),
-                                  String.valueOf(e));
-      unacceptableReason.append(message);
-      return false;
-    }
-
-
-    // If we've gotten here then the password generator entry appears to be
-    // acceptable.
+    // If we've gotten here, then it's fine.
     return true;
   }
 
 
-
   /**
-   * Attempts to apply a new configuration to this Directory Server component
-   * based on the provided changed entry.
-   *
-   * @param  configEntry  The configuration entry that containing the updated
-   *                      configuration for this component.
-   *
-   * @return  Information about the result of processing the configuration
-   *          change.
+   * {@inheritDoc}
    */
-  public ConfigChangeResult applyConfigurationChange(ConfigEntry configEntry)
+  public ConfigChangeResult applyConfigurationChange(
+                                 PasswordGeneratorCfg configuration)
   {
-    DN                configEntryDN       = configEntry.getDN();
     ResultCode        resultCode          = ResultCode.SUCCESS;
     boolean           adminActionRequired = false;
     ArrayList<String> messages            = new ArrayList<String>();
 
 
-    // Make sure that the entry has an appropriate objectclass for a password
-    // generator.
-    if (! configEntry.hasObjectClass(OC_PASSWORD_GENERATOR))
+    // Get the existing generator if it's already enabled.
+    PasswordGenerator existingGenerator =
+         passwordGenerators.get(configuration.dn());
+
+
+    // If the new configuration has the generator disabled, then disable it if
+    // it is enabled, or do nothing if it's already disabled.
+    if (! configuration.isEnabled())
     {
-      int    msgID   = MSGID_CONFIG_PWGENERATOR_INVALID_OBJECTCLASS;
-      messages.add(getMessage(msgID, String.valueOf(configEntryDN)));
-      resultCode = ResultCode.UNWILLING_TO_PERFORM;
+      if (existingGenerator != null)
+      {
+        DirectoryServer.deregisterPasswordGenerator(configuration.dn());
+
+        PasswordGenerator passwordGenerator =
+             passwordGenerators.remove(configuration.dn());
+        if (passwordGenerator != null)
+        {
+          passwordGenerator.finalizePasswordGenerator();
+        }
+      }
+
       return new ConfigChangeResult(resultCode, adminActionRequired, messages);
     }
 
 
-    // Get the corresponding password generator if it is active.
-    PasswordGenerator generator = passwordGenerators.get(configEntryDN);
+    // Get the class for the password generator.  If the generator is already
+    // enabled, then we shouldn't do anything with it although if the class has
+    // changed then we'll at least need to indicate that administrative action
+    // is required.  If the generator is disabled, then instantiate the class
+    // and initialize and register it as a password generator.
+    String className = configuration.getGeneratorClass();
+    if (existingGenerator != null)
+    {
+      if (! className.equals(existingGenerator.getClass().getName()))
+      {
+        adminActionRequired = true;
+      }
 
+      return new ConfigChangeResult(resultCode, adminActionRequired, messages);
+    }
 
-    // See if this generator should be enabled or disabled.
-    boolean needsEnabled = false;
-    BooleanConfigAttribute enabledAttr;
+    PasswordGenerator<? extends PasswordGeneratorCfg>
+         passwordGenerator = null;
     try
     {
-      BooleanConfigAttribute enabledStub =
-           new BooleanConfigAttribute(ATTR_PWGENERATOR_ENABLED,
-                    getMessage(MSGID_CONFIG_PWGENERATOR_DESCRIPTION_ENABLED),
-                               false);
-      enabledAttr = (BooleanConfigAttribute)
-                    configEntry.getConfigAttribute(enabledStub);
-
-      if (enabledAttr == null)
-      {
-        int msgID = MSGID_CONFIG_PWGENERATOR_NO_ENABLED_ATTR;
-        messages.add(getMessage(msgID, String.valueOf(configEntryDN)));
-        resultCode = ResultCode.UNWILLING_TO_PERFORM;
-        return new ConfigChangeResult(resultCode, adminActionRequired,
-                                      messages);
-      }
-
-      if (enabledAttr.activeValue())
-      {
-        if (generator == null)
-        {
-          needsEnabled = true;
-        }
-        else
-        {
-          // The generator is already active, so no action is required.
-        }
-      }
-      else
-      {
-        if (generator == null)
-        {
-          // The generator is already disabled, so no action is required and we
-          // can short-circuit out of this processing.
-          return new ConfigChangeResult(resultCode, adminActionRequired,
-                                        messages);
-        }
-        else
-        {
-          // The generator is active, so it needs to be disabled.  Do this and
-          // return that we were successful.
-          passwordGenerators.remove(configEntryDN);
-          generator.finalizePasswordGenerator();
-
-          DirectoryServer.deregisterPasswordGenerator(configEntryDN);
-
-          return new ConfigChangeResult(resultCode, adminActionRequired,
-                                        messages);
-        }
-      }
+      passwordGenerator = loadGenerator(className, configuration);
     }
-    catch (Exception e)
+    catch (InitializationException ie)
     {
-      if (debugEnabled())
+      if (resultCode == ResultCode.SUCCESS)
       {
-        debugCaught(DebugLogLevel.ERROR, e);
-      }
-
-      int msgID = MSGID_CONFIG_PWGENERATOR_INVALID_ENABLED_VALUE;
-      messages.add(getMessage(msgID, String.valueOf(configEntryDN),
-                              String.valueOf(e)));
-      resultCode = DirectoryServer.getServerErrorResultCode();
-      return new ConfigChangeResult(resultCode, adminActionRequired, messages);
-    }
-
-
-    // Make sure that the entry specifies the generator class name.  If it has
-    // changed, then we will not try to dynamically apply it.
-    String className;
-    try
-    {
-      StringConfigAttribute classStub =
-           new StringConfigAttribute(ATTR_PWGENERATOR_CLASS,
-                    getMessage(MSGID_CONFIG_PWGENERATOR_DESCRIPTION_CLASS_NAME),
-                    true, false, true);
-      StringConfigAttribute classNameAttr =
-           (StringConfigAttribute) configEntry.getConfigAttribute(classStub);
-
-      if (classNameAttr == null)
-      {
-        int msgID = MSGID_CONFIG_PWGENERATOR_NO_CLASS_NAME;
-        messages.add(getMessage(msgID, String.valueOf(configEntryDN)));
-        resultCode = ResultCode.OBJECTCLASS_VIOLATION;
-        return new ConfigChangeResult(resultCode, adminActionRequired,
-                                      messages);
-      }
-
-      className = classNameAttr.pendingValue();
-    }
-    catch (Exception e)
-    {
-      if (debugEnabled())
-      {
-        debugCaught(DebugLogLevel.ERROR, e);
-      }
-
-      int msgID = MSGID_CONFIG_PWGENERATOR_INVALID_CLASS_NAME;
-      messages.add(getMessage(msgID, String.valueOf(configEntryDN),
-                              String.valueOf(e)));
-      resultCode = DirectoryServer.getServerErrorResultCode();
-      return new ConfigChangeResult(resultCode, adminActionRequired, messages);
-    }
-
-
-    boolean classChanged = false;
-    String  oldClassName = null;
-    if (generator != null)
-    {
-      oldClassName = generator.getClass().getName();
-      classChanged = (! className.equals(oldClassName));
-    }
-
-
-    if (classChanged)
-    {
-      // This will not be applied dynamically.  Add a message to the response
-      // and indicate that admin action is required.
-      adminActionRequired = true;
-      messages.add(getMessage(MSGID_CONFIG_PWGENERATOR_CLASS_ACTION_REQUIRED,
-                              String.valueOf(oldClassName),
-                              String.valueOf(className),
-                              String.valueOf(configEntryDN)));
-      return new ConfigChangeResult(resultCode, adminActionRequired, messages);
-    }
-
-
-    if (needsEnabled)
-    {
-      try
-      {
-        Class generatorClass = DirectoryServer.loadClass(className);
-        generator = (PasswordGenerator) generatorClass.newInstance();
-      }
-      catch (Exception e)
-      {
-        if (debugEnabled())
-        {
-          debugCaught(DebugLogLevel.ERROR, e);
-        }
-
-        int msgID = MSGID_CONFIG_PWGENERATOR_INVALID_CLASS;
-        messages.add(getMessage(msgID, className,
-                                String.valueOf(configEntryDN),
-                                String.valueOf(e)));
         resultCode = DirectoryServer.getServerErrorResultCode();
-        return new ConfigChangeResult(resultCode, adminActionRequired,
-                                      messages);
       }
 
-      try
-      {
-        generator.initializePasswordGenerator(configEntry);
-      }
-      catch (Exception e)
-      {
-        if (debugEnabled())
-        {
-          debugCaught(DebugLogLevel.ERROR, e);
-        }
-
-        int msgID = MSGID_CONFIG_PWGENERATOR_INITIALIZATION_FAILED;
-        messages.add(getMessage(msgID, className,
-                                String.valueOf(configEntryDN),
-                                String.valueOf(e)));
-        resultCode = DirectoryServer.getServerErrorResultCode();
-        return new ConfigChangeResult(resultCode, adminActionRequired,
-                                      messages);
-      }
-
-
-      passwordGenerators.put(configEntryDN, generator);
-      DirectoryServer.registerPasswordGenerator(configEntryDN, generator);
-      return new ConfigChangeResult(resultCode, adminActionRequired, messages);
+      messages.add(ie.getMessage());
     }
 
+    if (resultCode == ResultCode.SUCCESS)
+    {
+      passwordGenerators.put(configuration.dn(), passwordGenerator);
+      DirectoryServer.registerPasswordGenerator(configuration.dn(),
+                                                passwordGenerator);
+    }
 
-    // If we've gotten here, then there haven't been any changes to anything
-    // that we care about.
     return new ConfigChangeResult(resultCode, adminActionRequired, messages);
   }
-
-
-
   /**
-   * Indicates whether the configuration entry that will result from a proposed
-   * add is acceptable to this add listener.
-   *
-   * @param  configEntry         The configuration entry that will result from
-   *                             the requested add.
-   * @param  unacceptableReason  A buffer to which this method can append a
-   *                             human-readable message explaining why the
-   *                             proposed entry is not acceptable.
-   *
-   * @return  <CODE>true</CODE> if the proposed entry contains an acceptable
-   *          configuration, or <CODE>false</CODE> if it does not.
+   * {@inheritDoc}
    */
-  public boolean configAddIsAcceptable(ConfigEntry configEntry,
-                                       StringBuilder unacceptableReason)
+  public boolean isConfigurationAddAcceptable(
+                      PasswordGeneratorCfg configuration,
+                      List<String> unacceptableReasons)
   {
-    // Make sure that no entry already exists with the specified DN.
-    DN configEntryDN = configEntry.getDN();
-    if (passwordGenerators.containsKey(configEntryDN))
+    if (configuration.isEnabled())
     {
-      int    msgID   = MSGID_CONFIG_PWGENERATOR_EXISTS;
-      String message = getMessage(msgID, String.valueOf(configEntryDN));
-      unacceptableReason.append(message);
-      return false;
-    }
-
-
-    // Make sure that the entry has an appropriate objectclass for a password
-    // generator.
-    if (! configEntry.hasObjectClass(OC_PASSWORD_GENERATOR))
-    {
-      int    msgID   = MSGID_CONFIG_PWGENERATOR_INVALID_OBJECTCLASS;
-      String message = getMessage(msgID, configEntry.getDN().toString());
-      unacceptableReason.append(message);
-      return false;
-    }
-
-
-    // Make sure that the entry specifies the password generator class.
-    StringConfigAttribute classNameAttr;
-    try
-    {
-      StringConfigAttribute classStub =
-           new StringConfigAttribute(ATTR_PWGENERATOR_CLASS,
-                    getMessage(MSGID_CONFIG_PWGENERATOR_DESCRIPTION_CLASS_NAME),
-                    true, false, true);
-      classNameAttr = (StringConfigAttribute)
-                      configEntry.getConfigAttribute(classStub);
-
-      if (classNameAttr == null)
+      // Get the name of the class and make sure we can instantiate it as a
+      // password generator.
+      String className = configuration.getGeneratorClass();
+      try
       {
-        int msgID = MSGID_CONFIG_PWGENERATOR_NO_CLASS_NAME;
-        String message = getMessage(msgID, configEntry.getDN().toString());
-        unacceptableReason.append(message);
-        return false;
+        loadGenerator(className, null);
       }
-    }
-    catch (Exception e)
-    {
-      if (debugEnabled())
+      catch (InitializationException ie)
       {
-        debugCaught(DebugLogLevel.ERROR, e);
-      }
-
-      int msgID = MSGID_CONFIG_PWGENERATOR_INVALID_CLASS_NAME;
-      String message = getMessage(msgID, configEntry.getDN().toString(),
-                                  String.valueOf(e));
-      unacceptableReason.append(message);
-      return false;
-    }
-
-    Class generatorClass;
-    try
-    {
-      generatorClass = DirectoryServer.loadClass(classNameAttr.pendingValue());
-    }
-    catch (Exception e)
-    {
-      if (debugEnabled())
-      {
-        debugCaught(DebugLogLevel.ERROR, e);
-      }
-
-      int msgID = MSGID_CONFIG_PWGENERATOR_INVALID_CLASS_NAME;
-      String message = getMessage(msgID, configEntry.getDN().toString(),
-                                  String.valueOf(e));
-      unacceptableReason.append(message);
-      return false;
-    }
-
-    PasswordGenerator generator;
-    try
-    {
-      generator = (PasswordGenerator) generatorClass.newInstance();
-    }
-    catch (Exception e)
-    {
-      if (debugEnabled())
-      {
-        debugCaught(DebugLogLevel.ERROR, e);
-      }
-
-      int msgID = MSGID_CONFIG_PWGENERATOR_INVALID_CLASS;
-      String message = getMessage(msgID, generatorClass.getName(),
-                                  String.valueOf(configEntryDN),
-                                  String.valueOf(e));
-      unacceptableReason.append(message);
-      return false;
-    }
-
-
-    // If the generator is a configurable component, then make sure that
-    // its configuration is valid.
-    if (generator instanceof ConfigurableComponent)
-    {
-      ConfigurableComponent cc = (ConfigurableComponent) generator;
-      LinkedList<String> errorMessages = new LinkedList<String>();
-      if (! cc.hasAcceptableConfiguration(configEntry, errorMessages))
-      {
-        if (errorMessages.isEmpty())
-        {
-          int msgID = MSGID_CONFIG_PWGENERATOR_UNACCEPTABLE_CONFIG;
-          unacceptableReason.append(getMessage(msgID,
-                                               String.valueOf(configEntryDN)));
-        }
-        else
-        {
-          Iterator<String> iterator = errorMessages.iterator();
-          unacceptableReason.append(iterator.next());
-          while (iterator.hasNext())
-          {
-            unacceptableReason.append("  ");
-            unacceptableReason.append(iterator.next());
-          }
-        }
-
+        unacceptableReasons.add(ie.getMessage());
         return false;
       }
     }
 
-
-    // See if this generator should be enabled.
-    BooleanConfigAttribute enabledAttr;
-    try
-    {
-      BooleanConfigAttribute enabledStub =
-           new BooleanConfigAttribute(ATTR_PWGENERATOR_ENABLED,
-                    getMessage(MSGID_CONFIG_PWGENERATOR_DESCRIPTION_ENABLED),
-                               false);
-      enabledAttr = (BooleanConfigAttribute)
-                    configEntry.getConfigAttribute(enabledStub);
-
-      if (enabledAttr == null)
-      {
-        int msgID = MSGID_CONFIG_PWGENERATOR_NO_ENABLED_ATTR;
-        String message = getMessage(msgID, configEntry.getDN().toString());
-        unacceptableReason.append(message);
-        return false;
-      }
-    }
-    catch (Exception e)
-    {
-      if (debugEnabled())
-      {
-        debugCaught(DebugLogLevel.ERROR, e);
-      }
-
-      int msgID = MSGID_CONFIG_PWGENERATOR_INVALID_ENABLED_VALUE;
-      String message = getMessage(msgID, configEntry.getDN().toString(),
-                                  String.valueOf(e));
-      unacceptableReason.append(message);
-      return false;
-    }
-
-
-    // If we've gotten here then the generator entry appears to be acceptable.
+    // If we've gotten here, then it's fine.
     return true;
   }
 
 
-
   /**
-   * Attempts to apply a new configuration based on the provided added entry.
-   *
-   * @param  configEntry  The new configuration entry that contains the
-   *                      configuration to apply.
-   *
-   * @return  Information about the result of processing the configuration
-   *          change.
+   * {@inheritDoc}
    */
-  public ConfigChangeResult applyConfigurationAdd(ConfigEntry configEntry)
+  public ConfigChangeResult applyConfigurationAdd(
+                                 PasswordGeneratorCfg configuration)
   {
-    DN                configEntryDN       = configEntry.getDN();
     ResultCode        resultCode          = ResultCode.SUCCESS;
     boolean           adminActionRequired = false;
     ArrayList<String> messages            = new ArrayList<String>();
 
+    configuration.addChangeListener(this);
 
-    // Make sure that the entry has an appropriate objectclass for a password
-    // generator.
-    if (! configEntry.hasObjectClass(OC_PASSWORD_GENERATOR))
+    if (! configuration.isEnabled())
     {
-      int    msgID   = MSGID_CONFIG_PWGENERATOR_INVALID_OBJECTCLASS;
-      messages.add(getMessage(msgID, String.valueOf(configEntryDN)));
-      resultCode = ResultCode.UNWILLING_TO_PERFORM;
       return new ConfigChangeResult(resultCode, adminActionRequired, messages);
     }
 
+    PasswordGenerator<? extends PasswordGeneratorCfg>
+         passwordGenerator = null;
 
-    // See if this generator should be enabled or disabled.
-    BooleanConfigAttribute enabledAttr;
+    // Get the name of the class and make sure we can instantiate it as a
+    // password generator.
+    String className = configuration.getGeneratorClass();
     try
     {
-      BooleanConfigAttribute enabledStub =
-           new BooleanConfigAttribute(ATTR_PWGENERATOR_ENABLED,
-                    getMessage(MSGID_CONFIG_PWGENERATOR_DESCRIPTION_ENABLED),
-                               false);
-      enabledAttr = (BooleanConfigAttribute)
-                    configEntry.getConfigAttribute(enabledStub);
-
-      if (enabledAttr == null)
-      {
-        // The attribute doesn't exist, so it will be disabled by default.
-        int msgID = MSGID_CONFIG_PWGENERATOR_NO_ENABLED_ATTR;
-        messages.add(getMessage(msgID, String.valueOf(configEntryDN)));
-        resultCode = ResultCode.SUCCESS;
-        return new ConfigChangeResult(resultCode, adminActionRequired,
-                                      messages);
-      }
-      else if (! enabledAttr.activeValue())
-      {
-        // It is explicitly configured as disabled, so we don't need to do
-        // anything.
-        return new ConfigChangeResult(resultCode, adminActionRequired,
-                                      messages);
-      }
+      passwordGenerator = loadGenerator(className, configuration);
     }
-    catch (Exception e)
+    catch (InitializationException ie)
     {
-      if (debugEnabled())
+      if (resultCode == ResultCode.SUCCESS)
       {
-        debugCaught(DebugLogLevel.ERROR, e);
+        resultCode = DirectoryServer.getServerErrorResultCode();
       }
 
-      int msgID = MSGID_CONFIG_PWGENERATOR_INVALID_ENABLED_VALUE;
-      messages.add(getMessage(msgID, String.valueOf(configEntryDN),
-                              String.valueOf(e)));
-      resultCode = DirectoryServer.getServerErrorResultCode();
-      return new ConfigChangeResult(resultCode, adminActionRequired, messages);
+      messages.add(ie.getMessage());
     }
 
-
-    // Make sure that the entry specifies the generator class name.
-    String className;
-    try
+    if (resultCode == ResultCode.SUCCESS)
     {
-      StringConfigAttribute classStub =
-           new StringConfigAttribute(ATTR_PWGENERATOR_CLASS,
-                    getMessage(MSGID_CONFIG_PWGENERATOR_DESCRIPTION_CLASS_NAME),
-                    true, false, true);
-      StringConfigAttribute classNameAttr =
-           (StringConfigAttribute) configEntry.getConfigAttribute(classStub);
-
-      if (classNameAttr == null)
-      {
-        int msgID = MSGID_CONFIG_PWGENERATOR_NO_CLASS_NAME;
-        messages.add(getMessage(msgID, String.valueOf(configEntryDN)));
-        resultCode = ResultCode.OBJECTCLASS_VIOLATION;
-        return new ConfigChangeResult(resultCode, adminActionRequired,
-                                      messages);
-      }
-
-      className = classNameAttr.pendingValue();
-    }
-    catch (Exception e)
-    {
-      if (debugEnabled())
-      {
-        debugCaught(DebugLogLevel.ERROR, e);
-      }
-
-      int msgID = MSGID_CONFIG_PWGENERATOR_INVALID_CLASS_NAME;
-      messages.add(getMessage(msgID, String.valueOf(configEntryDN),
-                              String.valueOf(e)));
-      resultCode = DirectoryServer.getServerErrorResultCode();
-      return new ConfigChangeResult(resultCode, adminActionRequired, messages);
+      passwordGenerators.put(configuration.dn(), passwordGenerator);
+      DirectoryServer.registerPasswordGenerator(configuration.dn(),
+                                                passwordGenerator);
     }
 
-
-    // Load and initialize the generator class, and register it with the
-    // Directory Server.
-    PasswordGenerator generator;
-    try
-    {
-      Class generatorClass = DirectoryServer.loadClass(className);
-      generator = (PasswordGenerator) generatorClass.newInstance();
-    }
-    catch (Exception e)
-    {
-      if (debugEnabled())
-      {
-        debugCaught(DebugLogLevel.ERROR, e);
-      }
-
-      int msgID = MSGID_CONFIG_PWGENERATOR_INVALID_CLASS;
-      messages.add(getMessage(msgID, className, String.valueOf(configEntryDN),
-                              String.valueOf(e)));
-      resultCode = DirectoryServer.getServerErrorResultCode();
-      return new ConfigChangeResult(resultCode, adminActionRequired, messages);
-    }
-
-    try
-    {
-      generator.initializePasswordGenerator(configEntry);
-    }
-    catch (Exception e)
-    {
-      if (debugEnabled())
-      {
-        debugCaught(DebugLogLevel.ERROR, e);
-      }
-
-      int msgID = MSGID_CONFIG_PWGENERATOR_INITIALIZATION_FAILED;
-      messages.add(getMessage(msgID, className, String.valueOf(configEntryDN),
-                              String.valueOf(e)));
-      resultCode = DirectoryServer.getServerErrorResultCode();
-      return new ConfigChangeResult(resultCode, adminActionRequired, messages);
-    }
-
-
-    passwordGenerators.put(configEntryDN, generator);
-    DirectoryServer.registerPasswordGenerator(configEntryDN, generator);
     return new ConfigChangeResult(resultCode, adminActionRequired, messages);
   }
 
-
-
   /**
-   * Indicates whether it is acceptable to remove the provided configuration
-   * entry.
-   *
-   * @param  configEntry         The configuration entry that will be removed
-   *                             from the configuration.
-   * @param  unacceptableReason  A buffer to which this method can append a
-   *                             human-readable message explaining why the
-   *                             proposed delete is not acceptable.
-   *
-   * @return  <CODE>true</CODE> if the proposed entry may be removed from the
-   *          configuration, or <CODE>false</CODE> if not.
+   * {@inheritDoc}
    */
-  public boolean configDeleteIsAcceptable(ConfigEntry configEntry,
-                                          StringBuilder unacceptableReason)
+  public boolean isConfigurationDeleteAcceptable(
+      PasswordGeneratorCfg configuration, List<String> unacceptableReasons)
   {
     // A delete should always be acceptable, so just return true.
     return true;
   }
 
 
-
   /**
-   * Attempts to apply a new configuration based on the provided deleted entry.
-   *
-   * @param  configEntry  The new configuration entry that has been deleted.
-   *
-   * @return  Information about the result of processing the configuration
-   *          change.
+   * {@inheritDoc}
    */
-  public ConfigChangeResult applyConfigurationDelete(ConfigEntry configEntry)
+  public ConfigChangeResult applyConfigurationDelete(
+      PasswordGeneratorCfg configuration)
   {
-    DN         configEntryDN       = configEntry.getDN();
     ResultCode resultCode          = ResultCode.SUCCESS;
     boolean    adminActionRequired = false;
 
 
     // See if the entry is registered as a password generator.  If so,
     // deregister it and stop the generator.
-    PasswordGenerator generator = passwordGenerators.remove(configEntryDN);
+    PasswordGenerator generator = passwordGenerators.remove(configuration.dn());
     if (generator != null)
     {
-      DirectoryServer.deregisterPasswordGenerator(configEntryDN);
+      DirectoryServer.deregisterPasswordGenerator(configuration.dn());
 
       generator.finalizePasswordGenerator();
     }
@@ -957,5 +355,57 @@
 
     return new ConfigChangeResult(resultCode, adminActionRequired);
   }
+
+  /**
+   * Loads the specified class, instantiates it as a password generator, and
+   * optionally initializes that instance.
+   *
+   * @param  className      The fully-qualified name of the password generator
+   *                        class to load, instantiate, and initialize.
+   * @param  configuration  The configuration to use to initialize the
+   *                        password generator, or {@code null} if the
+   *                        password generator should not be initialized.
+   *
+   * @return  The possibly initialized password validator.
+   *
+   * @throws  InitializationException  If a problem occurred while attempting to
+   *                                   initialize the password generator.
+   */
+  private PasswordGenerator<? extends PasswordGeneratorCfg>
+               loadGenerator(String className,
+                             PasswordGeneratorCfg configuration)
+          throws InitializationException
+  {
+    try
+    {
+      PasswordGeneratorCfgDefn definition =
+           PasswordGeneratorCfgDefn.getInstance();
+      ClassPropertyDefinition propertyDefinition =
+           definition.getGeneratorClassPropertyDefinition();
+      Class<? extends PasswordGenerator> generatorClass =
+           propertyDefinition.loadClass(className, PasswordGenerator.class);
+      PasswordGenerator<? extends PasswordGeneratorCfg> generator =
+           (PasswordGenerator<? extends PasswordGeneratorCfg>)
+           generatorClass.newInstance();
+
+      if (configuration != null)
+      {
+        Method method =
+          generator.getClass().getMethod("initializePasswordGenerator",
+                  configuration.definition().getServerConfigurationClass());
+        method.invoke(generator, configuration);
+      }
+
+      return generator;
+    }
+    catch (Exception e)
+    {
+      int msgID = MSGID_CONFIG_PWGENERATOR_INITIALIZATION_FAILED;
+      String message = getMessage(msgID, className,
+                                  String.valueOf(configuration.dn()),
+                                  stackTraceToSingleLineString(e));
+      throw new InitializationException(msgID, message, e);
+    }
+  }
 }
 

--
Gitblit v1.10.0