From ebb48bfdd8278ab712dc837dade5dc74597bd025 Mon Sep 17 00:00:00 2001
From: Ludovic Poitou <ludovic.poitou@forgerock.com>
Date: Thu, 20 Jan 2011 18:09:24 +0000
Subject: [PATCH] Code cleanup removing potential issues detected by FindBugs
---
opends/src/server/org/opends/server/extensions/FileBasedKeyManagerProvider.java | 11 ++++++++++-
1 files changed, 10 insertions(+), 1 deletions(-)
diff --git a/opends/src/server/org/opends/server/extensions/FileBasedKeyManagerProvider.java b/opends/src/server/org/opends/server/extensions/FileBasedKeyManagerProvider.java
index c7981a8..5bf8caa 100644
--- a/opends/src/server/org/opends/server/extensions/FileBasedKeyManagerProvider.java
+++ b/opends/src/server/org/opends/server/extensions/FileBasedKeyManagerProvider.java
@@ -23,6 +23,7 @@
*
*
* Copyright 2006-2008 Sun Microsystems, Inc.
+ * Portions Copyright 2011 ForgeRock AS
*/
package org.opends.server.extensions;
import org.opends.messages.Message;
@@ -465,7 +466,15 @@
}
else if (configuration.getKeyStorePin() != null)
{
- configuration.getKeyStorePin().toCharArray();
+ String pinStr = configuration.getKeyStorePin();
+ if (pinStr == null)
+ {
+ unacceptableReasons.add(
+ ERR_FILE_KEYMANAGER_CANNOT_DETERMINE_PIN_FROM_ATTR.get(
+ String.valueOf(cfgEntryDN),
+ "null"));
+ configAcceptable = false;
+ }
}
else
{
--
Gitblit v1.10.0