From 7fc458b7be71111b4c4a6e91f7b3ed6642b104a1 Mon Sep 17 00:00:00 2001
From: Chris Ridd <chris.ridd@forgerock.com>
Date: Tue, 16 Jul 2013 14:12:20 +0000
Subject: [PATCH] CR-2005 Fix OPENDJ-1036 Cleanup passwords in memory?
---
opends/src/server/org/opends/server/extensions/SaltedMD5PasswordStorageScheme.java | 26 +++++++++++++++++++++++++-
1 files changed, 25 insertions(+), 1 deletions(-)
diff --git a/opends/src/server/org/opends/server/extensions/SaltedMD5PasswordStorageScheme.java b/opends/src/server/org/opends/server/extensions/SaltedMD5PasswordStorageScheme.java
index 38194f4..baafd41 100644
--- a/opends/src/server/org/opends/server/extensions/SaltedMD5PasswordStorageScheme.java
+++ b/opends/src/server/org/opends/server/extensions/SaltedMD5PasswordStorageScheme.java
@@ -23,6 +23,7 @@
*
*
* Copyright 2006-2008 Sun Microsystems, Inc.
+ * Portions Copyright 2013 ForgeRock AS
*/
package org.opends.server.extensions;
@@ -189,6 +190,10 @@
throw new DirectoryException(DirectoryServer.getServerErrorResultCode(),
message, e);
}
+ finally
+ {
+ Arrays.fill(plainPlusSalt, (byte) 0);
+ }
}
// Append the salt to the hashed value and base64-the whole thing.
@@ -247,6 +252,10 @@
throw new DirectoryException(DirectoryServer.getServerErrorResultCode(),
message, e);
}
+ finally
+ {
+ Arrays.fill(plainPlusSalt, (byte) 0);
+ }
}
// Append the salt to the hashed value and base64-the whole thing.
@@ -320,6 +329,10 @@
return false;
}
+ finally
+ {
+ Arrays.fill(plainPlusSalt, (byte) 0);
+ }
}
return Arrays.equals(digestBytes, userDigestBytes);
@@ -389,6 +402,10 @@
throw new DirectoryException(DirectoryServer.getServerErrorResultCode(),
message, e);
}
+ finally
+ {
+ Arrays.fill(plainPlusSalt, (byte) 0);
+ }
}
@@ -438,8 +455,15 @@
synchronized (digestLock)
{
- return Arrays.equals(digestBytes,
+ try
+ {
+ return Arrays.equals(digestBytes,
messageDigest.digest(plainPlusSaltBytes));
+ }
+ finally
+ {
+ Arrays.fill(plainPlusSaltBytes, (byte) 0);
+ }
}
}
--
Gitblit v1.10.0