From 63a2096d8a12bcf1004d79532201dda28a65c8b5 Mon Sep 17 00:00:00 2001
From: Ludovic Poitou <ludovic.poitou@forgerock.com>
Date: Tue, 03 Jan 2012 16:43:44 +0000
Subject: [PATCH] Fix minor issues and optimizations suggested by FindBugs and NetBeans.

---
 opends/src/server/org/opends/server/protocols/internal/InternalClientConnection.java |   10 +++-------
 1 files changed, 3 insertions(+), 7 deletions(-)

diff --git a/opends/src/server/org/opends/server/protocols/internal/InternalClientConnection.java b/opends/src/server/org/opends/server/protocols/internal/InternalClientConnection.java
index 65c9057..ad159af 100644
--- a/opends/src/server/org/opends/server/protocols/internal/InternalClientConnection.java
+++ b/opends/src/server/org/opends/server/protocols/internal/InternalClientConnection.java
@@ -23,7 +23,7 @@
  *
  *
  *      Copyright 2006-2009 Sun Microsystems, Inc.
- *      Portions copyright 2011 ForgeRock AS
+ *      Portions copyright 2011-2012 ForgeRock AS
  */
 package org.opends.server.protocols.internal;
 
@@ -880,14 +880,10 @@
    */
   public AddOperation processAdd(Entry entry, List<Control> controls)
   {
-    if (controls == null)
-    {
-      controls = new ArrayList<Control>(0);
-    }
-
     return processAdd(entry.getDN(), entry.getObjectClasses(),
                       entry.getUserAttributes(),
-                      entry.getOperationalAttributes());
+                      entry.getOperationalAttributes(),
+                      controls);
   }
 
 

--
Gitblit v1.10.0