From 9ecc918cd499c4ad5ac594c0c0f2a43186996fe8 Mon Sep 17 00:00:00 2001
From: Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Date: Mon, 25 Mar 2013 11:54:15 +0000
Subject: [PATCH] Code cleanup.

---
 opends/src/server/org/opends/server/protocols/internal/InternalClientConnection.java |   87 -------------------------------------------
 1 files changed, 0 insertions(+), 87 deletions(-)

diff --git a/opends/src/server/org/opends/server/protocols/internal/InternalClientConnection.java b/opends/src/server/org/opends/server/protocols/internal/InternalClientConnection.java
index 8fd125e..e276619 100644
--- a/opends/src/server/org/opends/server/protocols/internal/InternalClientConnection.java
+++ b/opends/src/server/org/opends/server/protocols/internal/InternalClientConnection.java
@@ -758,11 +758,6 @@
                                  List<RawAttribute> rawAttributes,
                                  List<Control> controls)
   {
-    if (controls == null)
-    {
-      controls = new ArrayList<Control>(0);
-    }
-
     AddOperationBasis addOperation =
          new AddOperationBasis(this, nextOperationID(),
                           nextMessageID(), controls, rawEntryDN,
@@ -830,11 +825,6 @@
                                 operationalAttributes,
                            List<Control> controls)
   {
-    if (controls == null)
-    {
-      controls = new ArrayList<Control>(0);
-    }
-
     AddOperationBasis addOperation =
          new AddOperationBasis(this, nextOperationID(),
                           nextMessageID(), controls, entryDN,
@@ -1015,11 +1005,6 @@
                                          ByteString password,
                                          List<Control> controls)
   {
-    if (controls == null)
-    {
-      controls = new ArrayList<Control>(0);
-    }
-
     BindOperationBasis bindOperation =
          new BindOperationBasis(this, nextOperationID(),
                            nextMessageID(), controls,
@@ -1069,11 +1054,6 @@
                                          ByteString password,
                                          List<Control> controls)
   {
-    if (controls == null)
-    {
-      controls = new ArrayList<Control>(0);
-    }
-
     BindOperationBasis bindOperation =
          new BindOperationBasis(this, nextOperationID(),
                            nextMessageID(), controls,
@@ -1129,11 +1109,6 @@
                             ByteString saslCredentials,
                             List<Control> controls)
   {
-    if (controls == null)
-    {
-      controls = new ArrayList<Control>(0);
-    }
-
     BindOperationBasis bindOperation =
          new BindOperationBasis(this, nextOperationID(),
                            nextMessageID(), controls,
@@ -1190,11 +1165,6 @@
                             ByteString saslCredentials,
                             List<Control> controls)
   {
-    if (controls == null)
-    {
-      controls = new ArrayList<Control>(0);
-    }
-
     BindOperationBasis bindOperation =
          new BindOperationBasis(this, nextOperationID(),
                            nextMessageID(), controls,
@@ -1307,11 +1277,6 @@
                                          ByteString assertionValue,
                                          List<Control> controls)
   {
-    if (controls == null)
-    {
-      controls = new ArrayList<Control>(0);
-    }
-
     CompareOperationBasis compareOperation =
          new CompareOperationBasis(this, nextOperationID(),
                               nextMessageID(), controls, rawEntryDN,
@@ -1369,11 +1334,6 @@
                                          ByteString assertionValue,
                                          List<Control> controls)
   {
-    if (controls == null)
-    {
-      controls = new ArrayList<Control>(0);
-    }
-
     CompareOperationBasis compareOperation =
          new CompareOperationBasis(this, nextOperationID(),
                               nextMessageID(), controls, entryDN,
@@ -1455,11 +1415,6 @@
   public DeleteOperation processDelete(ByteString rawEntryDN,
                                        List<Control> controls)
   {
-    if (controls == null)
-    {
-      controls = new ArrayList<Control>(0);
-    }
-
     DeleteOperationBasis deleteOperation =
          new DeleteOperationBasis(this, nextOperationID(),
                              nextMessageID(), controls, rawEntryDN);
@@ -1502,11 +1457,6 @@
   public DeleteOperation processDelete(DN entryDN,
                                        List<Control> controls)
   {
-    if (controls == null)
-    {
-      controls = new ArrayList<Control>(0);
-    }
-
     DeleteOperationBasis deleteOperation =
          new DeleteOperationBasis(this, nextOperationID(),
                              nextMessageID(), controls, entryDN);
@@ -1579,11 +1529,6 @@
                                 ByteString requestValue,
                                 List<Control> controls)
   {
-    if (controls == null)
-    {
-      controls = new ArrayList<Control>(0);
-    }
-
     ExtendedOperationBasis extendedOperation =
          new ExtendedOperationBasis(this, nextOperationID(),
                                nextMessageID(), controls, requestOID,
@@ -1682,18 +1627,12 @@
                               List<RawModification> rawModifications,
                               List<Control> controls)
   {
-    if (controls == null)
-    {
-      controls = new ArrayList<Control>(0);
-    }
-
     ModifyOperationBasis modifyOperation =
          new ModifyOperationBasis(this, nextOperationID(),
                              nextMessageID(), controls, rawEntryDN,
                              rawModifications);
     modifyOperation.setInternalOperation(true);
     modifyOperation.run();
-
     return modifyOperation;
   }
 
@@ -1737,18 +1676,12 @@
                               List<Modification> modifications,
                               List<Control> controls)
   {
-    if (controls == null)
-    {
-      controls = new ArrayList<Control>(0);
-    }
-
     ModifyOperationBasis modifyOperation =
          new ModifyOperationBasis(this, nextOperationID(),
                              nextMessageID(), controls, entryDN,
                              modifications);
     modifyOperation.setInternalOperation(true);
     modifyOperation.run();
-
     return modifyOperation;
   }
 
@@ -1961,11 +1894,6 @@
                                            ByteString rawNewSuperior,
                                            List<Control> controls)
   {
-    if (controls == null)
-    {
-      controls = new ArrayList<Control>(0);
-    }
-
     ModifyDNOperationBasis modifyDNOperation =
          new ModifyDNOperationBasis(this, nextOperationID(),
                                nextMessageID(), controls, rawEntryDN,
@@ -2052,11 +1980,6 @@
                                            DN newSuperior,
                                            List<Control> controls)
   {
-    if (controls == null)
-    {
-      controls = new ArrayList<Control>(0);
-    }
-
     ModifyDNOperationBasis modifyDNOperation =
          new ModifyDNOperationBasis(this, nextOperationID(),
                                nextMessageID(), controls, entryDN,
@@ -2408,11 +2331,6 @@
                             List<Control> controls,
                             InternalSearchListener searchListener)
   {
-    if (controls == null)
-    {
-      controls = new ArrayList<Control>(0);
-    }
-
     InternalSearchOperation searchOperation =
          new InternalSearchOperation(this, nextOperationID(),
                                      nextMessageID(), controls,
@@ -2557,11 +2475,6 @@
                             List<Control> controls,
                             InternalSearchListener searchListener)
   {
-    if (controls == null)
-    {
-      controls = new ArrayList<Control>(0);
-    }
-
     InternalSearchOperation searchOperation =
          new InternalSearchOperation(this, nextOperationID(),
                                      nextMessageID(), controls,

--
Gitblit v1.10.0