From 138a3114de9e1b69a16c67f052d01270c05064d6 Mon Sep 17 00:00:00 2001
From: Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Date: Thu, 12 Dec 2013 14:27:12 +0000
Subject: [PATCH] Code cleanup in the virtual attributes.
---
opends/src/server/org/opends/server/replication/common/ChangelogBaseDNVirtualAttributeProvider.java | 87 +++++++------------------------------------
1 files changed, 15 insertions(+), 72 deletions(-)
diff --git a/opends/src/server/org/opends/server/replication/common/ChangelogBaseDNVirtualAttributeProvider.java b/opends/src/server/org/opends/server/replication/common/ChangelogBaseDNVirtualAttributeProvider.java
index 3e52f48..23a6cfe 100644
--- a/opends/src/server/org/opends/server/replication/common/ChangelogBaseDNVirtualAttributeProvider.java
+++ b/opends/src/server/org/opends/server/replication/common/ChangelogBaseDNVirtualAttributeProvider.java
@@ -23,7 +23,7 @@
*
*
* Copyright 2009 Sun Microsystems, Inc.
- * Portions Copyright 2011-2012 ForgeRock AS
+ * Portions Copyright 2011-2013 ForgeRock AS
*/
package org.opends.server.replication.common;
@@ -31,24 +31,15 @@
import java.util.List;
import java.util.Set;
-import static org.opends.messages.ExtensionMessages.*;
import org.opends.messages.Message;
import org.opends.server.admin.server.ConfigurationChangeListener;
import org.opends.server.admin.std.server.UserDefinedVirtualAttributeCfg;
import org.opends.server.api.VirtualAttributeProvider;
-import org.opends.server.config.ConfigException;
import org.opends.server.core.SearchOperation;
-import org.opends.server.types.AttributeValue;
-import org.opends.server.types.AttributeValues;
-import org.opends.server.types.ByteString;
-import org.opends.server.types.ConfigChangeResult;
-import org.opends.server.types.Entry;
-import org.opends.server.types.InitializationException;
-import org.opends.server.types.ResultCode;
-import org.opends.server.types.VirtualAttributeRule;
+import org.opends.server.types.*;
import org.opends.server.util.ServerConstants;
-
+import static org.opends.messages.ExtensionMessages.*;
/**
* This class implements a virtual attribute provider that specifies the
@@ -59,7 +50,7 @@
implements ConfigurationChangeListener<UserDefinedVirtualAttributeCfg>
{
- /*
+ /**
* The base DN of the changelog is a constant.
* TODO: This shouldn't be a virtual attribute, but directly
* registered in the RootDSE.
@@ -74,64 +65,26 @@
{
super();
- AttributeValue value =
- AttributeValues.create(
- ByteString.valueOf(ServerConstants.DN_EXTERNAL_CHANGELOG_ROOT),
- ByteString.valueOf(ServerConstants.DN_EXTERNAL_CHANGELOG_ROOT));
- values=Collections.singleton(value);
+ ByteString dn =
+ ByteString.valueOf(ServerConstants.DN_EXTERNAL_CHANGELOG_ROOT);
+ values = Collections.singleton(AttributeValues.create(dn, dn));
}
-
-
- /**
- * {@inheritDoc}
- */
- @Override()
- public void initializeVirtualAttributeProvider(
- UserDefinedVirtualAttributeCfg configuration)
- throws ConfigException, InitializationException
- {
- // No initialization required
- }
-
-
-
- /**
- * {@inheritDoc}
- */
- @Override()
- public void finalizeVirtualAttributeProvider()
- {
- //
- }
-
-
-
- /**
- * {@inheritDoc}
- */
+ /** {@inheritDoc} */
@Override()
public boolean isMultiValued()
{
return false;
}
-
-
- /**
- * {@inheritDoc}
- */
+ /** {@inheritDoc} */
@Override()
public Set<AttributeValue> getValues(Entry entry,VirtualAttributeRule rule)
{
return values;
}
-
-
- /**
- * {@inheritDoc}
- */
+ /** {@inheritDoc} */
@Override()
public boolean isSearchable(VirtualAttributeRule rule,
SearchOperation searchOperation,
@@ -141,11 +94,7 @@
return false;
}
-
-
- /**
- * {@inheritDoc}
- */
+ /** {@inheritDoc} */
@Override()
public void processSearch(VirtualAttributeRule rule,
SearchOperation searchOperation)
@@ -156,11 +105,8 @@
searchOperation.appendErrorMessage(message);
}
-
-
- /**
- * {@inheritDoc}
- */
+ /** {@inheritDoc} */
+ @Override
public boolean isConfigurationChangeAcceptable(
UserDefinedVirtualAttributeCfg configuration,
List<Message> unacceptableReasons)
@@ -168,11 +114,8 @@
return false;
}
-
-
- /**
- * {@inheritDoc}
- */
+ /** {@inheritDoc} */
+ @Override
public ConfigChangeResult applyConfigurationChange(
UserDefinedVirtualAttributeCfg configuration)
{
--
Gitblit v1.10.0