From 0c830d1e70d669a3cbab8a9de424f96e2b6d8982 Mon Sep 17 00:00:00 2001
From: Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Date: Thu, 27 Jun 2013 13:58:43 +0000
Subject: [PATCH] *.java: More javadoc/code cleanup. Switched (excluded)serviceIDs/excludedDomains from List to Set.
---
opends/src/server/org/opends/server/replication/common/LastCookieVirtualProvider.java | 24 ++++++++----------------
1 files changed, 8 insertions(+), 16 deletions(-)
diff --git a/opends/src/server/org/opends/server/replication/common/LastCookieVirtualProvider.java b/opends/src/server/org/opends/server/replication/common/LastCookieVirtualProvider.java
index 6766286..bc5abe1 100644
--- a/opends/src/server/org/opends/server/replication/common/LastCookieVirtualProvider.java
+++ b/opends/src/server/org/opends/server/replication/common/LastCookieVirtualProvider.java
@@ -23,18 +23,17 @@
*
*
* Copyright 2009 Sun Microsystems, Inc.
- * Portions Copyright 2011-2012 ForgeRock AS
+ * Portions Copyright 2011-2013 ForgeRock AS
*/
-
package org.opends.server.replication.common;
-import java.util.ArrayList;
+import static org.opends.messages.ExtensionMessages.*;
+
import java.util.Collections;
import java.util.HashSet;
import java.util.List;
import java.util.Set;
-import static org.opends.messages.ExtensionMessages.*;
import org.opends.messages.Message;
import org.opends.server.admin.server.ConfigurationChangeListener;
import org.opends.server.admin.std.server.UserDefinedVirtualAttributeCfg;
@@ -44,14 +43,7 @@
import org.opends.server.core.SearchOperation;
import org.opends.server.replication.plugin.MultimasterReplication;
import org.opends.server.replication.server.ReplicationServer;
-import org.opends.server.types.AttributeValue;
-import org.opends.server.types.AttributeValues;
-import org.opends.server.types.ByteString;
-import org.opends.server.types.ConfigChangeResult;
-import org.opends.server.types.Entry;
-import org.opends.server.types.InitializationException;
-import org.opends.server.types.ResultCode;
-import org.opends.server.types.VirtualAttributeRule;
+import org.opends.server.types.*;
import org.opends.server.util.ServerConstants;
import org.opends.server.workflowelement.externalchangelog.ECLWorkflowElement;
@@ -136,11 +128,9 @@
if (eclwe!=null)
{
// Set a list of excluded domains (also exclude 'cn=changelog' itself)
- ArrayList<String> excludedDomains =
+ Set<String> excludedDomains =
MultimasterReplication.getECLDisabledDomains();
- if (!excludedDomains.contains(
- ServerConstants.DN_EXTERNAL_CHANGELOG_ROOT))
- excludedDomains.add(ServerConstants.DN_EXTERNAL_CHANGELOG_ROOT);
+ excludedDomains.add(ServerConstants.DN_EXTERNAL_CHANGELOG_ROOT);
ReplicationServer rs = eclwe.getReplicationServer();
MultiDomainServerState lastCookie =
@@ -193,6 +183,7 @@
/**
* {@inheritDoc}
*/
+ @Override
public boolean isConfigurationChangeAcceptable(
UserDefinedVirtualAttributeCfg configuration,
List<Message> unacceptableReasons)
@@ -205,6 +196,7 @@
/**
* {@inheritDoc}
*/
+ @Override
public ConfigChangeResult applyConfigurationChange(
UserDefinedVirtualAttributeCfg configuration)
{
--
Gitblit v1.10.0