From dc7e0efd09b538b9ed21a414dff79fb1cf6f2d64 Mon Sep 17 00:00:00 2001
From: neil_a_wilson <neil_a_wilson@localhost>
Date: Thu, 17 May 2007 22:02:02 +0000
Subject: [PATCH] Perform miscellaneous cleanup from bugs and other potential problems found by FindBugs

---
 opends/src/server/org/opends/server/replication/common/ServerState.java |   10 ++++++----
 1 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/opends/src/server/org/opends/server/replication/common/ServerState.java b/opends/src/server/org/opends/server/replication/common/ServerState.java
index 38fd50d..1b5f36a 100644
--- a/opends/src/server/org/opends/server/replication/common/ServerState.java
+++ b/opends/src/server/org/opends/server/replication/common/ServerState.java
@@ -221,17 +221,19 @@
   @Override
   public String toString()
   {
+    StringBuilder buffer = new StringBuilder();
+
     synchronized (this)
     {
-      String str = null;
       for (Short key  : list.keySet())
       {
         ChangeNumber change = list.get(key);
-        str += " " + change.toString();
+        buffer.append(" ");
+        buffer.append(change);
       }
-
-      return str;
     }
+
+    return buffer.toString();
   }
 
   /**

--
Gitblit v1.10.0