From 5e2e412e8dfc3d21be9f96ec88e05962c33fdf9a Mon Sep 17 00:00:00 2001
From: Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Date: Tue, 06 Aug 2013 12:49:35 +0000
Subject: [PATCH] ECLServerHandler.java: Extracted method findCookie() and use the early exit technique to make the code hopefully easier to read. Also removed useless comments. Used DraftCNDbHandler.isEmpty(). Made several methods private.
---
opends/src/server/org/opends/server/replication/server/DraftCNDbHandler.java | 16 ++++++++++++++++
1 files changed, 16 insertions(+), 0 deletions(-)
diff --git a/opends/src/server/org/opends/server/replication/server/DraftCNDbHandler.java b/opends/src/server/org/opends/server/replication/server/DraftCNDbHandler.java
index 8805dda..75241cf 100644
--- a/opends/src/server/org/opends/server/replication/server/DraftCNDbHandler.java
+++ b/opends/src/server/org/opends/server/replication/server/DraftCNDbHandler.java
@@ -178,6 +178,22 @@
}
/**
+ * Returns whether this database is empty.
+ * <p>
+ * FIXME Find a way to implement this method in a more efficient manner.
+ * {@link Database#count()} javadoc mentions: <blockquote>Note that this
+ * method does scan a significant portion of the database and should be
+ * considered a fairly expensive operation.</blockquote>
+ *
+ * @return <code>true</code> if this database is empty, <code>false</code>
+ * otherwise
+ */
+ public boolean isEmpty()
+ {
+ return count() == 0;
+ }
+
+ /**
* Get a read cursor on the database from a provided key.
* The cursor MUST be released after use.
* @param key The provided key.
--
Gitblit v1.10.0