From 20407f942c7c974ab44d5064241784f0937bfdb6 Mon Sep 17 00:00:00 2001
From: Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Date: Thu, 19 Sep 2013 10:57:42 +0000
Subject: [PATCH] ECLServerHandler.java: In findCookie(), reverted an if statement to use an early exit in case of error. It improves readability by making this code consistent with the other code in this method.
---
opends/src/server/org/opends/server/replication/server/ECLServerHandler.java | 14 +++++++-------
1 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/opends/src/server/org/opends/server/replication/server/ECLServerHandler.java b/opends/src/server/org/opends/server/replication/server/ECLServerHandler.java
index 9734c48..99a4e8b 100644
--- a/opends/src/server/org/opends/server/replication/server/ECLServerHandler.java
+++ b/opends/src/server/org/opends/server/replication/server/ECLServerHandler.java
@@ -613,16 +613,16 @@
if (startChangeNumber < firstChangeNumber)
{
CNIndexRecord firstCNRecord = cnIndexDB.getRecord(firstChangeNumber);
- if (firstCNRecord != null)
+ if (firstCNRecord == null)
{
- final String crossDomainStartState = firstCNRecord.getPreviousCookie();
- cnIndexDBCursor = cnIndexDB.getCursorFrom(firstChangeNumber);
- return crossDomainStartState;
+ // This should not happen
+ isEndOfCNIndexDBReached = true;
+ return null;
}
- // This should not happen
- isEndOfCNIndexDBReached = true;
- return null;
+ final String crossDomainStartState = firstCNRecord.getPreviousCookie();
+ cnIndexDBCursor = cnIndexDB.getCursorFrom(firstChangeNumber);
+ return crossDomainStartState;
}
else if (startChangeNumber <= lastChangeNumber)
{
--
Gitblit v1.10.0