From 15a0d1142e68d860e17f0b3dd130d5c44d4dd9f2 Mon Sep 17 00:00:00 2001
From: Ludovic Poitou <ludovic.poitou@forgerock.com>
Date: Sat, 22 Sep 2012 12:21:06 +0000
Subject: [PATCH] Code cleanup after running Findbugs. Remove useless initializations, useless toString() on strings, and other redundant if tests...

---
 opends/src/server/org/opends/server/replication/server/ECLServerWriter.java |   21 ++++++++-------------
 1 files changed, 8 insertions(+), 13 deletions(-)

diff --git a/opends/src/server/org/opends/server/replication/server/ECLServerWriter.java b/opends/src/server/org/opends/server/replication/server/ECLServerWriter.java
index 447fc40..9f87191 100644
--- a/opends/src/server/org/opends/server/replication/server/ECLServerWriter.java
+++ b/opends/src/server/org/opends/server/replication/server/ECLServerWriter.java
@@ -23,7 +23,7 @@
  *
  *
  *      Copyright 2009 Sun Microsystems, Inc.
- *      Portions copyright 2011 ForgeRock AS
+ *      Portions copyright 2011-2012 ForgeRock AS
  */
 package org.opends.server.replication.server;
 import static org.opends.messages.ReplicationMessages.*;
@@ -234,19 +234,14 @@
         return;
       }
 
-      // TODO:ECL please document the details of the cases where update could
-      // be not null here
-      if (update == null)
+      try
       {
-        try
-        {
-          handler.refreshEligibleCN();
-          update = handler.takeECLUpdate();
-        }
-        catch(DirectoryException de)
-        {
-          TRACER.debugCaught(DebugLogLevel.ERROR, de);
-        }
+        handler.refreshEligibleCN();
+        update = handler.takeECLUpdate();
+      }
+      catch(DirectoryException de)
+      {
+        TRACER.debugCaught(DebugLogLevel.ERROR, de);
       }
 
       if (update == null)

--
Gitblit v1.10.0