From 15a0d1142e68d860e17f0b3dd130d5c44d4dd9f2 Mon Sep 17 00:00:00 2001
From: Ludovic Poitou <ludovic.poitou@forgerock.com>
Date: Sat, 22 Sep 2012 12:21:06 +0000
Subject: [PATCH] Code cleanup after running Findbugs. Remove useless initializations, useless toString() on strings, and other redundant if tests...
---
opends/src/server/org/opends/server/replication/server/MonitorData.java | 37 +++++++++++++++++++++++++++----------
1 files changed, 27 insertions(+), 10 deletions(-)
diff --git a/opends/src/server/org/opends/server/replication/server/MonitorData.java b/opends/src/server/org/opends/server/replication/server/MonitorData.java
index 1bee7d7..d894aec 100644
--- a/opends/src/server/org/opends/server/replication/server/MonitorData.java
+++ b/opends/src/server/org/opends/server/replication/server/MonitorData.java
@@ -23,6 +23,7 @@
*
*
* Copyright 2009-2010 Sun Microsystems, Inc.
+ * Portions Copyright 2012 ForgeRock AS
*/
package org.opends.server.replication.server;
@@ -179,9 +180,12 @@
int missingChangesLsiLsj =
ChangeNumber.diffSeqNum(lsjMaxCN, lsiLastCN);
- mds +=
- "+ diff("+lsjMaxCN+"-"
- +lsiLastCN+")="+missingChangesLsiLsj;
+ if (debugEnabled())
+ {
+ mds +=
+ "+ diff("+lsjMaxCN+"-"
+ +lsiLastCN+")="+missingChangesLsiLsj;
+ }
// Regarding a DS that is generating changes. If it is a local DS1,
// we get its server state, store it, then retrieve server states of
@@ -197,14 +201,20 @@
if (missingChangesLsiLsj <= 50)
{
missingChangesLsiLsj = 0;
- mds += " (diff replaced by 0 as for server id " + lsiSid + ")";
+ if (debugEnabled())
+ {
+ mds += " (diff replaced by 0 as for server id " + lsiSid + ")";
+ }
}
}
lsiMissingChanges += missingChangesLsiLsj;
}
}
- mds += "=" + lsiMissingChanges;
+ if (debugEnabled())
+ {
+ mds += "=" + lsiMissingChanges;
+ }
this.missingChanges.put(lsiSid,lsiMissingChanges);
}
@@ -227,19 +237,26 @@
int missingChangesLsiLsj =
ChangeNumber.diffSeqNum(lsjMaxCN, lsiLastCN);
- mds +=
- "+ diff("+lsjMaxCN+"-"
- +lsiLastCN+")="+missingChangesLsiLsj;
-
+ if (debugEnabled())
+ {
+ mds +=
+ "+ diff("+lsjMaxCN+"-"
+ +lsiLastCN+")="+missingChangesLsiLsj;
+ }
lsiMissingChanges += missingChangesLsiLsj;
}
}
- mds += "=" + lsiMissingChanges;
+ if (debugEnabled())
+ {
+ mds += "=" + lsiMissingChanges;
+ }
this.missingChangesRS.put(lsiSid,lsiMissingChanges);
if (debugEnabled())
+ {
TRACER.debugInfo(
"Complete monitor data : Missing changes ("+ lsiSid +")=" + mds);
+ }
}
}
--
Gitblit v1.10.0