From 667d7253a3873ed64dafbffe39d8a84a298c1fdc Mon Sep 17 00:00:00 2001
From: Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Date: Mon, 28 Apr 2014 10:57:22 +0000
Subject: [PATCH] Code cleanup: - Increased MessageHandler encapsulation. - Removed ServerHandler.closeSession() because it is adding unnecessary complexity in understanding calling sites.

---
 opends/src/server/org/opends/server/replication/server/ReplicationServer.java |    9 ++++-----
 1 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/opends/src/server/org/opends/server/replication/server/ReplicationServer.java b/opends/src/server/org/opends/server/replication/server/ReplicationServer.java
index a765e8c..53628b0 100644
--- a/opends/src/server/org/opends/server/replication/server/ReplicationServer.java
+++ b/opends/src/server/org/opends/server/replication/server/ReplicationServer.java
@@ -261,7 +261,7 @@
           // We did not recognize the message, close session as what
           // can happen after is undetermined and we do not want the server to
           // be disturbed
-          ServerHandler.closeSession(session, null, null);
+          session.close();
           return;
         }
       }
@@ -275,10 +275,9 @@
         {
           TRACER.debugCaught(DebugLogLevel.ERROR, e);
         }
-        if (!shutdown) {
-          Message message =
-            ERR_EXCEPTION_LISTENING.get(e.getLocalizedMessage());
-          logError(message);
+        if (!shutdown)
+        {
+          logError(ERR_EXCEPTION_LISTENING.get(e.getLocalizedMessage()));
         }
       }
     }

--
Gitblit v1.10.0