From 1f3592b4ab0a329ed8e54e311b89d2bca68efb81 Mon Sep 17 00:00:00 2001
From: neil_a_wilson <neil_a_wilson@localhost>
Date: Fri, 21 Sep 2007 00:49:05 +0000
Subject: [PATCH] Update a number of result codes to make the values more consistent across operations.  Also, eliminate a number of incorrect uses of the OPERATIONS_ERROR result and replace them with the more correct OTHER result.

---
 opends/src/server/org/opends/server/tools/dsconfig/CreateSubCommandHandler.java |   14 +++++++-------
 1 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/opends/src/server/org/opends/server/tools/dsconfig/CreateSubCommandHandler.java b/opends/src/server/org/opends/server/tools/dsconfig/CreateSubCommandHandler.java
index 1671991..b303f19 100644
--- a/opends/src/server/org/opends/server/tools/dsconfig/CreateSubCommandHandler.java
+++ b/opends/src/server/org/opends/server/tools/dsconfig/CreateSubCommandHandler.java
@@ -497,16 +497,16 @@
                 LDAPResultCode.INSUFFICIENT_ACCESS_RIGHTS, msg);
           } catch (DefinitionDecodingException e) {
             Message msg = ERR_DSCFG_ERROR_GET_CHILD_DDE.get(rufn, rufn, rufn);
-            throw new ClientException(LDAPResultCode.OPERATIONS_ERROR, msg);
+            throw new ClientException(LDAPResultCode.OTHER, msg);
           } catch (ManagedObjectDecodingException e) {
             // FIXME: should not abort here. Instead, display the
             // errors (if verbose) and apply the changes to the
             // partial managed object.
             Message msg = ERR_DSCFG_ERROR_GET_CHILD_MODE.get(rufn);
-            throw new ClientException(LDAPResultCode.OPERATIONS_ERROR, msg, e);
+            throw new ClientException(LDAPResultCode.OTHER, msg, e);
           } catch (CommunicationException e) {
             Message msg = ERR_DSCFG_ERROR_CREATE_CE.get(ufn, e.getMessage());
-            throw new ClientException(LDAPResultCode.OPERATIONS_ERROR, msg);
+            throw new ClientException(LDAPResultCode.OTHER, msg);
           } catch (ManagedObjectNotFoundException e) {
             Message msg = ERR_DSCFG_ERROR_GET_CHILD_MONFE.get(rufn);
             throw new ClientException(LDAPResultCode.NO_SUCH_OBJECT, msg);
@@ -567,7 +567,7 @@
               } catch (CommunicationException e) {
                 Message msg = ERR_DSCFG_ERROR_CREATE_CE
                     .get(ufn, e.getMessage());
-                throw new ClientException(LDAPResultCode.OPERATIONS_ERROR, msg);
+                throw new ClientException(LDAPResultCode.OTHER, msg);
               } catch (ManagedObjectAlreadyExistsException e) {
                 // Should never happen.
                 throw new IllegalStateException(e);
@@ -696,7 +696,7 @@
         }
       } catch (CommunicationException e) {
         Message msg = ERR_DSCFG_ERROR_CREATE_CE.get(ufn, e.getMessage());
-        throw new ClientException(LDAPResultCode.OPERATIONS_ERROR, msg);
+        throw new ClientException(LDAPResultCode.OTHER, msg);
       } catch (ManagedObjectAlreadyExistsException e) {
         Message msg = ERR_DSCFG_ERROR_CREATE_MOAEE.get(ufn);
         throw new ClientException(LDAPResultCode.ENTRY_ALREADY_EXISTS, msg);
@@ -1072,11 +1072,11 @@
     } catch (DefinitionDecodingException e) {
       Message pufn = path.getManagedObjectDefinition().getUserFriendlyName();
       Message msg = ERR_DSCFG_ERROR_GET_PARENT_DDE.get(pufn, pufn, pufn);
-      throw new ClientException(LDAPResultCode.OPERATIONS_ERROR, msg);
+      throw new ClientException(LDAPResultCode.OTHER, msg);
     } catch (ManagedObjectDecodingException e) {
       Message pufn = path.getManagedObjectDefinition().getUserFriendlyName();
       Message msg = ERR_DSCFG_ERROR_GET_PARENT_MODE.get(pufn);
-      throw new ClientException(LDAPResultCode.OPERATIONS_ERROR, msg, e);
+      throw new ClientException(LDAPResultCode.OTHER, msg, e);
     } catch (CommunicationException e) {
       Message msg = ERR_DSCFG_ERROR_CREATE_CE.get(ufn, e
           .getMessage());

--
Gitblit v1.10.0