From 55b437508acb80b4931a5d7f37b987adf367fa46 Mon Sep 17 00:00:00 2001
From: Ludovic Poitou <ludovic.poitou@forgerock.com>
Date: Thu, 05 Jan 2012 17:37:33 +0000
Subject: [PATCH] Spring cleaning ! Fix minor issues and optimizations suggested by FindBugs and NetBeans.
---
opends/src/server/org/opends/server/tools/tasks/TaskTool.java | 11 +++++++++--
1 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/opends/src/server/org/opends/server/tools/tasks/TaskTool.java b/opends/src/server/org/opends/server/tools/tasks/TaskTool.java
index 7c3e5af..9e4240e 100644
--- a/opends/src/server/org/opends/server/tools/tasks/TaskTool.java
+++ b/opends/src/server/org/opends/server/tools/tasks/TaskTool.java
@@ -23,6 +23,7 @@
*
*
* Copyright 2007-2010 Sun Microsystems, Inc.
+ * Portions Copyright 2012 ForgeRock AS
*/
package org.opends.server.tools.tasks;
@@ -98,7 +99,7 @@
private BooleanArgument testIfOfflineArg;
// This CLI is always using the administration connector with SSL
- private final boolean alwaysSSL = true;
+ private static final boolean alwaysSSL = true;
/**
* Called when this utility should perform its actions locally in this
@@ -191,6 +192,7 @@
/**
* {@inheritDoc}
*/
+ @Override
public Date getStartDateTime() {
return taskScheduleArgs.getStartDateTime();
}
@@ -198,6 +200,7 @@
/**
* {@inheritDoc}
*/
+ @Override
public String getRecurringDateTime() {
return taskScheduleArgs.getRecurringDateTime();
}
@@ -205,6 +208,7 @@
/**
* {@inheritDoc}
*/
+ @Override
public List<String> getDependencyIds() {
return taskScheduleArgs.getDependencyIds();
}
@@ -212,6 +216,7 @@
/**
* {@inheritDoc}
*/
+ @Override
public FailedDependencyAction getFailedDependencyAction() {
return taskScheduleArgs.getFailedDependencyAction();
}
@@ -219,6 +224,7 @@
/**
* {@inheritDoc}
*/
+ @Override
public List<String> getNotifyUponCompletionEmailAddresses() {
return taskScheduleArgs.getNotifyUponCompletionEmailAddresses();
}
@@ -226,6 +232,7 @@
/**
* {@inheritDoc}
*/
+ @Override
public List<String> getNotifyUponErrorEmailAddresses() {
return taskScheduleArgs.getNotifyUponErrorEmailAddresses();
}
@@ -344,7 +351,7 @@
}
ret = 0;
} catch (LDAPConnectionException e) {
- Message message = null;
+ Message message;
if (isWrongPortException(e,
new Integer(argParser.getArguments().getPort())))
{
--
Gitblit v1.10.0