From 76b96928a3b704a542482c63b93927ff449b1b5f Mon Sep 17 00:00:00 2001
From: Ludovic Poitou <ludovic.poitou@forgerock.com>
Date: Fri, 21 Jan 2011 08:44:18 +0000
Subject: [PATCH] Code cleanup removing potential issues detected by FindBugs
---
opends/src/server/org/opends/server/util/cli/LDAPConnectionConsoleInteraction.java | 10 +++++++++-
1 files changed, 9 insertions(+), 1 deletions(-)
diff --git a/opends/src/server/org/opends/server/util/cli/LDAPConnectionConsoleInteraction.java b/opends/src/server/org/opends/server/util/cli/LDAPConnectionConsoleInteraction.java
index f266ad8..4239669 100644
--- a/opends/src/server/org/opends/server/util/cli/LDAPConnectionConsoleInteraction.java
+++ b/opends/src/server/org/opends/server/util/cli/LDAPConnectionConsoleInteraction.java
@@ -23,6 +23,7 @@
*
*
* Copyright 2008-2010 Sun Microsystems, Inc.
+ * Portions Copyright 2011 ForgeRock AS
*/
package org.opends.server.util.cli;
@@ -1150,7 +1151,14 @@
copySecureArgsList.keyStorePathArg.addValue(keystorePath);
commandBuilder.addArgument(copySecureArgsList.keyStorePathArg);
}
-
+ else
+ {
+ // KeystorePath is null. Either it's unspecified or there's a pb
+ // We should throw an exception here, anyway since code below will
+ // anyway
+ throw ArgumentExceptionFactory
+ .incompatiblePropertyModification("null keystorePath");
+ }
// Then the keystore password.
keystorePassword = secureArgsList.keyStorePasswordArg.getValue();
--
Gitblit v1.10.0