From 4bb3d3af3d032a98f2ca318c81be5c4f81034b8f Mon Sep 17 00:00:00 2001
From: Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Date: Fri, 11 Oct 2013 12:27:16 +0000
Subject: [PATCH] ReplicationBroker.java: In computeInitialServerStatus(), used early exits. In computeBestServerForWeight(), extracted methods computeBestServerWhenNotConnected() and computeBestServerWhenConnected(). Changed replicationServerUrls from Collection<String> to Set<String>. Removed useless field initialization to null. Renamed _publish() to publish() + reduced local variables scope. In receive(), renamed local variable replicationServerID to previousRsServerID and used this one more rather than the field. In changeConfig(), used Set.equals(). Changed getReplicationMonitor() to getReplicationMonitorInstanceName().

---
 opends/tests/unit-tests-testng/src/server/org/opends/server/TestCaseUtils.java |   16 ++++++++++++++++
 1 files changed, 16 insertions(+), 0 deletions(-)

diff --git a/opends/tests/unit-tests-testng/src/server/org/opends/server/TestCaseUtils.java b/opends/tests/unit-tests-testng/src/server/org/opends/server/TestCaseUtils.java
index 0a20a5d..67ee569 100644
--- a/opends/tests/unit-tests-testng/src/server/org/opends/server/TestCaseUtils.java
+++ b/opends/tests/unit-tests-testng/src/server/org/opends/server/TestCaseUtils.java
@@ -1922,4 +1922,20 @@
     dsconfig("set-backend-prop", "--backend-name", backendID,
              "--set", "enabled:" + enabled);
   }
+
+  public static <T> Set<T> newSet(T... elems)
+  {
+    return new HashSet<T>(Arrays.asList(elems));
+  }
+
+  public static <T> SortedSet<T> newSortedSet(T... elems)
+  {
+    return new TreeSet<T>(Arrays.asList(elems));
+  }
+
+  public static <T> List<T> newList(T... elems)
+  {
+    return new ArrayList<T>(Arrays.asList(elems));
+  }
+
 }

--
Gitblit v1.10.0