From bb40b9a02cf40af0349d8e3576f51133d264d4b1 Mon Sep 17 00:00:00 2001
From: neil_a_wilson <neil_a_wilson@localhost>
Date: Tue, 10 Oct 2006 15:23:18 +0000
Subject: [PATCH] Make all of the plugin result objects immutable, and create a default SUCCESS instance for each of them that may be used if all processing completed successfully.  Update all uses of the plugin result objects to use this SUCCESS instance where applicable.

---
 opends/tests/unit-tests-testng/src/server/org/opends/server/plugins/InvocationCounterPlugin.java |   88 ++++++++++++++++++++++----------------------
 1 files changed, 44 insertions(+), 44 deletions(-)

diff --git a/opends/tests/unit-tests-testng/src/server/org/opends/server/plugins/InvocationCounterPlugin.java b/opends/tests/unit-tests-testng/src/server/org/opends/server/plugins/InvocationCounterPlugin.java
index ede844b..d92a482 100644
--- a/opends/tests/unit-tests-testng/src/server/org/opends/server/plugins/InvocationCounterPlugin.java
+++ b/opends/tests/unit-tests-testng/src/server/org/opends/server/plugins/InvocationCounterPlugin.java
@@ -133,7 +133,7 @@
        doPreParse(PreParseAbandonOperation abandonOperation)
   {
     preParseCounter.incrementAndGet();
-    return new PreParsePluginResult();
+    return PreParsePluginResult.SUCCESS;
   }
 
 
@@ -145,7 +145,7 @@
   public PreParsePluginResult doPreParse(PreParseAddOperation addOperation)
   {
     preParseCounter.incrementAndGet();
-    return new PreParsePluginResult();
+    return PreParsePluginResult.SUCCESS;
   }
 
 
@@ -157,7 +157,7 @@
   public PreParsePluginResult doPreParse(PreParseBindOperation bindOperation)
   {
     preParseCounter.incrementAndGet();
-    return new PreParsePluginResult();
+    return PreParsePluginResult.SUCCESS;
   }
 
 
@@ -170,7 +170,7 @@
        doPreParse(PreParseCompareOperation compareOperation)
   {
     preParseCounter.incrementAndGet();
-    return new PreParsePluginResult();
+    return PreParsePluginResult.SUCCESS;
   }
 
 
@@ -183,7 +183,7 @@
        doPreParse(PreParseDeleteOperation deleteOperation)
   {
     preParseCounter.incrementAndGet();
-    return new PreParsePluginResult();
+    return PreParsePluginResult.SUCCESS;
   }
 
 
@@ -196,7 +196,7 @@
        doPreParse(PreParseExtendedOperation extendedOperation)
   {
     preParseCounter.incrementAndGet();
-    return new PreParsePluginResult();
+    return PreParsePluginResult.SUCCESS;
   }
 
 
@@ -209,7 +209,7 @@
        doPreParse(PreParseModifyOperation modifyOperation)
   {
     preParseCounter.incrementAndGet();
-    return new PreParsePluginResult();
+    return PreParsePluginResult.SUCCESS;
   }
 
 
@@ -222,7 +222,7 @@
        doPreParse(PreParseModifyDNOperation modifyDNOperation)
   {
     preParseCounter.incrementAndGet();
-    return new PreParsePluginResult();
+    return PreParsePluginResult.SUCCESS;
   }
 
 
@@ -235,7 +235,7 @@
        doPreParse(PreParseSearchOperation searchOperation)
   {
     preParseCounter.incrementAndGet();
-    return new PreParsePluginResult();
+    return PreParsePluginResult.SUCCESS;
   }
 
 
@@ -248,7 +248,7 @@
        doPreParse(PreParseUnbindOperation unbindOperation)
   {
     preParseCounter.incrementAndGet();
-    return new PreParsePluginResult();
+    return PreParsePluginResult.SUCCESS;
   }
 
 
@@ -287,7 +287,7 @@
        doPreOperation(PreOperationAddOperation addOperation)
   {
     preOperationCounter.incrementAndGet();
-    return new PreOperationPluginResult();
+    return PreOperationPluginResult.SUCCESS;
   }
 
 
@@ -300,7 +300,7 @@
        doPreOperation(PreOperationBindOperation bindOperation)
   {
     preOperationCounter.incrementAndGet();
-    return new PreOperationPluginResult();
+    return PreOperationPluginResult.SUCCESS;
   }
 
 
@@ -313,7 +313,7 @@
        doPreOperation(PreOperationCompareOperation compareOperation)
   {
     preOperationCounter.incrementAndGet();
-    return new PreOperationPluginResult();
+    return PreOperationPluginResult.SUCCESS;
   }
 
 
@@ -326,7 +326,7 @@
        doPreOperation(PreOperationDeleteOperation deleteOperation)
   {
     preOperationCounter.incrementAndGet();
-    return new PreOperationPluginResult();
+    return PreOperationPluginResult.SUCCESS;
   }
 
 
@@ -339,7 +339,7 @@
        doPreOperation(PreOperationExtendedOperation extendedOperation)
   {
     preOperationCounter.incrementAndGet();
-    return new PreOperationPluginResult();
+    return PreOperationPluginResult.SUCCESS;
   }
 
 
@@ -352,7 +352,7 @@
        doPreOperation(PreOperationModifyOperation modifyOperation)
   {
     preOperationCounter.incrementAndGet();
-    return new PreOperationPluginResult();
+    return PreOperationPluginResult.SUCCESS;
   }
 
 
@@ -365,7 +365,7 @@
        doPreOperation(PreOperationModifyDNOperation modifyDNOperation)
   {
     preOperationCounter.incrementAndGet();
-    return new PreOperationPluginResult();
+    return PreOperationPluginResult.SUCCESS;
   }
 
 
@@ -378,7 +378,7 @@
        doPreOperation(PreOperationSearchOperation searchOperation)
   {
     preOperationCounter.incrementAndGet();
-    return new PreOperationPluginResult();
+    return PreOperationPluginResult.SUCCESS;
   }
 
 
@@ -417,7 +417,7 @@
        doPostOperation(PostOperationAbandonOperation abandonOperation)
   {
     postOperationCounter.incrementAndGet();
-    return new PostOperationPluginResult();
+    return PostOperationPluginResult.SUCCESS;
   }
 
 
@@ -430,7 +430,7 @@
        doPostOperation(PostOperationAddOperation addOperation)
   {
     postOperationCounter.incrementAndGet();
-    return new PostOperationPluginResult();
+    return PostOperationPluginResult.SUCCESS;
   }
 
 
@@ -443,7 +443,7 @@
        doPostOperation(PostOperationBindOperation bindOperation)
   {
     postOperationCounter.incrementAndGet();
-    return new PostOperationPluginResult();
+    return PostOperationPluginResult.SUCCESS;
   }
 
 
@@ -456,7 +456,7 @@
        doPostOperation(PostOperationCompareOperation compareOperation)
   {
     postOperationCounter.incrementAndGet();
-    return new PostOperationPluginResult();
+    return PostOperationPluginResult.SUCCESS;
   }
 
 
@@ -469,7 +469,7 @@
        doPostOperation(PostOperationDeleteOperation deleteOperation)
   {
     postOperationCounter.incrementAndGet();
-    return new PostOperationPluginResult();
+    return PostOperationPluginResult.SUCCESS;
   }
 
 
@@ -482,7 +482,7 @@
        doPostOperation(PostOperationExtendedOperation extendedOperation)
   {
     postOperationCounter.incrementAndGet();
-    return new PostOperationPluginResult();
+    return PostOperationPluginResult.SUCCESS;
   }
 
 
@@ -495,7 +495,7 @@
        doPostOperation(PostOperationModifyOperation modifyOperation)
   {
     postOperationCounter.incrementAndGet();
-    return new PostOperationPluginResult();
+    return PostOperationPluginResult.SUCCESS;
   }
 
 
@@ -508,7 +508,7 @@
        doPostOperation(PostOperationModifyDNOperation modifyDNOperation)
   {
     postOperationCounter.incrementAndGet();
-    return new PostOperationPluginResult();
+    return PostOperationPluginResult.SUCCESS;
   }
 
 
@@ -521,7 +521,7 @@
        doPostOperation(PostOperationSearchOperation searchOperation)
   {
     postOperationCounter.incrementAndGet();
-    return new PostOperationPluginResult();
+    return PostOperationPluginResult.SUCCESS;
   }
 
 
@@ -534,7 +534,7 @@
        doPostOperation(PostOperationUnbindOperation unbindOperation)
   {
     postOperationCounter.incrementAndGet();
-    return new PostOperationPluginResult();
+    return PostOperationPluginResult.SUCCESS;
   }
 
 
@@ -573,7 +573,7 @@
        doPostResponse(PostResponseAddOperation addOperation)
   {
     postResponseCounter.incrementAndGet();
-    return new PostResponsePluginResult();
+    return PostResponsePluginResult.SUCCESS;
   }
 
 
@@ -586,7 +586,7 @@
        doPostResponse(PostResponseBindOperation bindOperation)
   {
     postResponseCounter.incrementAndGet();
-    return new PostResponsePluginResult();
+    return PostResponsePluginResult.SUCCESS;
   }
 
 
@@ -599,7 +599,7 @@
        doPostResponse(PostResponseCompareOperation compareOperation)
   {
     postResponseCounter.incrementAndGet();
-    return new PostResponsePluginResult();
+    return PostResponsePluginResult.SUCCESS;
   }
 
 
@@ -612,7 +612,7 @@
        doPostResponse(PostResponseDeleteOperation deleteOperation)
   {
     postResponseCounter.incrementAndGet();
-    return new PostResponsePluginResult();
+    return PostResponsePluginResult.SUCCESS;
   }
 
 
@@ -625,7 +625,7 @@
        doPostResponse(PostResponseExtendedOperation extendedOperation)
   {
     postResponseCounter.incrementAndGet();
-    return new PostResponsePluginResult();
+    return PostResponsePluginResult.SUCCESS;
   }
 
 
@@ -638,7 +638,7 @@
        doPostResponse(PostResponseModifyOperation modifyOperation)
   {
     postResponseCounter.incrementAndGet();
-    return new PostResponsePluginResult();
+    return PostResponsePluginResult.SUCCESS;
   }
 
 
@@ -651,7 +651,7 @@
        doPostResponse(PostResponseModifyDNOperation modifyDNOperation)
   {
     postResponseCounter.incrementAndGet();
-    return new PostResponsePluginResult();
+    return PostResponsePluginResult.SUCCESS;
   }
 
 
@@ -664,7 +664,7 @@
        doPostResponse(PostResponseSearchOperation searchOperation)
   {
     postResponseCounter.incrementAndGet();
-    return new PostResponsePluginResult();
+    return PostResponsePluginResult.SUCCESS;
   }
 
 
@@ -704,7 +704,7 @@
                           SearchResultEntry searchEntry)
   {
     searchEntryCounter.incrementAndGet();
-    return new SearchEntryPluginResult();
+    return SearchEntryPluginResult.SUCCESS;
   }
 
 
@@ -745,7 +745,7 @@
                               SearchResultReference searchReference)
   {
     searchReferenceCounter.incrementAndGet();
-    return new SearchReferencePluginResult();
+    return SearchReferencePluginResult.SUCCESS;
   }
 
 
@@ -785,7 +785,7 @@
               IntermediateResponse intermediateResponse)
   {
     intermediateResponseCounter.incrementAndGet();
-    return new IntermediateResponsePluginResult();
+    return IntermediateResponsePluginResult.SUCCESS;
   }
 
 
@@ -825,7 +825,7 @@
                                                     clientConnection)
   {
     postConnectCounter.incrementAndGet();
-    return new PostConnectPluginResult();
+    return PostConnectPluginResult.SUCCESS;
   }
 
 
@@ -865,7 +865,7 @@
        int msgID, String message)
   {
     postDisconnectCounter.incrementAndGet();
-    return new PostDisconnectPluginResult();
+    return PostDisconnectPluginResult.SUCCESS;
   }
 
 
@@ -904,7 +904,7 @@
                                        Entry entry)
   {
     ldifImportCounter.incrementAndGet();
-    return new LDIFPluginResult();
+    return LDIFPluginResult.SUCCESS;
   }
 
 
@@ -943,7 +943,7 @@
                                        Entry entry)
   {
     ldifExportCounter.incrementAndGet();
-    return new LDIFPluginResult();
+    return LDIFPluginResult.SUCCESS;
   }
 
 
@@ -1002,7 +1002,7 @@
   public StartupPluginResult doStartup()
   {
     startupCalled = true;
-    return new StartupPluginResult();
+    return StartupPluginResult.SUCCESS;
   }
 
 

--
Gitblit v1.10.0