From 0c4987c8590b051485e95bcda5e3f89c892d0ac5 Mon Sep 17 00:00:00 2001
From: Valery Kharseko <vharseko@3a-systems.ru>
Date: Tue, 04 Aug 2026 08:27:35 +0000
Subject: [PATCH] Fix CodeQL note-severity alerts: missing @Override annotations (#837)
---
opendj-server-legacy/src/snmp/src/org/opends/server/snmp/DsApplIfOpsEntryImpl.java | 3 +
opendj-server-legacy/src/main/java/org/opends/server/extensions/PBKDF2HmacSHA512PasswordStorageScheme.java | 5 ++
opendj-rest2ldap/src/main/java/org/forgerock/opendj/rest2ldap/SubResourceCollection.java | 2 +
opendj-server-legacy/src/main/java/org/opends/server/discovery/ServiceDiscoveryMechanismConfigManager.java | 2 +
opendj-server-legacy/src/main/java/org/opends/server/extensions/PBKDF2HmacSHA256PasswordStorageScheme.java | 5 ++
opendj-server-legacy/src/main/java/org/opends/server/extensions/PBKDF2PasswordStorageScheme.java | 5 ++
opendj-server-legacy/src/snmp/src/org/opends/server/snmp/SNMPUserAcl.java | 6 +++
opendj-server-legacy/src/snmp/src/org/opends/server/snmp/DsTableEntryImpl.java | 4 +
opendj-server-legacy/src/snmp/src/org/opends/server/snmp/SNMPMonitor.java | 1
opendj-server-legacy/src/main/java/org/opends/server/loggers/TextHTTPAccessLogPublisher.java | 36 +++++++++---------
opendj-server-legacy/src/snmp/src/org/opends/server/snmp/DsMIBImpl.java | 1
opendj-rest2ldap/src/main/java/org/forgerock/opendj/rest2ldap/SubResourceSingleton.java | 2 +
opendj-server-legacy/src/main/java/org/opends/server/types/WritabilityMode.java | 2 +
opendj-server-legacy/src/snmp/src/org/opends/server/snmp/SNMPInetAddressAcl.java | 10 +++++
opendj-core/src/main/java/org/forgerock/opendj/security/OpenDJProvider.java | 1
15 files changed, 66 insertions(+), 19 deletions(-)
diff --git a/opendj-core/src/main/java/org/forgerock/opendj/security/OpenDJProvider.java b/opendj-core/src/main/java/org/forgerock/opendj/security/OpenDJProvider.java
index 04f6c11..35f8859 100644
--- a/opendj-core/src/main/java/org/forgerock/opendj/security/OpenDJProvider.java
+++ b/opendj-core/src/main/java/org/forgerock/opendj/security/OpenDJProvider.java
@@ -126,6 +126,7 @@
super("OpenDJ", 1.0D, "OpenDJ LDAP security provider");
this.defaultConfig = defaultConfig;
AccessController.doPrivileged(new PrivilegedAction<Void>() {
+ @Override
public Void run() {
putService(new KeyStoreService());
return null;
diff --git a/opendj-rest2ldap/src/main/java/org/forgerock/opendj/rest2ldap/SubResourceCollection.java b/opendj-rest2ldap/src/main/java/org/forgerock/opendj/rest2ldap/SubResourceCollection.java
index 0e27feb..6d328c2 100644
--- a/opendj-rest2ldap/src/main/java/org/forgerock/opendj/rest2ldap/SubResourceCollection.java
+++ b/opendj-rest2ldap/src/main/java/org/forgerock/opendj/rest2ldap/SubResourceCollection.java
@@ -13,6 +13,7 @@
*
* Copyright 2016 ForgeRock AS.
* Portions Copyright 2017 Rosie Applications, Inc.
+ * Portions Copyright 2026 3A Systems, LLC.
*/
package org.forgerock.opendj.rest2ldap;
@@ -317,6 +318,7 @@
return router;
}
+ @Override
Promise<RoutingContext, ResourceException> route(final Context context) {
final Connection conn = context.asContext(AuthenticatedConnectionContext.class).getConnection();
final SearchRequest searchRequest = namingStrategy.createSearchRequest(dnFrom(context), idFrom(context));
diff --git a/opendj-rest2ldap/src/main/java/org/forgerock/opendj/rest2ldap/SubResourceSingleton.java b/opendj-rest2ldap/src/main/java/org/forgerock/opendj/rest2ldap/SubResourceSingleton.java
index 6182a24..41d86a6 100644
--- a/opendj-rest2ldap/src/main/java/org/forgerock/opendj/rest2ldap/SubResourceSingleton.java
+++ b/opendj-rest2ldap/src/main/java/org/forgerock/opendj/rest2ldap/SubResourceSingleton.java
@@ -13,6 +13,7 @@
*
* Copyright 2016 ForgeRock AS.
* Portions Copyright 2017 Rosie Applications, Inc.
+ * Portions Copyright 2026 3A Systems, LLC.
*/
package org.forgerock.opendj.rest2ldap;
@@ -135,6 +136,7 @@
return router;
}
+ @Override
Promise<RoutingContext, ResourceException> route(final Context context) {
return newResultPromise(newRoutingContext(context, dnFrom(context), resource));
}
diff --git a/opendj-server-legacy/src/main/java/org/opends/server/discovery/ServiceDiscoveryMechanismConfigManager.java b/opendj-server-legacy/src/main/java/org/opends/server/discovery/ServiceDiscoveryMechanismConfigManager.java
index 6aa1285..0dba85d 100644
--- a/opendj-server-legacy/src/main/java/org/opends/server/discovery/ServiceDiscoveryMechanismConfigManager.java
+++ b/opendj-server-legacy/src/main/java/org/opends/server/discovery/ServiceDiscoveryMechanismConfigManager.java
@@ -12,6 +12,7 @@
* information: "Portions Copyright [year] [name of copyright owner]".
*
* Copyright 2016 ForgeRock AS.
+ * Portions Copyright 2026 3A Systems, LLC.
*/
package org.opends.server.discovery;
@@ -152,6 +153,7 @@
/**
* Finalize all service discovery mechanism for shutdown.
*/
+ @Override
public void finalize()
{
for (ServiceDiscoveryMechanism<?> service : serviceDiscoveryMechanisms.values())
diff --git a/opendj-server-legacy/src/main/java/org/opends/server/extensions/PBKDF2HmacSHA256PasswordStorageScheme.java b/opendj-server-legacy/src/main/java/org/opends/server/extensions/PBKDF2HmacSHA256PasswordStorageScheme.java
index 9d8e604..2447ccc 100644
--- a/opendj-server-legacy/src/main/java/org/opends/server/extensions/PBKDF2HmacSHA256PasswordStorageScheme.java
+++ b/opendj-server-legacy/src/main/java/org/opends/server/extensions/PBKDF2HmacSHA256PasswordStorageScheme.java
@@ -12,6 +12,7 @@
* information: "Portions Copyright [year] [name of copyright owner]".
*
* Copyright 2013-2016 ForgeRock AS.
+ * Portions Copyright 2026 3A Systems, LLC.
*/
package org.opends.server.extensions;
@@ -30,18 +31,22 @@
public class PBKDF2HmacSHA256PasswordStorageScheme
extends AbstractPBKDF2PasswordStorageScheme
{
+ @Override
public String getStorageSchemeName() {
return STORAGE_SCHEME_NAME_PBKDF2_HMAC_SHA256;
}
+ @Override
public String getAuthPasswordSchemeName() {
return AUTH_PASSWORD_SCHEME_NAME_PBKDF2_HMAC_SHA256;
}
+ @Override
String getMessageDigestAlgorithm() {
return MESSAGE_DIGEST_ALGORITHM_PBKDF2_HMAC_SHA256;
}
+ @Override
int getDigestSize() {
return 32;
}
diff --git a/opendj-server-legacy/src/main/java/org/opends/server/extensions/PBKDF2HmacSHA512PasswordStorageScheme.java b/opendj-server-legacy/src/main/java/org/opends/server/extensions/PBKDF2HmacSHA512PasswordStorageScheme.java
index 55f1540..2b9a0de 100644
--- a/opendj-server-legacy/src/main/java/org/opends/server/extensions/PBKDF2HmacSHA512PasswordStorageScheme.java
+++ b/opendj-server-legacy/src/main/java/org/opends/server/extensions/PBKDF2HmacSHA512PasswordStorageScheme.java
@@ -12,6 +12,7 @@
* information: "Portions Copyright [year] [name of copyright owner]".
*
* Copyright 2013-2016 ForgeRock AS.
+ * Portions Copyright 2026 3A Systems, LLC.
*/
package org.opends.server.extensions;
@@ -30,18 +31,22 @@
public class PBKDF2HmacSHA512PasswordStorageScheme
extends AbstractPBKDF2PasswordStorageScheme
{
+ @Override
public String getStorageSchemeName() {
return STORAGE_SCHEME_NAME_PBKDF2_HMAC_SHA512;
}
+ @Override
public String getAuthPasswordSchemeName() {
return AUTH_PASSWORD_SCHEME_NAME_PBKDF2_HMAC_SHA512;
}
+ @Override
String getMessageDigestAlgorithm() {
return MESSAGE_DIGEST_ALGORITHM_PBKDF2_HMAC_SHA512;
}
+ @Override
int getDigestSize() {
return 64;
}
diff --git a/opendj-server-legacy/src/main/java/org/opends/server/extensions/PBKDF2PasswordStorageScheme.java b/opendj-server-legacy/src/main/java/org/opends/server/extensions/PBKDF2PasswordStorageScheme.java
index 5e0c21b..c0f4e0e 100644
--- a/opendj-server-legacy/src/main/java/org/opends/server/extensions/PBKDF2PasswordStorageScheme.java
+++ b/opendj-server-legacy/src/main/java/org/opends/server/extensions/PBKDF2PasswordStorageScheme.java
@@ -12,6 +12,7 @@
* information: "Portions Copyright [year] [name of copyright owner]".
*
* Copyright 2013-2016 ForgeRock AS.
+ * Portions Copyright 2026 3A Systems, LLC.
*/
package org.opends.server.extensions;
@@ -30,18 +31,22 @@
public class PBKDF2PasswordStorageScheme
extends AbstractPBKDF2PasswordStorageScheme
{
+ @Override
public String getStorageSchemeName() {
return STORAGE_SCHEME_NAME_PBKDF2;
}
+ @Override
public String getAuthPasswordSchemeName() {
return AUTH_PASSWORD_SCHEME_NAME_PBKDF2;
}
+ @Override
String getMessageDigestAlgorithm() {
return MESSAGE_DIGEST_ALGORITHM_PBKDF2;
}
+ @Override
int getDigestSize() {
return 20;
}
diff --git a/opendj-server-legacy/src/main/java/org/opends/server/loggers/TextHTTPAccessLogPublisher.java b/opendj-server-legacy/src/main/java/org/opends/server/loggers/TextHTTPAccessLogPublisher.java
index 406269b..52ba64e 100644
--- a/opendj-server-legacy/src/main/java/org/opends/server/loggers/TextHTTPAccessLogPublisher.java
+++ b/opendj-server-legacy/src/main/java/org/opends/server/loggers/TextHTTPAccessLogPublisher.java
@@ -60,43 +60,43 @@
// @formatter:off
// Extended log format standard fields
ELF_C_IP("c-ip")
- { Object valueOf(HTTPRequestInfo i, String tsf) { return i.getClientAddress (); } },
+ { @Override Object valueOf(HTTPRequestInfo i, String tsf) { return i.getClientAddress (); } },
ELF_C_PORT("c-port")
- { Object valueOf(HTTPRequestInfo i, String tsf) { return i.getClientPort(); } },
+ { @Override Object valueOf(HTTPRequestInfo i, String tsf) { return i.getClientPort(); } },
ELF_CS_HOST("cs-host")
- { Object valueOf(HTTPRequestInfo i, String tsf) { return i.getClientHost(); } },
+ { @Override Object valueOf(HTTPRequestInfo i, String tsf) { return i.getClientHost(); } },
ELF_CS_METHOD("cs-method")
- { Object valueOf(HTTPRequestInfo i, String tsf) { return i.getMethod(); } },
+ { @Override Object valueOf(HTTPRequestInfo i, String tsf) { return i.getMethod(); } },
ELF_CS_URI("cs-uri")
- { Object valueOf(HTTPRequestInfo i, String tsf) { return i.getUri().toString(); } },
+ { @Override Object valueOf(HTTPRequestInfo i, String tsf) { return i.getUri().toString(); } },
ELF_CS_URI_STEM("cs-uri-stem")
- { Object valueOf(HTTPRequestInfo i, String tsf) { return i.getUri().getRawPath(); } },
+ { @Override Object valueOf(HTTPRequestInfo i, String tsf) { return i.getUri().getRawPath(); } },
ELF_CS_URI_QUERY("cs-uri-query")
- { Object valueOf(HTTPRequestInfo i, String tsf) { return i.getUri().getRawQuery(); } },
+ { @Override Object valueOf(HTTPRequestInfo i, String tsf) { return i.getUri().getRawQuery(); } },
ELF_CS_USER_AGENT("cs(User-Agent)")
- { Object valueOf(HTTPRequestInfo i, String tsf) { return i.getUserAgent(); } },
+ { @Override Object valueOf(HTTPRequestInfo i, String tsf) { return i.getUserAgent(); } },
ELF_CS_USERNAME("cs-username")
- { Object valueOf(HTTPRequestInfo i, String tsf) { return i.getAuthUser(); } },
+ { @Override Object valueOf(HTTPRequestInfo i, String tsf) { return i.getAuthUser(); } },
ELF_CS_VERSION("cs-version")
- { Object valueOf(HTTPRequestInfo i, String tsf) { return i.getProtocol(); } },
+ { @Override Object valueOf(HTTPRequestInfo i, String tsf) { return i.getProtocol(); } },
ELF_S_COMPUTERNAME("s-computername")
- { Object valueOf(HTTPRequestInfo i, String tsf) { return i.getServerHost(); } },
+ { @Override Object valueOf(HTTPRequestInfo i, String tsf) { return i.getServerHost(); } },
ELF_S_IP("s-ip")
- { Object valueOf(HTTPRequestInfo i, String tsf) { return i.getServerAddress(); } },
+ { @Override Object valueOf(HTTPRequestInfo i, String tsf) { return i.getServerAddress(); } },
ELF_S_PORT("s-port")
- { Object valueOf(HTTPRequestInfo i, String tsf) { return i.getServerPort(); } },
+ { @Override Object valueOf(HTTPRequestInfo i, String tsf) { return i.getServerPort(); } },
ELF_SC_STATUS("sc-status")
- { Object valueOf(HTTPRequestInfo i, String tsf) { return i.getStatusCode(); } },
+ { @Override Object valueOf(HTTPRequestInfo i, String tsf) { return i.getStatusCode(); } },
// Application specific fields (eXtensions)
X_CONNECTION_ID("x-connection-id")
- { Object valueOf(HTTPRequestInfo i, String tsf) { return i.getConnectionID(); } },
+ { @Override Object valueOf(HTTPRequestInfo i, String tsf) { return i.getConnectionID(); } },
X_DATETIME("x-datetime")
- { Object valueOf(HTTPRequestInfo i, String tsf) { return getUserDefinedTime(tsf); } },
+ { @Override Object valueOf(HTTPRequestInfo i, String tsf) { return getUserDefinedTime(tsf); } },
X_ETIME("x-etime")
- { Object valueOf(HTTPRequestInfo i, String tsf) { return i.getTotalProcessingTime(); } },
+ { @Override Object valueOf(HTTPRequestInfo i, String tsf) { return i.getTotalProcessingTime(); } },
X_TRANSACTION_ID("x-transaction-id")
- { Object valueOf(HTTPRequestInfo i, String tsf) { return i.getTransactionId(); } };
+ { @Override Object valueOf(HTTPRequestInfo i, String tsf) { return i.getTransactionId(); } };
// @formatter:on
private final String name;
diff --git a/opendj-server-legacy/src/main/java/org/opends/server/types/WritabilityMode.java b/opendj-server-legacy/src/main/java/org/opends/server/types/WritabilityMode.java
index 280d59a..f50a999 100644
--- a/opendj-server-legacy/src/main/java/org/opends/server/types/WritabilityMode.java
+++ b/opendj-server-legacy/src/main/java/org/opends/server/types/WritabilityMode.java
@@ -13,6 +13,7 @@
*
* Copyright 2006-2008 Sun Microsystems, Inc.
* Portions Copyright 2014-2015 ForgeRock AS.
+ * Portions Copyright 2026 3A Systems, LLC.
*/
package org.opends.server.types;
@@ -110,6 +111,7 @@
*
* @return A string representation of this writability mode.
*/
+ @Override
public String toString()
{
return modeName;
diff --git a/opendj-server-legacy/src/snmp/src/org/opends/server/snmp/DsApplIfOpsEntryImpl.java b/opendj-server-legacy/src/snmp/src/org/opends/server/snmp/DsApplIfOpsEntryImpl.java
index 683e884..cd37c0b 100644
--- a/opendj-server-legacy/src/snmp/src/org/opends/server/snmp/DsApplIfOpsEntryImpl.java
+++ b/opendj-server-legacy/src/snmp/src/org/opends/server/snmp/DsApplIfOpsEntryImpl.java
@@ -13,6 +13,7 @@
*
* Copyright 2008 Sun Microsystems, Inc.
* Portions Copyright 2012-2014 ForgeRock AS.
+ * Portions Copyright 2026 3A Systems, LLC.
*/
package org.opends.server.snmp;
@@ -85,6 +86,7 @@
* Getter for the "DsApplIfProtocol" variable.
* @return an OID representing the connection handler:port
*/
+ @Override
public String getDsApplIfProtocol() {
String portNumber = (String)this.monitor.getAttribute
(this.connectionHandlerName, "ds-connectionhandler-listener");
@@ -326,6 +328,7 @@
* Returns the ObjectName of the SNMP entry MBean.
* @return ObjectName of the entry
*/
+ @Override
public ObjectName getObjectName() {
if (this.entryName == null) {
try {
diff --git a/opendj-server-legacy/src/snmp/src/org/opends/server/snmp/DsMIBImpl.java b/opendj-server-legacy/src/snmp/src/org/opends/server/snmp/DsMIBImpl.java
index d616140..057285c 100644
--- a/opendj-server-legacy/src/snmp/src/org/opends/server/snmp/DsMIBImpl.java
+++ b/opendj-server-legacy/src/snmp/src/org/opends/server/snmp/DsMIBImpl.java
@@ -156,6 +156,7 @@
* @param notification received
* @param handback The handback
*/
+ @Override
public void handleNotification(Notification notification, Object handback) {
if (notification instanceof MBeanServerNotification) {
MBeanServerNotification notif = (MBeanServerNotification) notification;
diff --git a/opendj-server-legacy/src/snmp/src/org/opends/server/snmp/DsTableEntryImpl.java b/opendj-server-legacy/src/snmp/src/org/opends/server/snmp/DsTableEntryImpl.java
index 99ca0b9..95bfc36 100644
--- a/opendj-server-legacy/src/snmp/src/org/opends/server/snmp/DsTableEntryImpl.java
+++ b/opendj-server-legacy/src/snmp/src/org/opends/server/snmp/DsTableEntryImpl.java
@@ -13,7 +13,7 @@
*
* Copyright 2008-2009 Sun Microsystems, Inc.
* Portions Copyright 2014 ForgeRock AS.
- * Portions Copyright 2024 3A Systems, LLC.
+ * Portions Copyright 2024-2026 3A Systems, LLC.
*/
package org.opends.server.snmp;
@@ -80,6 +80,7 @@
* Getter for the "DsServerType" variable.
* @return a Byte[] representing the Ds Server Type
*/
+ @Override
public Byte[] getDsServerType() {
try {
String value1 = (String) this.monitor.getAttribute(
@@ -169,6 +170,7 @@
* Gets the object of the entry.
* @return ObjectName of the entry
*/
+ @Override
public ObjectName getObjectName() {
if (this.entryName == null) {
try {
diff --git a/opendj-server-legacy/src/snmp/src/org/opends/server/snmp/SNMPInetAddressAcl.java b/opendj-server-legacy/src/snmp/src/org/opends/server/snmp/SNMPInetAddressAcl.java
index 38d3abf..ac76768 100644
--- a/opendj-server-legacy/src/snmp/src/org/opends/server/snmp/SNMPInetAddressAcl.java
+++ b/opendj-server-legacy/src/snmp/src/org/opends/server/snmp/SNMPInetAddressAcl.java
@@ -87,6 +87,7 @@
* Gets the name of the acl.
* @return the name of the acl as a String
*/
+ @Override
public String getName() {
return "OpenDS";
}
@@ -94,6 +95,7 @@
/**
* {@inheritDoc}
*/
+ @Override
public boolean checkReadPermission(InetAddress address) {
if (this.allManagers) {
return true;
@@ -110,6 +112,7 @@
/**
* {@inheritDoc}
*/
+ @Override
public boolean checkReadPermission(InetAddress address, String community) {
if ((this.checkReadPermission(address)) &&
(this.checkCommunity(community))) {
@@ -122,6 +125,7 @@
/**
* {@inheritDoc}
*/
+ @Override
public boolean checkCommunity(String community) {
return this.communities.equals(community);
}
@@ -129,6 +133,7 @@
/**
* {@inheritDoc}
*/
+ @Override
public boolean checkWritePermission(InetAddress address) {
// WRITE Access are always denied
return false;
@@ -137,6 +142,7 @@
/**
* {@inheritDoc}
*/
+ @Override
public boolean checkWritePermission(InetAddress address, String community) {
// WRITE Access are always denied
return false;
@@ -146,6 +152,7 @@
* {@inheritDoc}
* @return the list of traps destinations
*/
+ @Override
public Enumeration getTrapDestinations() {
Vector<InetAddress> tempDests = new Vector<InetAddress>();
for (String dest : this.trapsDestinations) {
@@ -161,6 +168,7 @@
* {@inheritDoc}
* @return the list of communities
*/
+ @Override
public Enumeration getTrapCommunities(InetAddress address) {
Vector<String> trapCommunities = new Vector<String>();
trapCommunities.add(this.trapsCommunity);
@@ -171,6 +179,7 @@
* {@inheritDoc}
* @return an empty enumeration
*/
+ @Override
public Enumeration getInformDestinations() {
Vector<String> informDests = new Vector<String>();
return informDests.elements();
@@ -180,6 +189,7 @@
* {@inheritDoc}
* @return an empty enumeration
*/
+ @Override
public Enumeration getInformCommunities(InetAddress address) {
Vector<String> informCommunities = new Vector<String>();
return informCommunities.elements();
diff --git a/opendj-server-legacy/src/snmp/src/org/opends/server/snmp/SNMPMonitor.java b/opendj-server-legacy/src/snmp/src/org/opends/server/snmp/SNMPMonitor.java
index 339ca3c..42dc7be 100644
--- a/opendj-server-legacy/src/snmp/src/org/opends/server/snmp/SNMPMonitor.java
+++ b/opendj-server-legacy/src/snmp/src/org/opends/server/snmp/SNMPMonitor.java
@@ -286,6 +286,7 @@
return Subject.doAs(this.subject, new PrivilegedAction()
{
+ @Override
public Object run()
{
try
diff --git a/opendj-server-legacy/src/snmp/src/org/opends/server/snmp/SNMPUserAcl.java b/opendj-server-legacy/src/snmp/src/org/opends/server/snmp/SNMPUserAcl.java
index d200860..02114bc 100644
--- a/opendj-server-legacy/src/snmp/src/org/opends/server/snmp/SNMPUserAcl.java
+++ b/opendj-server-legacy/src/snmp/src/org/opends/server/snmp/SNMPUserAcl.java
@@ -66,12 +66,14 @@
}
/** {@inheritDoc} */
+ @Override
public String getName() {
// ACL Name
return "OpenDS";
}
/** {@inheritDoc} */
+ @Override
public boolean checkReadPermission(String user) {
// Test if clone user
if (user.equals(DEFAULT_USER) || user.equals(ADMIN_USER)) {
@@ -85,6 +87,7 @@
/**
* {@inheritDoc}
*/
+ @Override
public boolean checkReadPermission(String user, String contextName,
int securityLevel) {
// Special check for the defaultUser
@@ -104,6 +107,7 @@
* {@inheritDoc}
* @return true if the context is correct, false otherwise.
*/
+ @Override
public boolean checkContextName(String contextName) {
return this.contextName.equals(contextName);
}
@@ -113,11 +117,13 @@
* @param user to check the write permission.
* @return true if the user has the write permission, false otherwise.
*/
+ @Override
public boolean checkWritePermission(String user) {
return user.equals(ADMIN_USER);
}
/** {@inheritDoc} */
+ @Override
public boolean checkWritePermission(String user, String contextName,
int securityLevel) {
return checkWritePermission(user)
--
Gitblit v1.10.0