From 131d6ec1c08207b7d557f20f556211410c47dc4e Mon Sep 17 00:00:00 2001
From: Nicolas Capponi <nicolas.capponi@forgerock.com>
Date: Wed, 25 Feb 2015 16:26:07 +0000
Subject: [PATCH] Clean up duplicate tests in TestRDN
---
opendj-server-legacy/src/test/java/org/opends/server/types/TestRDN.java | 47 ++++-------------------------------------------
1 files changed, 4 insertions(+), 43 deletions(-)
diff --git a/opendj-server-legacy/src/test/java/org/opends/server/types/TestRDN.java b/opendj-server-legacy/src/test/java/org/opends/server/types/TestRDN.java
index 988fd9a..531dfb2 100644
--- a/opendj-server-legacy/src/test/java/org/opends/server/types/TestRDN.java
+++ b/opendj-server-legacy/src/test/java/org/opends/server/types/TestRDN.java
@@ -243,7 +243,7 @@
* If the test failed unexpectedly.
*/
@Test(dataProvider = "testRDNs")
- public void testNormalizeToReadableString(String rawRDN, String normRDN, String stringRDN) throws Exception {
+ public void testNormalizationToSafeUrlString(String rawRDN, String normRDN, String stringRDN) throws Exception {
RDN rdn = RDN.decode(rawRDN);
StringBuilder buffer = new StringBuilder();
buffer.append(normRDN);
@@ -310,20 +310,12 @@
}
-
- /**
- * Test getAttributeName IndexOutOfBoundsException.
- *
- * @throws Exception
- * If the test failed unexpectedly.
- */
+ @SuppressWarnings("javadoc")
@Test(expectedExceptions = IllegalArgumentException.class)
- public void testGetAttributeNameException() throws Exception {
- RDN rdn = new RDN(new AttributeType[0], new String[0], new ByteString[0]);
+ public void ensureRDNIsCreatedWithNonEmptyArguments() throws Exception {
+ new RDN(new AttributeType[0], new String[0], new ByteString[0]);
}
-
-
/**
* Test getAttributeType.
*
@@ -343,21 +335,6 @@
assertEquals(rdn.getAttributeType(1), AT_CN);
}
-
-
- /**
- * Test getAttributeType IndexOutOfBoundsException.
- *
- * @throws Exception
- * If the test failed unexpectedly.
- */
- @SuppressWarnings("unused")
- @Test(expectedExceptions = IllegalArgumentException.class)
- public void testGetAttributeTypeException() throws Exception {
- new RDN(new AttributeType[0], new String[0], new ByteString[0]);
- }
-
-
/**
* Test getAttributeValue.
*
@@ -377,22 +354,6 @@
assertEquals(rdn.getAttributeValue(1), AV_CN);
}
-
-
- /**
- * Test getAttributeValue IndexOutOfBoundsException.
- *
- * @throws Exception
- * If the test failed unexpectedly.
- */
- @SuppressWarnings("unused")
- @Test(expectedExceptions = IllegalArgumentException.class)
- public void testGetAttributeValueException() throws Exception {
- new RDN(new AttributeType[0], new String[0], new ByteString[0]);
- }
-
-
-
/**
* Test getAttributeValue.
*
--
Gitblit v1.10.0