From 17b9ab961446c89061229396a2cb00a3976fe87e Mon Sep 17 00:00:00 2001
From: kenneth_suter <kenneth_suter@localhost>
Date: Thu, 31 May 2007 20:23:15 +0000
Subject: [PATCH] This commit essentially removes the step of backing up the databases as part of an upgrade. There are concerns that this may take a long time or eat up lots of resources in cases where there is alot of data. Also if the data is important it is likely that there will be a separate backup strategy for this.
---
opendj-sdk/opends/src/quicksetup/org/opends/quicksetup/upgrader/Upgrader.java | 30 ++++++++++++++++--------------
opendj-sdk/opends/src/quicksetup/org/opends/quicksetup/upgrader/UpgradeUserData.java | 11 +++++++++++
2 files changed, 27 insertions(+), 14 deletions(-)
diff --git a/opendj-sdk/opends/src/quicksetup/org/opends/quicksetup/upgrader/UpgradeUserData.java b/opendj-sdk/opends/src/quicksetup/org/opends/quicksetup/upgrader/UpgradeUserData.java
index 382449e..aa2a7eb 100644
--- a/opendj-sdk/opends/src/quicksetup/org/opends/quicksetup/upgrader/UpgradeUserData.java
+++ b/opendj-sdk/opends/src/quicksetup/org/opends/quicksetup/upgrader/UpgradeUserData.java
@@ -76,4 +76,15 @@
this.buildToDownload = build;
}
+ /**
+ * Indicates whether or not the upgrader should perform a
+ * backup of the databases as part of the upgrade.
+ * @return boolean where true indicates that the databases
+ * should be backed up
+ */
+ public boolean getPerformDatabaseBackup() {
+ // It would be nice to make this an option (see issue 1740)
+ return false;
+ }
+
}
diff --git a/opendj-sdk/opends/src/quicksetup/org/opends/quicksetup/upgrader/Upgrader.java b/opendj-sdk/opends/src/quicksetup/org/opends/quicksetup/upgrader/Upgrader.java
index 63a45e7..515793b 100644
--- a/opendj-sdk/opends/src/quicksetup/org/opends/quicksetup/upgrader/Upgrader.java
+++ b/opendj-sdk/opends/src/quicksetup/org/opends/quicksetup/upgrader/Upgrader.java
@@ -137,11 +137,11 @@
"summary-upgrade-calculating-schema-customization", 40),
CALCULATING_CONFIGURATION_CUSTOMIZATIONS(
- "summary-upgrade-calculating-config-customization", 45),
+ "summary-upgrade-calculating-config-customization", 48),
BACKING_UP_DATABASES("summary-upgrade-backing-up-db", 50),
- BACKING_UP_FILESYSTEM("summary-upgrade-backing-up-files",55),
+ BACKING_UP_FILESYSTEM("summary-upgrade-backing-up-files",52),
UPGRADING_COMPONENTS("summary-upgrade-upgrading-components", 60),
@@ -796,18 +796,20 @@
checkAbort();
- try {
- LOG.log(Level.INFO, "backing up databases");
- setCurrentProgressStep(UpgradeProgressStep.BACKING_UP_DATABASES);
- backupDatabases();
- notifyListeners(formatter.getFormattedDone() +
- formatter.getLineBreak());
- LOG.log(Level.INFO, "database backup finished");
- } catch (ApplicationException e) {
- notifyListeners(formatter.getFormattedError() +
- formatter.getLineBreak());
- LOG.log(Level.INFO, "Error backing up databases", e);
- throw e;
+ if (getUpgradeUserData().getPerformDatabaseBackup()) {
+ try {
+ LOG.log(Level.INFO, "backing up databases");
+ setCurrentProgressStep(UpgradeProgressStep.BACKING_UP_DATABASES);
+ backupDatabases();
+ notifyListeners(formatter.getFormattedDone() +
+ formatter.getLineBreak());
+ LOG.log(Level.INFO, "database backup finished");
+ } catch (ApplicationException e) {
+ notifyListeners(formatter.getFormattedError() +
+ formatter.getLineBreak());
+ LOG.log(Level.INFO, "Error backing up databases", e);
+ throw e;
+ }
}
checkAbort();
--
Gitblit v1.10.0